You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "complone (via GitHub)" <gi...@apache.org> on 2023/04/28 12:23:58 UTC
[GitHub] [rocketmq-eventbridge] complone commented on a diff in pull request #94: feat: Add a daemon thread to ensure that it will not exit abnormally
complone commented on code in PR #94:
URL: https://github.com/apache/rocketmq-eventbridge/pull/94#discussion_r1180340383
##########
adapter/runtimer/src/main/java/org/apache/rocketmq/eventbridge/adapter/runtimer/Runtimer.java:
##########
@@ -75,9 +82,23 @@ public void initAndStart() {
circulatorContext.initListenerMetadata(runnerConfigObserver.getTargetRunnerConfig());
runnerConfigObserver.registerListener(circulatorContext);
runnerConfigObserver.registerListener(eventSubscriber);
- new EventBusListener(circulatorContext, eventSubscriber, errorHandler).start();
- new EventRuleTransfer(circulatorContext, offsetManager, errorHandler).start();
- new EventTargetPusher(circulatorContext, offsetManager, errorHandler).start();
+ EventBusListener eventBusListener = new EventBusListener(circulatorContext, eventSubscriber, errorHandler);
+ EventRuleTransfer eventRuleTransfer = new EventRuleTransfer(circulatorContext, offsetManager, errorHandler);
+ EventTargetPusher eventTargetPusher = new EventTargetPusher(circulatorContext, offsetManager, errorHandler);
+ ConcurrentHashMap<Thread, ExecutorService> threadThreadPoolExecutorMap = new ConcurrentHashMap<Thread, ExecutorService>() {
+ {
+ put(new Thread(eventBusListener, eventBusListener.getServiceName()), Executors.newSingleThreadExecutor());
+ put(new Thread(eventRuleTransfer, eventRuleTransfer.getServiceName()), Executors.newSingleThreadExecutor());
+ put(new Thread(eventTargetPusher, eventTargetPusher.getServiceName()), Executors.newSingleThreadExecutor());
Review Comment:
会议补充:每个组件内部的线程池,消费者等资源。考虑到创建顺序也应该依次退出
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org