You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/12/27 21:16:19 UTC

[GitHub] [airflow] mik-laj edited a comment on issue #13315: Verify production image with all the components

mik-laj edited a comment on issue #13315:
URL: https://github.com/apache/airflow/issues/13315#issuecomment-751516750


   I am not sure if we need to verify the installation of every possible library.  If they are written in Python, they should probably work fine in any case.  I am concerned about native libraries, especially libraries that need to be compiled during installation. When we use multi-stage build, it may turn out that we are missing system dependencies or the system dependency is incompatible.  For the most part, this is what pip does just fine, but only when we're actually using it, and not just copying the necessary files.
   https://github.com/apache/airflow/blob/98896e4e327f256fd04087a49a13e16a246022c9/Dockerfile#L425
   For example:
   If you delete this line of code, the installation will still be successful, because only when loading the class it turns out that we need to install an additional system library ..
   https://github.com/apache/airflow/blob/3017ace5721f770b2280d11befc21af13446c6eb/Dockerfile#L351


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org