You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@buildstream.apache.org by ju...@apache.org on 2021/03/18 09:40:16 UTC

[buildstream] 01/05: element.py: Drop unnecessary `_can_query_cache()` check

This is an automated email from the ASF dual-hosted git repository.

juergbi pushed a commit to branch juerg/build-with-source-push
in repository https://gitbox.apache.org/repos/asf/buildstream.git

commit b896138515232abe7ee9f73d3798f3f44636fe67
Author: Jürg Billeter <j...@bitron.ch>
AuthorDate: Wed Mar 17 11:25:38 2021 +0100

    element.py: Drop unnecessary `_can_query_cache()` check
    
    `_pull_pending()` is now a trivial method and it doesn't make sense to
    guard it with `_can_query_cache()`.
---
 src/buildstream/element.py | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/src/buildstream/element.py b/src/buildstream/element.py
index 6a296bf..ff21657 100644
--- a/src/buildstream/element.py
+++ b/src/buildstream/element.py
@@ -1594,9 +1594,7 @@ class Element(Plugin):
     def __should_schedule(self):
         # We're processing if we're already scheduled, we've
         # finished assembling or if we're waiting to pull.
-        processing = (
-            self.__assemble_scheduled or self.__assemble_done or (self._can_query_cache() and self._pull_pending())
-        )
+        processing = self.__assemble_scheduled or self.__assemble_done or self._pull_pending()
 
         # We should schedule a build when
         return (