You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/11/19 09:43:58 UTC

[GitHub] [apisix] shuaijinchao commented on a change in pull request #5538: feat(plugin): support google cloud logging service

shuaijinchao commented on a change in pull request #5538:
URL: https://github.com/apache/apisix/pull/5538#discussion_r753027281



##########
File path: t/lib/server.lua
##########
@@ -426,6 +426,83 @@ function _M._well_known_openid_configuration()
     ngx.say(openid_data)
 end
 
+function _M.google_logging_token()
+    ngx.req.read_body()
+    local data = ngx.decode_args(ngx.req.get_body_data())
+    local jwt = require("resty.jwt")
+    local rsa_public_key = "-----BEGIN PUBLIC KEY-----\nMFwwDQYJKoZIhvcNAQEBBQADSwAwSAJBAKebDxlvQMGyEesAL1r1nIJBkSdqu3Hr\n7noq/0ukiZqVQLSJPMOv0oxQSutvvK3hoibwGakDOza+xRITB7cs2cECAwEAAQ==\n-----END PUBLIC KEY-----"

Review comment:
       I noticed this problem during the development process. But this public_key is only used by Google Logging related functions? Is it necessary to define it in a public variable in the file?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org