You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2016/11/16 18:46:16 UTC
[kudu-CR] [hybrid clock] update on NowWithError's signature
Alexey Serbin has uploaded a new change for review.
http://gerrit.cloudera.org:8080/5108
Change subject: [hybrid_clock] update on NowWithError's signature
......................................................................
[hybrid_clock] update on NowWithError's signature
Made the the clock error parameter of the HubridClock::NowWithError()
method optional.
This patch does not contain any functional changes.
Change-Id: Ia64eb9502c7fc4c10007f4f88f3346394fbdd50e
---
M src/kudu/server/hybrid_clock-test.cc
M src/kudu/server/hybrid_clock.cc
M src/kudu/server/hybrid_clock.h
3 files changed, 14 insertions(+), 14 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/08/5108/1
--
To view, visit http://gerrit.cloudera.org:8080/5108
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia64eb9502c7fc4c10007f4f88f3346394fbdd50e
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
[kudu-CR] [hybrid clock] update on NowWithError's signature
Posted by "David Ribeiro Alves (Code Review)" <ge...@cloudera.org>.
David Ribeiro Alves has posted comments on this change.
Change subject: [hybrid_clock] update on NowWithError's signature
......................................................................
Patch Set 1:
what is the goal here? we usually frown on optional args in outside of tests without a good reason, and this adds an extra branch... it also seems a bit silly from a public api prespective to call NowWithError and then not want the error back, there's Now for that. I do see that we ignore it internally but that's more because of internal reuse.
--
To view, visit http://gerrit.cloudera.org:8080/5108
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia64eb9502c7fc4c10007f4f88f3346394fbdd50e
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No
[kudu-CR] [hybrid clock] update on NowWithError's signature
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has abandoned this change.
Change subject: [hybrid_clock] update on NowWithError's signature
......................................................................
Abandoned
--
To view, visit http://gerrit.cloudera.org:8080/5108
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: abandon
Gerrit-Change-Id: Ia64eb9502c7fc4c10007f4f88f3346394fbdd50e
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] [hybrid clock] update on NowWithError's signature
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change.
Change subject: [hybrid_clock] update on NowWithError's signature
......................................................................
Patch Set 1:
> what is the goal here? we usually frown on optional args in outside
> of tests without a good reason, and this adds an extra branch... it
> also seems a bit silly from a public api prespective to call
> NowWithError and then not want the error back, there's Now for
> that. I do see that we ignore it internally but that's more because
> of internal reuse.
All right, then I'll update the call places where NowWithError() is called and the error argument is ignored.
--
To view, visit http://gerrit.cloudera.org:8080/5108
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia64eb9502c7fc4c10007f4f88f3346394fbdd50e
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No