[GitHub] [solr] magibney commented on a diff in pull request #1302: SOLR-16628: Ensure that InputStreams are closed after Xml parsing

[GitBox <gi...@apache.org>]

magibney commented on code in PR #1302:
URL: https://github.com/apache/solr/pull/1302#discussion_r1080690072


##########
solr/core/src/java/org/apache/solr/core/SolrConfig.java:
##########
@@ -393,14 +393,22 @@ private SolrConfig(
   }
 
   private IndexSchemaFactory.VersionedConfig readXml(SolrResourceLoader loader, String name) {
+    InputStream in = null;
     try {
-      ResourceProvider rp = new ResourceProvider(loader, name);
+      in = loader.openResource(name);

Review Comment:
   I think we cannot, unfortunately; because in most cases the InputStream should have been closed properly by the parser before reaching our `finally` block, so we're really relying on the "exception-swallowing" quality of `IOUtils.closeQuietly()`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org