[kudu] branch master updated: KUDU-1945 Fix TSAN warnings in client-test.cc

[ab...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

abukor pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/kudu.git


The following commit(s) were added to refs/heads/master by this push:
     new fa74ae752 KUDU-1945 Fix TSAN warnings in client-test.cc
fa74ae752 is described below

commit fa74ae75244ad18060ebb07be97bd63c0f24c1e1
Author: Abhishek Chennaka <ac...@cloudera.com>
AuthorDate: Tue Jan 17 08:41:14 2023 -0800

    KUDU-1945 Fix TSAN warnings in client-test.cc
    
    This patch addresses the TSAN warnings seen due to race conditions
    in the test ClientTestAutoIncrementingColumn.ConcurrentWrites in
    client-test.cc.
    
    Without any modification 5/1024 failed:
    http://dist-test.cloudera.org/job?job_id=root.1673953260.499709
    
    With the proposed changes: 0/1024 failed:
    http://dist-test.cloudera.org/job?job_id=root.1673952868.476619
    
    Thanks to Marton for helping out with the dist-test.
    
    Change-Id: I24315c24ed7424e641837cf2d681262584f3e4d5
    Reviewed-on: http://gerrit.cloudera.org:8080/19427
    Reviewed-by: Marton Greber <gr...@gmail.com>
    Reviewed-by: Attila Bukor <ab...@apache.org>
    Tested-by: Attila Bukor <ab...@apache.org>
---
 src/kudu/client/client-test.cc | 2 --
 1 file changed, 2 deletions(-)

diff --git a/src/kudu/client/client-test.cc b/src/kudu/client/client-test.cc
index 8723df23d..9bb45617e 100644
--- a/src/kudu/client/client-test.cc
+++ b/src/kudu/client/client-test.cc
@@ -9949,7 +9949,6 @@ TEST_F(ClientTestAutoIncrementingColumn, ConcurrentWrites) {
 
   // Write into the table with eight clients concurrently without specifying values
   // for the auto-incrementing column.
-  vector<shared_ptr<KuduClient>> clients;
   CountDownLatch client_latch(num_clients);
   vector<thread> threads;
   for (int i = 0; i < num_clients; i++) {
@@ -9958,7 +9957,6 @@ TEST_F(ClientTestAutoIncrementingColumn, ConcurrentWrites) {
       ASSERT_OK(KuduClientBuilder()
                 .add_master_server_addr(cluster_->mini_master()->bound_rpc_addr().ToString())
                 .Build(&client));
-      clients.emplace_back(client);
       shared_ptr<KuduSession> session = client->NewSession();
       shared_ptr<KuduTable> table;
       ASSERT_OK(client->OpenTable(kTableName, &table));