You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/04/28 17:34:21 UTC

[GitHub] [cloudstack] mbrashearnttglobalnet opened a new pull request #4048: Update DpdkDriverImpl.java to support DPDK trunk interfaces

mbrashearnttglobalnet opened a new pull request #4048:
URL: https://github.com/apache/cloudstack/pull/4048


   Update to support trunk interfaces for DPDK enabled hosts.
   
   ## Description
   <!--- Describe your changes in detail -->
   
   <!-- For new features, provide link to FS, dev ML discussion etc. -->
   <!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
   
   <!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
   <!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
   <!-- Fixes: # -->
   
   ## Types of changes
   <!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->
   - [ ] Breaking change (fix or feature that would cause existing functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [ ] Bug fix (non-breaking change which fixes an issue)
   - [ ] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ## Screenshots (if appropriate):
   
   ## How Has This Been Tested?
   <!-- Please describe in detail how you tested your changes. -->
   <!-- Include details of your testing environment, and the tests you ran to -->
   <!-- see how your change affects other areas of the code, etc. -->
   
   
   <!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md) document -->
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] rhtyd commented on pull request #4048: Update DpdkDriverImpl.java to support DPDK trunk interfaces

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4048:
URL: https://github.com/apache/cloudstack/pull/4048#issuecomment-638561807


   @blueorangutan package


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] rhtyd commented on pull request #4048: Update DpdkDriverImpl.java to support DPDK trunk interfaces

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4048:
URL: https://github.com/apache/cloudstack/pull/4048#issuecomment-643062351


   Travis has passed, our smoketests test only kvm with bridge driver.
   Merging based on this.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] mbrashearnttglobalnet commented on a change in pull request #4048: Update DpdkDriverImpl.java to support DPDK trunk interfaces

Posted by GitBox <gi...@apache.org>.
mbrashearnttglobalnet commented on a change in pull request #4048:
URL: https://github.com/apache/cloudstack/pull/4048#discussion_r417432502



##########
File path: plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/dpdk/DpdkDriverImpl.java
##########
@@ -70,9 +70,15 @@ public void addDpdkPort(String bridgeName, String port, String vlan, DpdkHelper.
                 dpdkPortVhostUserClientType;
 
         StringBuilder stringBuilder = new StringBuilder();
-        stringBuilder.append(String.format("ovs-vsctl add-port %s %s " +
-                "vlan_mode=access tag=%s " +
-                "-- set Interface %s type=%s", bridgeName, port, vlan, port, type));
+        
+        if (Integer.parseInt(vlan) > 0 && Integer.parseInt(vlan) < 4095) {
+            stringBuilder.append(String.format("ovs-vsctl add-port %s %s " +
+                    "vlan_mode=access tag=%s " +

Review comment:
       updated




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4048: Update DpdkDriverImpl.java to support DPDK trunk interfaces

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4048:
URL: https://github.com/apache/cloudstack/pull/4048#issuecomment-638583123


   Packaging result: ✔centos7 ✖debian. JID-1282


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] DaanHoogland commented on pull request #4048: Update DpdkDriverImpl.java to support DPDK trunk interfaces

Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4048:
URL: https://github.com/apache/cloudstack/pull/4048#issuecomment-640439122


   @blueorangutan package


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] DaanHoogland commented on pull request #4048: Update DpdkDriverImpl.java to support DPDK trunk interfaces

Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4048:
URL: https://github.com/apache/cloudstack/pull/4048#issuecomment-640475226


   @nvazquez you ok like this?
   @blueorangutan test


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4048: Update DpdkDriverImpl.java to support DPDK trunk interfaces

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4048:
URL: https://github.com/apache/cloudstack/pull/4048#issuecomment-640476042


   @DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4048: Update DpdkDriverImpl.java to support DPDK trunk interfaces

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4048:
URL: https://github.com/apache/cloudstack/pull/4048#issuecomment-640316914


   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4048: Update DpdkDriverImpl.java to support DPDK trunk interfaces

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4048:
URL: https://github.com/apache/cloudstack/pull/4048#issuecomment-621327272


   Packaging result: ✖centos7 ✖debian. JID-1201


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4048: Update DpdkDriverImpl.java to support DPDK trunk interfaces

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4048:
URL: https://github.com/apache/cloudstack/pull/4048#issuecomment-640454745


   Packaging result: ✔centos7 ✔debian. JID-1313


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4048: Update DpdkDriverImpl.java to support DPDK trunk interfaces

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4048:
URL: https://github.com/apache/cloudstack/pull/4048#issuecomment-638562015


   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] rhtyd commented on pull request #4048: Update DpdkDriverImpl.java to support DPDK trunk interfaces

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4048:
URL: https://github.com/apache/cloudstack/pull/4048#issuecomment-640316660


   @blueorangutan package


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4048: Update DpdkDriverImpl.java to support DPDK trunk interfaces

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4048:
URL: https://github.com/apache/cloudstack/pull/4048#issuecomment-640439622


   @DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] mbrashearnttglobalnet commented on a change in pull request #4048: Update DpdkDriverImpl.java to support DPDK trunk interfaces

Posted by GitBox <gi...@apache.org>.
mbrashearnttglobalnet commented on a change in pull request #4048:
URL: https://github.com/apache/cloudstack/pull/4048#discussion_r417537868



##########
File path: plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/dpdk/DpdkDriverImpl.java
##########
@@ -70,10 +70,12 @@ public void addDpdkPort(String bridgeName, String port, String vlan, DpdkHelper.
                 dpdkPortVhostUserClientType;
 
         StringBuilder stringBuilder = new StringBuilder();
-        stringBuilder.append(String.format("ovs-vsctl add-port %s %s " +
-                "vlan_mode=access tag=%s " +
-                "-- set Interface %s type=%s", bridgeName, port, vlan, port, type));
-
+        stringBuilder.append(String.format("ovs-vsctl add-port %s %s ", bridgeName, port));
+        if (Integer.parseInt(vlan) > 0 && Integer.parseInt(vlan) < 4095) {
+            stringBuilder.append(String.format("vlan_mode=access tag=%s ", vlan));
+        }
+        stringBuilder.append(String.format("-- set Interface %s type=%s", port, type));
+        

Review comment:
       removed the white spaces on the blank line.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] rhtyd merged pull request #4048: Update DpdkDriverImpl.java to support DPDK trunk interfaces

Posted by GitBox <gi...@apache.org>.
rhtyd merged pull request #4048:
URL: https://github.com/apache/cloudstack/pull/4048


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4048: Update DpdkDriverImpl.java to support DPDK trunk interfaces

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4048:
URL: https://github.com/apache/cloudstack/pull/4048#issuecomment-640330142


   Packaging result: ✖centos7 ✖debian. JID-1301


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4048: Update DpdkDriverImpl.java to support DPDK trunk interfaces

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4048:
URL: https://github.com/apache/cloudstack/pull/4048#issuecomment-621320250


   @nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] nvazquez commented on a change in pull request #4048: Update DpdkDriverImpl.java to support DPDK trunk interfaces

Posted by GitBox <gi...@apache.org>.
nvazquez commented on a change in pull request #4048:
URL: https://github.com/apache/cloudstack/pull/4048#discussion_r417462425



##########
File path: plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/dpdk/DpdkDriverImpl.java
##########
@@ -70,10 +70,12 @@ public void addDpdkPort(String bridgeName, String port, String vlan, DpdkHelper.
                 dpdkPortVhostUserClientType;
 
         StringBuilder stringBuilder = new StringBuilder();
-        stringBuilder.append(String.format("ovs-vsctl add-port %s %s " +
-                "vlan_mode=access tag=%s " +
-                "-- set Interface %s type=%s", bridgeName, port, vlan, port, type));
-
+        stringBuilder.append(String.format("ovs-vsctl add-port %s %s ", bridgeName, port));
+        if (Integer.parseInt(vlan) > 0 && Integer.parseInt(vlan) < 4095) {
+            stringBuilder.append(String.format("vlan_mode=access tag=%s ", vlan));
+        }
+        stringBuilder.append(String.format("-- set Interface %s type=%s", port, type));
+        

Review comment:
       Packages failing with: 
   ````
   [ERROR] /jenkins/workspace/acs-pr-centos7-pkg-builder/dist/rpmbuild/BUILD/cloudstack-4.14.0.0-SNAPSHOT/plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/dpdk/DpdkDriverImpl.java:78: Line has trailing spaces. [RegexpSingleline]
   ````
   
   @mbrashearnttglobalnet can you refactor this line space as a linux carriage?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] mbrashearnttglobalnet closed pull request #4048: Update DpdkDriverImpl.java to support DPDK trunk interfaces

Posted by GitBox <gi...@apache.org>.
mbrashearnttglobalnet closed pull request #4048:
URL: https://github.com/apache/cloudstack/pull/4048


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org