You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@avro.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/02/13 19:10:00 UTC
[jira] [Commented] (AVRO-1940) avrogencpp, scoped enums or c++11
enum class
[ https://issues.apache.org/jira/browse/AVRO-1940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16362893#comment-16362893 ]
ASF GitHub Bot commented on AVRO-1940:
--------------------------------------
leppardb commented on issue #146: AVRO-1940: C++: scope enums into own namespaces
URL: https://github.com/apache/avro/pull/146#issuecomment-365371103
Looked at your code. It successfully addresses issue AVRO-1936. However I think you might have misunderstood the request in AVRO-1940. The requester wanted support for c++11 scoped enum feature. i.e. enums declared as "enum class".
I have a local changeset that does enum class and will post it for review as soon as I figure out how. I think you can say your patch addresses 1936 but you should not mark 1940 resolved.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
> avrogencpp, scoped enums or c++11 enum class
> --------------------------------------------
>
> Key: AVRO-1940
> URL: https://issues.apache.org/jira/browse/AVRO-1940
> Project: Avro
> Issue Type: Improvement
> Components: c++
> Reporter: Alexander Moriarty
> Assignee: Alexander Moriarty
> Priority: Major
>
> It would be nice if avrogencpp could generated scoped enums.
> Either with C++11 enum class or just adding an additional namespace.
> This sort of relates to the issue I opened a few days ago: #AVRO-1936 in that one way this has been gotten around in the existing AvrogencppTests.cc is by generating one namespace per schema.
> This of course could be a breaking change depending how it is implemented.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)