You are viewing a plain text version of this content. The canonical link for it is here.
Posted to derby-dev@db.apache.org by "Kristian Waagan (JIRA)" <de...@db.apache.org> on 2006/04/26 10:29:03 UTC
[jira] Commented: (DERBY-1235) Move isPoolable() and setPoolable()
from PreparedStatement to Statement
[ http://issues.apache.org/jira/browse/DERBY-1235?page=comments#action_12376427 ]
Kristian Waagan commented on DERBY-1235:
----------------------------------------
Hi Dyre. Thanks for the patch. I had a look at it, and have the following comments:
1) The JavaDoc states isPoolable should be false by default for Statement, and true for PreparedStatement and CallableStatement. In the patch, the default for Statement is set to true. I don't know if the other criterias are met.
2) The JavaDoc/comments for Statement still use "PreparedStatement".
3) Tests should be added for Statement (jdbc4/StatementTest.java), and we might want to keep/add tests for PreparedStatement and CallableStatement as well. The tests can be added after the client side patch is ready. There should be a test for default value.
> Move isPoolable() and setPoolable() from PreparedStatement to Statement
> -----------------------------------------------------------------------
>
> Key: DERBY-1235
> URL: http://issues.apache.org/jira/browse/DERBY-1235
> Project: Derby
> Type: Improvement
> Components: JDBC
> Versions: 10.2.0.0
> Reporter: Rick Hillegas
> Assignee: Dyre Tjeldvoll
> Fix For: 10.2.0.0
> Attachments: derby-1235.v1.diff, derby-1235.v1.stat, derbyall_report.v1.txt
>
> An upcoming release of jdk1.6 will move isPoolable() and setPoolable() from PreparedStatement to Statement. We should conform.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira