You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@asterixdb.apache.org by "Michael Blow (Code Review)" <de...@asterixdb.apache.org> on 2019/04/12 13:44:52 UTC

Change in asterixdb[stabilization-f69489]: [NO ISSUE][HYR] Use System.nanotime for StopWatch

Michael Blow has uploaded this change for review. ( https://asterix-gerrit.ics.uci.edu/3339


Change subject: [NO ISSUE][HYR] Use System.nanotime for StopWatch
......................................................................

[NO ISSUE][HYR] Use System.nanotime for StopWatch

Change-Id: Ic64f1b938c26161f5fb482af5ee1da6121f49643
---
M hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/util/StopWatch.java
1 file changed, 7 insertions(+), 12 deletions(-)



  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/39/3339/1

diff --git a/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/util/StopWatch.java b/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/util/StopWatch.java
index e752cb3..a1a39cb 100644
--- a/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/util/StopWatch.java
+++ b/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/util/StopWatch.java
@@ -19,32 +19,27 @@
 
 package org.apache.hyracks.api.util;
 
+import java.util.concurrent.TimeUnit;
+
 public class StopWatch {
     private long startTime = 0;
-    private long stopTime = 0;
     private long elapsedTime = 0;
 
     public void start() {
         elapsedTime = 0;
-        startTime = System.currentTimeMillis();
+        startTime = System.nanoTime();
     }
 
     public void stop() {
-        stopTime = System.currentTimeMillis();
-        elapsedTime += stopTime - startTime;
+        elapsedTime += System.nanoTime() - startTime;
     }
 
     public void resume() {
-        startTime = System.currentTimeMillis();
+        startTime = System.nanoTime();
     }
 
-    //elaspsed time in milliseconds
-    public long getElapsedTime() {
-        return elapsedTime;
+    public long elapsed(TimeUnit unit) {
+        return unit.convert(elapsedTime, TimeUnit.NANOSECONDS);
     }
 
-    //elaspsed time in seconds
-    public long getElapsedTimeSecs() {
-        return elapsedTime / 1000;
-    }
 }
\ No newline at end of file

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3339
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: stabilization-f69489
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic64f1b938c26161f5fb482af5ee1da6121f49643
Gerrit-Change-Number: 3339
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Blow <mb...@apache.org>

Change in asterixdb[stabilization-f69489]: [NO ISSUE][HYR] Use System.nanotime for StopWatch

Posted by "Jenkins (Code Review)" <de...@asterixdb.apache.org>.
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3339 )

Change subject: [NO ISSUE][HYR] Use System.nanotime for StopWatch
......................................................................


Patch Set 1:

Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/5491/ (2/13)


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3339
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: stabilization-f69489
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic64f1b938c26161f5fb482af5ee1da6121f49643
Gerrit-Change-Number: 3339
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Blow <mb...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Comment-Date: Fri, 12 Apr 2019 13:45:00 +0000
Gerrit-HasComments: No

Change in asterixdb[stabilization-f69489]: [NO ISSUE][HYR] Use System.nanotime for StopWatch

Posted by "Jenkins (Code Review)" <de...@asterixdb.apache.org>.
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3339 )

Change subject: [NO ISSUE][HYR] Use System.nanotime for StopWatch
......................................................................


Patch Set 1:

Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-openjdk11/949/ (7/13)


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3339
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: stabilization-f69489
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic64f1b938c26161f5fb482af5ee1da6121f49643
Gerrit-Change-Number: 3339
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Blow <mb...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Comment-Date: Fri, 12 Apr 2019 13:45:01 +0000
Gerrit-HasComments: No

Change in asterixdb[stabilization-f69489]: [NO ISSUE][HYR] Use System.nanotime for StopWatch

Posted by "Jenkins (Code Review)" <de...@asterixdb.apache.org>.
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3339 )

Change subject: [NO ISSUE][HYR] Use System.nanotime for StopWatch
......................................................................


Patch Set 1:

Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/5555/ (6/13)


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3339
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: stabilization-f69489
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic64f1b938c26161f5fb482af5ee1da6121f49643
Gerrit-Change-Number: 3339
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Blow <mb...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Comment-Date: Fri, 12 Apr 2019 13:45:01 +0000
Gerrit-HasComments: No

Change in asterixdb[stabilization-f69489]: [NO ISSUE][HYR] Use System.nanotime for StopWatch

Posted by "Anon. E. Moose (Code Review)" <de...@asterixdb.apache.org>.
Anon. E. Moose (1000171) has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3339 )

Change subject: [NO ISSUE][HYR] Use System.nanotime for StopWatch
......................................................................


Patch Set 1:

Analytics Compatibility Compilation Successful
https://cbjenkins.page.link/8sLFqx3XX8tAF2tk9 : SUCCESS


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3339
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: stabilization-f69489
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic64f1b938c26161f5fb482af5ee1da6121f49643
Gerrit-Change-Number: 3339
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Blow <mb...@apache.org>
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Comment-Date: Fri, 12 Apr 2019 13:50:33 +0000
Gerrit-HasComments: No

Change in asterixdb[stabilization-f69489]: [NO ISSUE][HYR] Use System.nanotime for StopWatch

Posted by "Jenkins (Code Review)" <de...@asterixdb.apache.org>.
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3339 )

Change subject: [NO ISSUE][HYR] Use System.nanotime for StopWatch
......................................................................


Patch Set 1:

Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-txnlog/758/ (1/13)


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3339
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: stabilization-f69489
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic64f1b938c26161f5fb482af5ee1da6121f49643
Gerrit-Change-Number: 3339
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Blow <mb...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Comment-Date: Fri, 12 Apr 2019 13:45:00 +0000
Gerrit-HasComments: No

Change in asterixdb[stabilization-f69489]: [NO ISSUE][HYR] Use System.nanotime for StopWatch

Posted by "Jenkins (Code Review)" <de...@asterixdb.apache.org>.
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3339 )

Change subject: [NO ISSUE][HYR] Use System.nanotime for StopWatch
......................................................................


Patch Set 1:

Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/5801/ (11/13)


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3339
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: stabilization-f69489
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic64f1b938c26161f5fb482af5ee1da6121f49643
Gerrit-Change-Number: 3339
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Blow <mb...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Comment-Date: Fri, 12 Apr 2019 13:45:02 +0000
Gerrit-HasComments: No

Change in asterixdb[stabilization-f69489]: [NO ISSUE][HYR] Use System.nanotime for StopWatch

Posted by "Jenkins (Code Review)" <de...@asterixdb.apache.org>.
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3339 )

Change subject: [NO ISSUE][HYR] Use System.nanotime for StopWatch
......................................................................


Patch Set 1:

Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/5952/ (10/13)


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3339
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: stabilization-f69489
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic64f1b938c26161f5fb482af5ee1da6121f49643
Gerrit-Change-Number: 3339
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Blow <mb...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Comment-Date: Fri, 12 Apr 2019 13:45:01 +0000
Gerrit-HasComments: No

Change in asterixdb[stabilization-f69489]: [NO ISSUE][HYR] Use System.nanotime for StopWatch

Posted by "Jenkins (Code Review)" <de...@asterixdb.apache.org>.
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3339 )

Change subject: [NO ISSUE][HYR] Use System.nanotime for StopWatch
......................................................................


Patch Set 1:

Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/3591/ (8/13)


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3339
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: stabilization-f69489
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic64f1b938c26161f5fb482af5ee1da6121f49643
Gerrit-Change-Number: 3339
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Blow <mb...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Comment-Date: Fri, 12 Apr 2019 13:45:01 +0000
Gerrit-HasComments: No

Change in asterixdb[stabilization-f69489]: [NO ISSUE][HYR] Use System.nanotime for StopWatch

Posted by "Jenkins (Code Review)" <de...@asterixdb.apache.org>.
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3339 )

Change subject: [NO ISSUE][HYR] Use System.nanotime for StopWatch
......................................................................


Patch Set 1:

Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/5579/ (4/13)


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3339
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: stabilization-f69489
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic64f1b938c26161f5fb482af5ee1da6121f49643
Gerrit-Change-Number: 3339
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Blow <mb...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Comment-Date: Fri, 12 Apr 2019 13:45:01 +0000
Gerrit-HasComments: No

Change in asterixdb[stabilization-f69489]: [NO ISSUE][HYR] Use System.nanotime for StopWatch

Posted by "Ian Maxon (Code Review)" <de...@asterixdb.apache.org>.
Ian Maxon has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3339 )

Change subject: [NO ISSUE][HYR] Use System.nanotime for StopWatch
......................................................................


Patch Set 1: Code-Review+2


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3339
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: stabilization-f69489
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic64f1b938c26161f5fb482af5ee1da6121f49643
Gerrit-Change-Number: 3339
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Blow <mb...@apache.org>
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Ian Maxon <im...@uci.edu>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-Comment-Date: Fri, 12 Apr 2019 16:57:27 +0000
Gerrit-HasComments: No

Change in asterixdb[stabilization-f69489]: [NO ISSUE][HYR] Use System.nanotime for StopWatch

Posted by "Jenkins (Code Review)" <de...@asterixdb.apache.org>.
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3339 )

Change subject: [NO ISSUE][HYR] Use System.nanotime for StopWatch
......................................................................


Patch Set 1:

Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/8356/


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3339
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: stabilization-f69489
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic64f1b938c26161f5fb482af5ee1da6121f49643
Gerrit-Change-Number: 3339
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Blow <mb...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Comment-Date: Fri, 12 Apr 2019 13:47:52 +0000
Gerrit-HasComments: No

Change in asterixdb[stabilization-f69489]: [NO ISSUE][HYR] Use System.nanotime for StopWatch

Posted by "Jenkins (Code Review)" <de...@asterixdb.apache.org>.
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3339 )

Change subject: [NO ISSUE][HYR] Use System.nanotime for StopWatch
......................................................................


Patch Set 1:

Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app-stabilization-f69489/97/ (9/13)


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3339
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: stabilization-f69489
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic64f1b938c26161f5fb482af5ee1da6121f49643
Gerrit-Change-Number: 3339
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Blow <mb...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Comment-Date: Fri, 12 Apr 2019 13:45:01 +0000
Gerrit-HasComments: No

Change in asterixdb[stabilization-f69489]: [NO ISSUE][HYR] Use System.nanotime for StopWatch

Posted by "Jenkins (Code Review)" <de...@asterixdb.apache.org>.
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3339 )

Change subject: [NO ISSUE][HYR] Use System.nanotime for StopWatch
......................................................................


Patch Set 1:

Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/11066/ (12/13)


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3339
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: stabilization-f69489
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic64f1b938c26161f5fb482af5ee1da6121f49643
Gerrit-Change-Number: 3339
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Blow <mb...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Comment-Date: Fri, 12 Apr 2019 13:45:02 +0000
Gerrit-HasComments: No

Change in asterixdb[stabilization-f69489]: [NO ISSUE][HYR] Use System.nanotime for StopWatch

Posted by "Jenkins (Code Review)" <de...@asterixdb.apache.org>.
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3339 )

Change subject: [NO ISSUE][HYR] Use System.nanotime for StopWatch
......................................................................


Patch Set 1:

Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/5587/ (3/13)


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3339
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: stabilization-f69489
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic64f1b938c26161f5fb482af5ee1da6121f49643
Gerrit-Change-Number: 3339
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Blow <mb...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Comment-Date: Fri, 12 Apr 2019 13:45:01 +0000
Gerrit-HasComments: No

Change in asterixdb[stabilization-f69489]: [NO ISSUE][HYR] Use System.nanotime for StopWatch

Posted by "Jenkins (Code Review)" <de...@asterixdb.apache.org>.
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3339 )

Change subject: [NO ISSUE][HYR] Use System.nanotime for StopWatch
......................................................................


Patch Set 1:

Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/9537/ (5/13)


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3339
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: stabilization-f69489
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic64f1b938c26161f5fb482af5ee1da6121f49643
Gerrit-Change-Number: 3339
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Blow <mb...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Comment-Date: Fri, 12 Apr 2019 13:45:01 +0000
Gerrit-HasComments: No

Change in asterixdb[stabilization-f69489]: [NO ISSUE][HYR] Use System.nanotime for StopWatch

Posted by "Jenkins (Code Review)" <de...@asterixdb.apache.org>.
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3339 )

Change subject: [NO ISSUE][HYR] Use System.nanotime for StopWatch
......................................................................


Patch Set 1:

Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/6162/ (13/13)


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3339
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: stabilization-f69489
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic64f1b938c26161f5fb482af5ee1da6121f49643
Gerrit-Change-Number: 3339
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Blow <mb...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Comment-Date: Fri, 12 Apr 2019 13:45:02 +0000
Gerrit-HasComments: No

Change in asterixdb[stabilization-f69489]: [NO ISSUE][HYR] Use System.nanotime for StopWatch

Posted by "Michael Blow (Code Review)" <de...@asterixdb.apache.org>.
Michael Blow has submitted this change and it was merged. ( https://asterix-gerrit.ics.uci.edu/3339 )

Change subject: [NO ISSUE][HYR] Use System.nanotime for StopWatch
......................................................................

[NO ISSUE][HYR] Use System.nanotime for StopWatch

Change-Id: Ic64f1b938c26161f5fb482af5ee1da6121f49643
Reviewed-on: https://asterix-gerrit.ics.uci.edu/3339
Sonar-Qube: Jenkins <je...@fulliautomatix.ics.uci.edu>
Tested-by: Jenkins <je...@fulliautomatix.ics.uci.edu>
Integration-Tests: Jenkins <je...@fulliautomatix.ics.uci.edu>
Reviewed-by: Ian Maxon <im...@uci.edu>
---
M hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/util/StopWatch.java
1 file changed, 7 insertions(+), 12 deletions(-)

Approvals:
  Jenkins: Verified; No violations found; Verified
  Ian Maxon: Looks good to me, approved

Objections:
  Anon. E. Moose (1000171): Violations found



diff --git a/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/util/StopWatch.java b/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/util/StopWatch.java
index e752cb3..a1a39cb 100644
--- a/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/util/StopWatch.java
+++ b/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/util/StopWatch.java
@@ -19,32 +19,27 @@
 
 package org.apache.hyracks.api.util;
 
+import java.util.concurrent.TimeUnit;
+
 public class StopWatch {
     private long startTime = 0;
-    private long stopTime = 0;
     private long elapsedTime = 0;
 
     public void start() {
         elapsedTime = 0;
-        startTime = System.currentTimeMillis();
+        startTime = System.nanoTime();
     }
 
     public void stop() {
-        stopTime = System.currentTimeMillis();
-        elapsedTime += stopTime - startTime;
+        elapsedTime += System.nanoTime() - startTime;
     }
 
     public void resume() {
-        startTime = System.currentTimeMillis();
+        startTime = System.nanoTime();
     }
 
-    //elaspsed time in milliseconds
-    public long getElapsedTime() {
-        return elapsedTime;
+    public long elapsed(TimeUnit unit) {
+        return unit.convert(elapsedTime, TimeUnit.NANOSECONDS);
     }
 
-    //elaspsed time in seconds
-    public long getElapsedTimeSecs() {
-        return elapsedTime / 1000;
-    }
 }
\ No newline at end of file

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3339
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: stabilization-f69489
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic64f1b938c26161f5fb482af5ee1da6121f49643
Gerrit-Change-Number: 3339
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Blow <mb...@apache.org>
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Ian Maxon <im...@uci.edu>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Michael Blow <mb...@apache.org>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>

Change in asterixdb[stabilization-f69489]: [NO ISSUE][HYR] Use System.nanotime for StopWatch

Posted by "Jenkins (Code Review)" <de...@asterixdb.apache.org>.
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3339 )

Change subject: [NO ISSUE][HYR] Use System.nanotime for StopWatch
......................................................................


Patch Set 1: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/8356/ : SUCCESS


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3339
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: stabilization-f69489
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic64f1b938c26161f5fb482af5ee1da6121f49643
Gerrit-Change-Number: 3339
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Blow <mb...@apache.org>
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Comment-Date: Fri, 12 Apr 2019 15:13:07 +0000
Gerrit-HasComments: No

Change in asterixdb[stabilization-f69489]: [NO ISSUE][HYR] Use System.nanotime for StopWatch

Posted by "Anon. E. Moose (Code Review)" <de...@asterixdb.apache.org>.
Anon. E. Moose (1000171) has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3339 )

Change subject: [NO ISSUE][HYR] Use System.nanotime for StopWatch
......................................................................


Patch Set 1: Contrib-2

Analytics Compatibility Tests Failed
https://cbjenkins.page.link/rix3bPb8DRLvsc6u7 : UNSTABLE


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3339
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: stabilization-f69489
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic64f1b938c26161f5fb482af5ee1da6121f49643
Gerrit-Change-Number: 3339
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Blow <mb...@apache.org>
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Comment-Date: Fri, 12 Apr 2019 15:07:43 +0000
Gerrit-HasComments: No