You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Jan Loose (JIRA)" <ji...@apache.org> on 2008/10/29 18:28:44 UTC
[jira] Created: (WICKET-1904) CheckBox incorrectly converts its
model value when a custom Boolean converter is installed - again
CheckBox incorrectly converts its model value when a custom Boolean converter is installed - again
--------------------------------------------------------------------------------------------------
Key: WICKET-1904
URL: https://issues.apache.org/jira/browse/WICKET-1904
Project: Wicket
Issue Type: Bug
Components: wicket
Affects Versions: 1.4-M4
Reporter: Jan Loose
Hi,
I tried the last version of wicket (built from trunk svn) and there is one old bug again:
see https://issues.apache.org/jira/browse/WICKET-330
There was removed the default Boolean converter ... and the bug is again active.
Thx for fixing,
H.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-1904) CheckBox incorrectly converts its
model value when a custom Boolean converter is installed - again
Posted by "Jan Loose (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1904?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12643601#action_12643601 ]
Jan Loose commented on WICKET-1904:
-----------------------------------
your code looks good, but the code is not in trunk version ... may be the code is in 1.3 brach ...
> CheckBox incorrectly converts its model value when a custom Boolean converter is installed - again
> --------------------------------------------------------------------------------------------------
>
> Key: WICKET-1904
> URL: https://issues.apache.org/jira/browse/WICKET-1904
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.4-M4
> Reporter: Jan Loose
> Assignee: Igor Vaynberg
> Fix For: 1.3.6, 1.4-M4
>
>
> Hi,
> I tried the last version of wicket (built from trunk svn) and there is one old bug again:
> see https://issues.apache.org/jira/browse/WICKET-330
> There was removed the default Boolean converter ... and the bug is again active.
> Thx for fixing,
> H.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (WICKET-1904) CheckBox incorrectly converts its
model value when a custom Boolean converter is installed - again
Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1904?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Igor Vaynberg reassigned WICKET-1904:
-------------------------------------
Assignee: Igor Vaynberg
> CheckBox incorrectly converts its model value when a custom Boolean converter is installed - again
> --------------------------------------------------------------------------------------------------
>
> Key: WICKET-1904
> URL: https://issues.apache.org/jira/browse/WICKET-1904
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.4-M4
> Reporter: Jan Loose
> Assignee: Igor Vaynberg
>
> Hi,
> I tried the last version of wicket (built from trunk svn) and there is one old bug again:
> see https://issues.apache.org/jira/browse/WICKET-330
> There was removed the default Boolean converter ... and the bug is again active.
> Thx for fixing,
> H.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-1904) CheckBox incorrectly converts its
model value when a custom Boolean converter is installed - again
Posted by "Jan Loose (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1904?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12643636#action_12643636 ]
Jan Loose commented on WICKET-1904:
-----------------------------------
Thx,
H.
> CheckBox incorrectly converts its model value when a custom Boolean converter is installed - again
> --------------------------------------------------------------------------------------------------
>
> Key: WICKET-1904
> URL: https://issues.apache.org/jira/browse/WICKET-1904
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.4-M4
> Reporter: Jan Loose
> Assignee: Igor Vaynberg
> Fix For: 1.3.6, 1.4-M4
>
>
> Hi,
> I tried the last version of wicket (built from trunk svn) and there is one old bug again:
> see https://issues.apache.org/jira/browse/WICKET-330
> There was removed the default Boolean converter ... and the bug is again active.
> Thx for fixing,
> H.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-1904) CheckBox incorrectly converts its
model value when a custom Boolean converter is installed - again
Posted by "Jan Loose (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1904?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12643538#action_12643538 ]
Jan Loose commented on WICKET-1904:
-----------------------------------
This code was removed ... and is necessary.
/**
* CheckBox will by default always just use the boolean converter because the implementation
* expects that the string is can be converted to a boolean {@link Strings#isTrue(String)}
*
* @see org.apache.wicket.Component#getConverter(java.lang.Class)
*/
@Override
public <X> IConverter<X> getConverter(Class<X> type)
{
/*
* FIXME johan: why is this override here? it doesnt make any sense. if i say
* checkbox.getconverter(Integer.class) why is it still giving me a boolean converter???
*/
return (IConverter<X>)BooleanConverter.INSTANCE;
}
> CheckBox incorrectly converts its model value when a custom Boolean converter is installed - again
> --------------------------------------------------------------------------------------------------
>
> Key: WICKET-1904
> URL: https://issues.apache.org/jira/browse/WICKET-1904
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.4-M4
> Reporter: Jan Loose
>
> Hi,
> I tried the last version of wicket (built from trunk svn) and there is one old bug again:
> see https://issues.apache.org/jira/browse/WICKET-330
> There was removed the default Boolean converter ... and the bug is again active.
> Thx for fixing,
> H.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-1904) CheckBox incorrectly converts its
model value when a custom Boolean converter is installed - again
Posted by "Jan Loose (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1904?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12643596#action_12643596 ]
Jan Loose commented on WICKET-1904:
-----------------------------------
Hi,
there is one more small bug ... the new converter CheckBoxConverter is never used ...
There should be:
return CheckBoxConverter.INSTANCE;
instead of:
return super.getConverter(type);
Thx,
H.
> CheckBox incorrectly converts its model value when a custom Boolean converter is installed - again
> --------------------------------------------------------------------------------------------------
>
> Key: WICKET-1904
> URL: https://issues.apache.org/jira/browse/WICKET-1904
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.4-M4
> Reporter: Jan Loose
> Assignee: Igor Vaynberg
> Fix For: 1.3.6, 1.4-M4
>
>
> Hi,
> I tried the last version of wicket (built from trunk svn) and there is one old bug again:
> see https://issues.apache.org/jira/browse/WICKET-330
> There was removed the default Boolean converter ... and the bug is again active.
> Thx for fixing,
> H.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-1904) CheckBox incorrectly converts its
model value when a custom Boolean converter is installed - again
Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1904?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12643599#action_12643599 ]
Igor Vaynberg commented on WICKET-1904:
---------------------------------------
my code here reads:
@Override
public final IConverter getConverter(Class<?> type)
{
if (Boolean.class.equals(type))
{
return CheckBoxConverter.INSTANCE;
}
else
{
return super.getConverter(type);
}
}
so it should use the checkboxconverter for boolean values...
> CheckBox incorrectly converts its model value when a custom Boolean converter is installed - again
> --------------------------------------------------------------------------------------------------
>
> Key: WICKET-1904
> URL: https://issues.apache.org/jira/browse/WICKET-1904
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.4-M4
> Reporter: Jan Loose
> Assignee: Igor Vaynberg
> Fix For: 1.3.6, 1.4-M4
>
>
> Hi,
> I tried the last version of wicket (built from trunk svn) and there is one old bug again:
> see https://issues.apache.org/jira/browse/WICKET-330
> There was removed the default Boolean converter ... and the bug is again active.
> Thx for fixing,
> H.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (WICKET-1904) CheckBox incorrectly converts its
model value when a custom Boolean converter is installed - again
Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1904?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Igor Vaynberg resolved WICKET-1904.
-----------------------------------
Resolution: Fixed
Fix Version/s: 1.4-M4
1.3.6
checkbox now has its own hardcoded converter that is made to work with html's "on" value
> CheckBox incorrectly converts its model value when a custom Boolean converter is installed - again
> --------------------------------------------------------------------------------------------------
>
> Key: WICKET-1904
> URL: https://issues.apache.org/jira/browse/WICKET-1904
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.4-M4
> Reporter: Jan Loose
> Assignee: Igor Vaynberg
> Fix For: 1.3.6, 1.4-M4
>
>
> Hi,
> I tried the last version of wicket (built from trunk svn) and there is one old bug again:
> see https://issues.apache.org/jira/browse/WICKET-330
> There was removed the default Boolean converter ... and the bug is again active.
> Thx for fixing,
> H.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-1904) CheckBox incorrectly converts its
model value when a custom Boolean converter is installed - again
Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1904?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12643631#action_12643631 ]
Igor Vaynberg commented on WICKET-1904:
---------------------------------------
strange, try updating again
> CheckBox incorrectly converts its model value when a custom Boolean converter is installed - again
> --------------------------------------------------------------------------------------------------
>
> Key: WICKET-1904
> URL: https://issues.apache.org/jira/browse/WICKET-1904
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.4-M4
> Reporter: Jan Loose
> Assignee: Igor Vaynberg
> Fix For: 1.3.6, 1.4-M4
>
>
> Hi,
> I tried the last version of wicket (built from trunk svn) and there is one old bug again:
> see https://issues.apache.org/jira/browse/WICKET-330
> There was removed the default Boolean converter ... and the bug is again active.
> Thx for fixing,
> H.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.