Re: Review Request 32891: Support for entering and configuring a Linux chroot.

[Ian Downes <ia...@gmail.com>]

> On April 13, 2015, 2:30 p.m., Jie Yu wrote:
> > src/linux/fs.cpp, line 432
> > <https://reviews.apache.org/r/32891/diff/1/?file=916658#file916658line432>
> >
> >     Copy comments from the other review, can you support `Option<string> options` for fs::mount as well?

Decided to add as an alternate mount() version (wrapper) to preserve the original functionality where data is generally void*.


- Ian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32891/#review79947
-----------------------------------------------------------


On April 6, 2015, 11 a.m., Ian Downes wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32891/
> -----------------------------------------------------------
> 
> (Updated April 6, 2015, 11 a.m.)
> 
> 
> Review request for mesos, Chi Zhang, Jay Buffington, Jie Yu, and James Peach.
> 
> 
> Bugs: MESOS-2350
>     https://issues.apache.org/jira/browse/MESOS-2350
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Support for entering and configuring a Linux chroot.
> 
> 
> Diffs
> -----
> 
>   src/linux/fs.hpp d7832a4b3761c48be6c1ccef58a30ee31c70dc1b 
>   src/linux/fs.cpp 1c9cf3f2ffead37148e4f6a81cefdbb97f679b09 
> 
> Diff: https://reviews.apache.org/r/32891/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ian Downes
> 
>