You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@httpd.apache.org by Stefan Fritsch <sf...@sfritsch.de> on 2011/06/05 23:44:25 UTC
Re: Per request DocumentRoot
On Tuesday 17 May 2011, Ondřej Surý wrote:
> this is the semi-annual ping to check whether I can find enough
> support to get per request r->document_root implemented in 2.3.x.
Something like that is now implemented in trunk in
http://svn.apache.org/viewvc?view=revision&revision=1132494
Comments welcome.
Cheers,
Stefan
Re: Per request DocumentRoot
Posted by Graham Leggett <mi...@sharp.fm>.
On 06 Jun 2011, at 10:59 PM, Stefan Fritsch wrote:
> These should not be changed for now. The core only translates relative
> to the "real" document root. Everything else is done by modules.
>
> If we ever allow to set the DocumentRoot inside <Location> blocks,
> this may need to be re-evaluated.
That might be nice to have, you could avoid having to Alias everything.
Regards,
Graham
--
Re: Per request DocumentRoot
Posted by Stefan Fritsch <sf...@sfritsch.de>.
On Monday 06 June 2011, Ondřej Surý wrote:
> Looks good to me, although I think you might have missed few lines
> where conf->ap_document_root is referenced directly in
> core.c:ap_core_translate(request_rec *r):
> But I don't understand the apache internals so well to tell whether
> it's not a false positive.
These should not be changed for now. The core only translates relative
to the "real" document root. Everything else is done by modules.
If we ever allow to set the DocumentRoot inside <Location> blocks,
this may need to be re-evaluated.
Re: Per request DocumentRoot
Posted by Ondřej Surý <on...@sury.org>.
On Sun, Jun 5, 2011 at 23:44, Stefan Fritsch <sf...@sfritsch.de> wrote:
> On Tuesday 17 May 2011, Ondřej Surý wrote:
>> this is the semi-annual ping to check whether I can find enough
>> support to get per request r->document_root implemented in 2.3.x.
>
> Something like that is now implemented in trunk in
>
> http://svn.apache.org/viewvc?view=revision&revision=1132494
>
> Comments welcome.
Looks good to me, although I think you might have missed few lines
where conf->ap_document_root is referenced directly in
core.c:ap_core_translate(request_rec *r):
https://issues.apache.org/bugzilla/attachment.cgi?id=25843&action=diff#server/core.c_sec2
https://issues.apache.org/bugzilla/attachment.cgi?id=25843&action=diff#server/core.c_sec3
But I don't understand the apache internals so well to tell whether
it's not a false positive.
O.
--
Ondřej Surý <on...@sury.org>