You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/12/12 03:55:37 UTC
[GitHub] [doris] github-actions[bot] commented on pull request #15002: [Chore](s2geo) upgrade s2geo to 0.10.0
github-actions[bot] commented on PR #15002:
URL: https://github.com/apache/doris/pull/15002#issuecomment-1345831518
#### `sh-checker report`
To get the full details, please check in the [job]("https://github.com/apache/doris/actions/runs/3672497908") output.
<details>
<summary>shellcheck errors</summary>
```
'shellcheck ' returned error 1 finding the following syntactical issues:
----------
In thirdparty/build-thirdparty.sh line 974:
check_if_source_exist $ABSEIL_SOURCE
^------------^ SC2248 (style): Prefer double quoting even when variables don't contain special characters.
^------------^ SC2250 (style): Prefer putting braces around variable references even when not strictly required.
Did you mean:
check_if_source_exist "$ABSEIL_SOURCE"
In thirdparty/build-thirdparty.sh line 975:
cd $TP_SOURCE_DIR/$ABSEIL_SOURCE
^------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
^------------^ SC2250 (style): Prefer putting braces around variable references even when not strictly required.
^------------^ SC2248 (style): Prefer double quoting even when variables don't contain special characters.
^------------^ SC2250 (style): Prefer putting braces around variable references even when not strictly required.
Did you mean:
cd "$TP_SOURCE_DIR"/$ABSEIL_SOURCE
In thirdparty/build-thirdparty.sh line 979:
${CMAKE_CMD} -B $BUILD_DIR -DCMAKE_INSTALL_PREFIX=${TP_INSTALL_DIR} \
^--------^ SC2248 (style): Prefer double quoting even when variables don't contain special characters.
^--------^ SC2250 (style): Prefer putting braces around variable references even when not strictly required.
^---------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
${CMAKE_CMD} -B "$BUILD_DIR" -DCMAKE_INSTALL_PREFIX=${TP_INSTALL_DIR} \
In thirdparty/build-thirdparty.sh line 985:
cmake --build $BUILD_DIR
^--------^ SC2248 (style): Prefer double quoting even when variables don't contain special characters.
^--------^ SC2250 (style): Prefer putting braces around variable references even when not strictly required.
Did you mean:
cmake --build "$BUILD_DIR"
In thirdparty/build-thirdparty.sh line 986:
cmake --install $BUILD_DIR --prefix $TP_INSTALL_DIR
^--------^ SC2248 (style): Prefer double quoting even when variables don't contain special characters.
^--------^ SC2250 (style): Prefer putting braces around variable references even when not strictly required.
^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
^-------------^ SC2250 (style): Prefer putting braces around variable references even when not strictly required.
Did you mean:
cmake --install "$BUILD_DIR" --prefix $TP_INSTALL_DIR
In thirdparty/build-thirdparty.sh line 1007:
${CMAKE_CMD} -G "${GENERATOR}" -DBUILD_SHARED_LIBS=OFF -DCMAKE_INSTALL_PREFIX=$TP_INSTALL_DIR \
^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
^-------------^ SC2250 (style): Prefer putting braces around variable references even when not strictly required.
Did you mean:
${CMAKE_CMD} -G "${GENERATOR}" -DBUILD_SHARED_LIBS=OFF -DCMAKE_INSTALL_PREFIX="$TP_INSTALL_DIR" \
In thirdparty/build-thirdparty.sh line 1008:
-DCMAKE_PREFIX_PATH=$TP_INSTALL_DIR \
^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
^-------------^ SC2250 (style): Prefer putting braces around variable references even when not strictly required.
Did you mean:
-DCMAKE_PREFIX_PATH="$TP_INSTALL_DIR" \
In thirdparty/build-thirdparty.sh line 1010:
-DCMAKE_LIBRARY_PATH=$TP_INSTALL_DIR ..
^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
^-------------^ SC2250 (style): Prefer putting braces around variable references even when not strictly required.
Did you mean:
-DCMAKE_LIBRARY_PATH="$TP_INSTALL_DIR" ..
For more information:
https://www.shellcheck.net/wiki/SC2086 -- Double quote to prevent globbing ...
https://www.shellcheck.net/wiki/SC2248 -- Prefer double quoting even when v...
https://www.shellcheck.net/wiki/SC2250 -- Prefer putting braces around vari...
----------
You can address the above issues in one of three ways:
1. Manually correct the issue in the offending shell script;
2. Disable specific issues by adding the comment:
# shellcheck disable=NNNN
above the line that contains the issue, where NNNN is the error code;
3. Add '-e NNNN' to the SHELLCHECK_OPTS setting in your .yml action file.
```
</details>
<details>
<summary>shfmt errors</summary>
```
'shfmt ' returned error 1 finding the following formatting issues:
----------
--- thirdparty/build-thirdparty.sh.orig
+++ thirdparty/build-thirdparty.sh
@@ -975,12 +975,12 @@
cd $TP_SOURCE_DIR/$ABSEIL_SOURCE
CXXFLAGS="-O3" \
- LDFLAGS="-L${TP_LIB_DIR} -static-libstdc++ -static-libgcc" \
- ${CMAKE_CMD} -B $BUILD_DIR -DCMAKE_INSTALL_PREFIX=${TP_INSTALL_DIR} \
- -DABSL_ENABLE_INSTALL=ON \
- -DBUILD_DEPS=ON \
- -DBUILD_SHARED_LIBS=OFF \
- -DCMAKE_CXX_STANDARD=11
+ LDFLAGS="-L${TP_LIB_DIR} -static-libstdc++ -static-libgcc" \
+ ${CMAKE_CMD} -B $BUILD_DIR -DCMAKE_INSTALL_PREFIX=${TP_INSTALL_DIR} \
+ -DABSL_ENABLE_INSTALL=ON \
+ -DBUILD_DEPS=ON \
+ -DBUILD_SHARED_LIBS=OFF \
+ -DCMAKE_CXX_STANDARD=11
cmake --build $BUILD_DIR
cmake --install $BUILD_DIR --prefix $TP_INSTALL_DIR
@@ -1003,11 +1003,11 @@
fi
CXXFLAGS="-O3" \
- LDFLAGS="-L${TP_LIB_DIR} -static-libstdc++ -static-libgcc" \
- ${CMAKE_CMD} -G "${GENERATOR}" -DBUILD_SHARED_LIBS=OFF -DCMAKE_INSTALL_PREFIX=$TP_INSTALL_DIR \
- -DCMAKE_PREFIX_PATH=$TP_INSTALL_DIR \
- -DBUILD_SHARED_LIBS=OFF \
- -DCMAKE_LIBRARY_PATH=$TP_INSTALL_DIR ..
+ LDFLAGS="-L${TP_LIB_DIR} -static-libstdc++ -static-libgcc" \
+ ${CMAKE_CMD} -G "${GENERATOR}" -DBUILD_SHARED_LIBS=OFF -DCMAKE_INSTALL_PREFIX=$TP_INSTALL_DIR \
+ -DCMAKE_PREFIX_PATH=$TP_INSTALL_DIR \
+ -DBUILD_SHARED_LIBS=OFF \
+ -DCMAKE_LIBRARY_PATH=$TP_INSTALL_DIR ..
"${BUILD_SYSTEM}" -j "${PARALLEL}"
"${BUILD_SYSTEM}" install
----------
You can reformat the above files to meet shfmt's requirements by typing:
shfmt -w filename
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org