You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "terrymanu (via GitHub)" <gi...@apache.org> on 2026/09/23 16:24:33 UTC

[PR] Rename duplicate cross-module tests as integration tests [shardingsphere]

terrymanu opened a new pull request, #39934:
URL: https://github.com/apache/shardingsphere/pull/39934

   (no comment)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Rename duplicate cross-module tests as integration tests [shardingsphere]

Posted by "terrymanu (via GitHub)" <gi...@apache.org>.
terrymanu merged PR #39934:
URL: https://github.com/apache/shardingsphere/pull/39934


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Rename duplicate cross-module tests as integration tests [shardingsphere]

Posted by "terrymanu (via GitHub)" <gi...@apache.org>.
terrymanu commented on PR #39934:
URL: https://github.com/apache/shardingsphere/pull/39934#issuecomment-5798550923

   ### Result
   
   **Review Result: Mergeable**
   
   The change follows the agreed test naming and module ownership rules. No blocking issue was found.
   
   ### Evidence
   
   - Each of the five files was compared with its original: test content is identical apart from the class declaration changing from `XTest` to `final class XIT`.
   - Failsafe ran all five renamed classes: 31 tests, with no failures, errors, or skips.
   - The final Spotless, Checkstyle, and Apache RAT checks passed.
   
   ### Coverage
   
   - This is a standalone local change based on `86c324080a2`. The review covered the five old test files and their five new `IT` files across PostgreSQL pipeline, XA transaction, and pipeline IT.
   - Production-class ownership, test discovery and execution, preservation of assertions, and change scope were checked. No review gaps remain.
   - The conclusion applies the confirmed “one `XTest` per production class” rule. Repository-wide CI was not run; the verification above was local. The pre-existing, unrelated `__pycache__` was left untouched.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org