Re: cvs commit: jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/util RequestUtil.java

["Craig R. McClanahan" <Cr...@eng.sun.com>]

Geoff Soutter wrote:

> "Craig R. McClanahan" <Cr...@eng.sun.com> wrote:
> > Geoff Soutter wrote:
> >
> > > Craig,
> > >
> > > FYI, this method is actually buggy, it doesn't follow the decoding rules
> for
> > > URLs set down in the RFCs. From memory, I think it it decodes +'s in
> URLs
> > > before the ?, which is a no-no.
> > >
> >
> > In this particular patch, I'm only applying it to the "name" and "value"
> that
> > has been parsed out already -- the entire request URI is no longer decoded
> as a
> > unit.  Thus, I don't think there's a problem with how it's being used
> here.  Are
> > there any case where this new code misbehaves?
>
> Ah, sorry, I was thinking you'd just cut and pasted the 3.3 version of this
> method/class. I had a look properly and it looks fine...
>

As our London hosts for ApacheCon Europe would say it, "not bloody likely"  :-)

Craig

====================
See you at ApacheCon Europe <http://www.apachecon.com>!
Session VS01 (23-Oct 13h00-17h00):  Sun Technical Briefing
Session T06  (24-Oct 14h00-15h00):  Migrating Apache JServ
                                    Applications to Tomcat