You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Jie Yu <yu...@gmail.com> on 2014/08/06 23:19:35 UTC
Review Request 24426: Changed socket closed while receiving to VLOG(2).
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24426/
-----------------------------------------------------------
Review request for mesos, Ben Mahler and Vinod Kone.
Repository: mesos-git
Description
-------
See summary. It's pretty spammy and not quite useful for debugging.
Diffs
-----
3rdparty/libprocess/src/process.cpp 6f6f3f9
Diff: https://reviews.apache.org/r/24426/diff/
Testing
-------
trivial
Thanks,
Jie Yu
Re: Review Request 24426: Changed socket closed while receiving to VLOG(2).
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24426/#review49811
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On Aug. 6, 2014, 9:19 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24426/
> -----------------------------------------------------------
>
> (Updated Aug. 6, 2014, 9:19 p.m.)
>
>
> Review request for mesos, Ben Mahler and Vinod Kone.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary. It's pretty spammy and not quite useful for debugging.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/process.cpp 6f6f3f9
>
> Diff: https://reviews.apache.org/r/24426/diff/
>
>
> Testing
> -------
>
> trivial
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 24426: Changed socket closed while receiving to VLOG(2).
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24426/#review49813
-----------------------------------------------------------
Ship it!
3rdparty/libprocess/src/process.cpp
<https://reviews.apache.org/r/24426/#comment87171>
Seems good for now, but these messages seem a bit misleading?
For example, for this one, it could be that the sender is done sending and we've decoded everything, right? This message sounds like an unexpected error.
- Ben Mahler
On Aug. 6, 2014, 9:19 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24426/
> -----------------------------------------------------------
>
> (Updated Aug. 6, 2014, 9:19 p.m.)
>
>
> Review request for mesos, Ben Mahler and Vinod Kone.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary. It's pretty spammy and not quite useful for debugging.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/process.cpp 6f6f3f9
>
> Diff: https://reviews.apache.org/r/24426/diff/
>
>
> Testing
> -------
>
> trivial
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 24426: Changed socket closed while receiving to VLOG(2).
Posted by Dominic Hamon <dh...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24426/#review49809
-----------------------------------------------------------
Ship it!
Ship It!
- Dominic Hamon
On Aug. 6, 2014, 2:19 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24426/
> -----------------------------------------------------------
>
> (Updated Aug. 6, 2014, 2:19 p.m.)
>
>
> Review request for mesos, Ben Mahler and Vinod Kone.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary. It's pretty spammy and not quite useful for debugging.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/process.cpp 6f6f3f9
>
> Diff: https://reviews.apache.org/r/24426/diff/
>
>
> Testing
> -------
>
> trivial
>
>
> Thanks,
>
> Jie Yu
>
>