You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by justin coffey <j....@criteo.com> on 2014/04/30 19:22:07 UTC
Review Request 20899: HIVE-6994 - parquet-hive createArray strips null
elements
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20899/
-----------------------------------------------------------
Review request for hive.
Repository: hive-git
Description
-------
- Fix for bug in createArray() that strips null elements.
- In the process refactored serde for simplification purposes.
- Refactored tests for better regression testing.
Diffs
-----
data/files/parquet_create.txt ccd48ee
ql/src/java/org/apache/hadoop/hive/ql/io/parquet/serde/ParquetHiveSerDe.java b689336
ql/src/test/org/apache/hadoop/hive/ql/io/parquet/TestParquetSerDe.java be518b9
ql/src/test/org/apache/hadoop/hive/ql/io/parquet/serde/TestParquetHiveSerDe.java PRE-CREATION
ql/src/test/queries/clientpositive/parquet_create.q 0b976bd
ql/src/test/results/clientpositive/parquet_create.q.out 3220be5
Diff: https://reviews.apache.org/r/20899/diff/
Testing
-------
Thanks,
justin coffey
Re: Review Request 20899: HIVE-6994 - parquet-hive createArray strips null
elements
Posted by Szehon Ho <sz...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20899/#review42416
-----------------------------------------------------------
Mostly looks good, some comments.
ql/src/java/org/apache/hadoop/hive/ql/io/parquet/serde/ParquetHiveSerDe.java
<https://reviews.apache.org/r/20899/#comment76184>
Is it necessary to remove final?
ql/src/java/org/apache/hadoop/hive/ql/io/parquet/serde/ParquetHiveSerDe.java
<https://reviews.apache.org/r/20899/#comment76183>
Is it necessary to remove final on these?
- Szehon Ho
On April 30, 2014, 5:22 p.m., justin coffey wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20899/
> -----------------------------------------------------------
>
> (Updated April 30, 2014, 5:22 p.m.)
>
>
> Review request for hive.
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> - Fix for bug in createArray() that strips null elements.
> - In the process refactored serde for simplification purposes.
> - Refactored tests for better regression testing.
>
>
> Diffs
> -----
>
> data/files/parquet_create.txt ccd48ee
> ql/src/java/org/apache/hadoop/hive/ql/io/parquet/serde/ParquetHiveSerDe.java b689336
> ql/src/test/org/apache/hadoop/hive/ql/io/parquet/TestParquetSerDe.java be518b9
> ql/src/test/org/apache/hadoop/hive/ql/io/parquet/serde/TestParquetHiveSerDe.java PRE-CREATION
> ql/src/test/queries/clientpositive/parquet_create.q 0b976bd
> ql/src/test/results/clientpositive/parquet_create.q.out 3220be5
>
> Diff: https://reviews.apache.org/r/20899/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> justin coffey
>
>
Re: Review Request 20899: HIVE-6994 - parquet-hive createArray strips null
elements
Posted by justin coffey <j....@criteo.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20899/
-----------------------------------------------------------
(Updated May 12, 2014, 2:18 p.m.)
Review request for hive.
Changes
-------
added back finals and cleaned up commentary.
Repository: hive-git
Description
-------
- Fix for bug in createArray() that strips null elements.
- In the process refactored serde for simplification purposes.
- Refactored tests for better regression testing.
Diffs (updated)
-----
data/files/parquet_create.txt ccd48ee
ql/src/java/org/apache/hadoop/hive/ql/io/parquet/serde/ParquetHiveSerDe.java b689336
ql/src/test/org/apache/hadoop/hive/ql/io/parquet/TestParquetSerDe.java 3b56fc7
ql/src/test/org/apache/hadoop/hive/ql/io/parquet/serde/TestParquetHiveSerDe.java PRE-CREATION
ql/src/test/queries/clientpositive/parquet_create.q 0b976bd
ql/src/test/results/clientpositive/parquet_create.q.out 3220be5
Diff: https://reviews.apache.org/r/20899/diff/
Testing
-------
Thanks,
justin coffey