You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@servicecomb.apache.org by GitBox <gi...@apache.org> on 2020/06/20 08:08:16 UTC
[GitHub] [servicecomb-service-center] hityc2019 opened a new pull request #650: fix misspelled words
hityc2019 opened a new pull request #650:
URL: https://github.com/apache/servicecomb-service-center/pull/650
Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line and body.
- [ ] Format the pull request title like `[SCB-XXX] Fixes bug in ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA issue.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Run `go build` `go test` `go fmt` `go vet` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
---
修正了readme中的方法名
SC中扩展模块机制的readme对于初学者上手帮助较大，但该readme文件放在govern目录下是否合适，很难找到且与govern关联性不强？放在docs目录下或者server目录下是否更好？
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-service-center] tianxiaoliang merged pull request #650: fix misspelled words
Posted by GitBox <gi...@apache.org>.
tianxiaoliang merged pull request #650:
URL: https://github.com/apache/servicecomb-service-center/pull/650
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-service-center] coveralls commented on pull request #650: fix misspelled words
Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #650:
URL: https://github.com/apache/servicecomb-service-center/pull/650#issuecomment-646962348
[](https://coveralls.io/builds/31575351)
Coverage decreased (-0.02%) to 61.17% when pulling **de8a882a92e2d56b919b7b8f630c8dad577137c5 on hityc2019:master** into **c85596b4f61b8b1d87c728bb0b38578f11d1cc12 on apache:master**.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-service-center] tianxiaoliang commented on pull request #650: fix misspelled words
Posted by GitBox <gi...@apache.org>.
tianxiaoliang commented on pull request #650:
URL: https://github.com/apache/servicecomb-service-center/pull/650#issuecomment-647095910
感谢贡献，我觉得有道理，放在docs下边比较合适，另外kie项目已经用sphinx开始管理文档了，如果你有兴趣，也可以整体向sphinx进行迁移
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org