You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2021/05/25 19:26:06 UTC
[kudu-CR](branch-1.15.x) KUDU-1884: set sasl protocol name for the TxnSystemClient
Hello Kudu Jenkins,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/17509
to review the following change.
Change subject: KUDU-1884: set sasl_protocol_name for the TxnSystemClient
......................................................................
KUDU-1884: set sasl_protocol_name for the TxnSystemClient
In clusters with a custom principal we need to set the
sasl_protocol_name on the embedded client within the TxnSystemClient.
This logic matches that in server_base.cc for server messenger
configuration.
Change-Id: Ic7b7c7fd154796215bd3a3ce748a2fd3155adebf
Reviewed-on: http://gerrit.cloudera.org:8080/17480
Tested-by: Kudu Jenkins
Reviewed-by: Alexey Serbin <as...@cloudera.com>
(cherry picked from commit 0569c7055cfd22be86a95fabb41e27afd570d784)
---
M src/kudu/integration-tests/auth_token_expire-itest.cc
M src/kudu/integration-tests/client-negotiation-failover-itest.cc
M src/kudu/integration-tests/master_authz-itest.cc
M src/kudu/integration-tests/master_hms-itest.cc
M src/kudu/integration-tests/security-itest.cc
M src/kudu/integration-tests/txn_commit-itest.cc
M src/kudu/integration-tests/txn_participant-itest.cc
M src/kudu/integration-tests/txn_status_table-itest.cc
M src/kudu/master/txn_manager.cc
M src/kudu/mini-cluster/external_mini_cluster.h
M src/kudu/tools/tool_action_txn.cc
M src/kudu/transactions/txn_system_client.cc
M src/kudu/transactions/txn_system_client.h
13 files changed, 140 insertions(+), 61 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/09/17509/1
--
To view, visit http://gerrit.cloudera.org:8080/17509
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.15.x
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic7b7c7fd154796215bd3a3ce748a2fd3155adebf
Gerrit-Change-Number: 17509
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR](branch-1.15.x) KUDU-1884: set sasl protocol name for the TxnSystemClient
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17509 )
Change subject: KUDU-1884: set sasl_protocol_name for the TxnSystemClient
......................................................................
KUDU-1884: set sasl_protocol_name for the TxnSystemClient
In clusters with a custom principal we need to set the
sasl_protocol_name on the embedded client within the TxnSystemClient.
This logic matches that in server_base.cc for server messenger
configuration.
Change-Id: Ic7b7c7fd154796215bd3a3ce748a2fd3155adebf
Reviewed-on: http://gerrit.cloudera.org:8080/17480
Tested-by: Kudu Jenkins
Reviewed-by: Alexey Serbin <as...@cloudera.com>
(cherry picked from commit 0569c7055cfd22be86a95fabb41e27afd570d784)
Reviewed-on: http://gerrit.cloudera.org:8080/17509
Reviewed-by: Bankim Bhavsar <ba...@cloudera.com>
---
M src/kudu/integration-tests/auth_token_expire-itest.cc
M src/kudu/integration-tests/client-negotiation-failover-itest.cc
M src/kudu/integration-tests/master_authz-itest.cc
M src/kudu/integration-tests/master_hms-itest.cc
M src/kudu/integration-tests/security-itest.cc
M src/kudu/integration-tests/txn_commit-itest.cc
M src/kudu/integration-tests/txn_participant-itest.cc
M src/kudu/integration-tests/txn_status_table-itest.cc
M src/kudu/master/txn_manager.cc
M src/kudu/mini-cluster/external_mini_cluster.h
M src/kudu/tools/tool_action_txn.cc
M src/kudu/transactions/txn_system_client.cc
M src/kudu/transactions/txn_system_client.h
13 files changed, 140 insertions(+), 61 deletions(-)
Approvals:
Kudu Jenkins: Verified
Bankim Bhavsar: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/17509
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.15.x
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic7b7c7fd154796215bd3a3ce748a2fd3155adebf
Gerrit-Change-Number: 17509
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR](branch-1.15.x) KUDU-1884: set sasl protocol name for the TxnSystemClient
Posted by "Bankim Bhavsar (Code Review)" <ge...@cloudera.org>.
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/17509 )
Change subject: KUDU-1884: set sasl_protocol_name for the TxnSystemClient
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/17509
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.15.x
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic7b7c7fd154796215bd3a3ce748a2fd3155adebf
Gerrit-Change-Number: 17509
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 25 May 2021 21:29:37 +0000
Gerrit-HasComments: No