[GitHub] ezelkow1 commented on a change in pull request #3326: Added logging.yaml support

[GitBox <gi...@apache.org>]

ezelkow1 commented on a change in pull request #3326: Added logging.yaml support
URL: https://github.com/apache/trafficcontrol/pull/3326#discussion_r260453068
 
 

 ##########
 File path: traffic_ops/app/lib/API/Configs/ApacheTrafficServer.pm
 ##########
 @@ -1424,6 +1426,94 @@ sub drop_qstring_dot_config {
 	return $text;
 }
 
+sub logging_dot_yaml {
+	my $self        = shift;
+	my $profile_obj = shift;
+
+	my $data = $self->profile_param_data( $profile_obj->id, "logging.yaml" );
+
+	# This is an YAML file, so we need to massage the header a bit for YAML commenting.
+	my $text = "# " . $self->header_comment( $profile_obj->name );
+	$text =~ s/# //;
+	$text =~ s/\n//;
 
 Review comment:
   Removed the # stripping and the # usage in the comment. The default header comment has a # in it and so is already a valid YAML comment

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services