You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by audreyso <gi...@git.apache.org> on 2016/10/03 16:29:04 UTC
[GitHub] cordova-coho pull request #141: CB-9157: Added copy-js command to copy an up...
GitHub user audreyso opened a pull request:
https://github.com/apache/cordova-coho/pull/141
CB-9157: Added copy-js command to copy an updated cordova.js to the specified platform
CB-9157: Added copy-js command to copy an updated cordova.js to the specified platform
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/audreyso/cordova-coho CB-9157
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-coho/pull/141.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #141
----
commit e60c1d39324b943755348f74032680ffdccb4ace
Author: audreyso <au...@adobe.com>
Date: 2016-09-29T23:26:48Z
CB-11642 updated CDVAvailability.h in coho
commit 8ff46ec6bf148a0f64b9c539cbe9aa885be4dc3f
Author: audreyso <au...@adobe.com>
Date: 2016-10-03T16:25:19Z
CB-9157 adds copy-js command to copy an updated cordova.js to the specified platform
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-coho pull request #141: CB-9157: Added copy-js command to copy an up...
Posted by stevengill <gi...@git.apache.org>.
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-coho/pull/141#discussion_r81592147
--- Diff: docs/platforms-release-process.md ---
@@ -1,381 +0,0 @@
-<!--
--- End diff --
looks like you accidentally deleted this file
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-coho pull request #141: CB-9157: Added copy-js command to copy an up...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-coho/pull/141
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-coho pull request #141: CB-9157: Added copy-js command to copy an up...
Posted by stevengill <gi...@git.apache.org>.
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-coho/pull/141#discussion_r81827457
--- Diff: src/platform-release.js ---
@@ -59,6 +59,36 @@ function cpAndLog(src, dest) {
}
}
+/*
+ * A function that handles version if it is defined or undefined
+ *
+ * @param {String} repo current repo
+ * @param {String|undefined} ver current version that can be defined or undefined
+ * @param {String|undefined} validate current version that can be defined or undefined
+ *
+ * @return {String} version Returns the calculated version
+ *
+ */
+
+function *handleVersion(repo,ver,validate) {
+ var platform = repo.id;
+ var version = ver || undefined;
+
+ if (version === undefined) {
+ yield repoutil.forEachRepo([repo], function*() {
+ // Grabbing version from platformPackageJson
+ var platformPackage = path.join(process.cwd(), 'package.json');
+ var platformPackageJson = require(platformPackage);
+ if(validate === true) {
--- End diff --
This if/else should be tabbed as it is inside the `forEachRepo` block
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-coho pull request #141: CB-9157: Added copy-js command to copy an up...
Posted by audreyso <gi...@git.apache.org>.
Github user audreyso commented on a diff in the pull request:
https://github.com/apache/cordova-coho/pull/141#discussion_r81604082
--- Diff: docs/platforms-release-process.md ---
@@ -1,381 +0,0 @@
-<!--
--- End diff --
fixed!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org