You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Michael Bieniosek (JIRA)" <ji...@apache.org> on 2007/04/10 20:09:33 UTC

[jira] Created: (HADOOP-1238) maps_running metric is only updated at the end of the task

maps_running metric is only updated at the end of the task
----------------------------------------------------------

                 Key: HADOOP-1238
                 URL: https://issues.apache.org/jira/browse/HADOOP-1238
             Project: Hadoop
          Issue Type: Bug
          Components: metrics
    Affects Versions: 0.12.3
         Environment: ganglia metrics
            Reporter: Michael Bieniosek


The maps_running and reduces_running metrics aren't getting into ganglia correctly - they always appear to be underestimated.  A quick look at the TaskTracker code shows that these metrics are only updated when a task is finished.  Of course, once a task is finished, the reporting will not note the completed task (since it's not running anymore).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-1238) maps_running metric is only updated at the end of the task

Posted by "Michael Bieniosek (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-1238?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Michael Bieniosek updated HADOOP-1238:
--------------------------------------

    Status: Patch Available  (was: Open)

Adding a patch that sprinkles more metrics updates

> maps_running metric is only updated at the end of the task
> ----------------------------------------------------------
>
>                 Key: HADOOP-1238
>                 URL: https://issues.apache.org/jira/browse/HADOOP-1238
>             Project: Hadoop
>          Issue Type: Bug
>          Components: metrics
>    Affects Versions: 0.12.3
>         Environment: ganglia metrics
>            Reporter: Michael Bieniosek
>            Priority: Minor
>         Attachments: fix-tasks-running-metric.patch
>
>
> The maps_running and reduces_running metrics aren't getting into ganglia correctly - they always appear to be underestimated.  A quick look at the TaskTracker code shows that these metrics are only updated when a task is finished.  Of course, once a task is finished, the reporting will not note the completed task (since it's not running anymore).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-1238) maps_running metric is only updated at the end of the task

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-1238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12488338 ] 

Hadoop QA commented on HADOOP-1238:
-----------------------------------

Integrated in Hadoop-Nightly #55 (See http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Nightly/55/)

> maps_running metric is only updated at the end of the task
> ----------------------------------------------------------
>
>                 Key: HADOOP-1238
>                 URL: https://issues.apache.org/jira/browse/HADOOP-1238
>             Project: Hadoop
>          Issue Type: Bug
>          Components: metrics
>    Affects Versions: 0.12.3
>         Environment: ganglia metrics
>            Reporter: Michael Bieniosek
>         Assigned To: David Bowen
>            Priority: Minor
>             Fix For: 0.13.0
>
>         Attachments: fix-tasks-running-metric.patch
>
>
> The maps_running and reduces_running metrics aren't getting into ganglia correctly - they always appear to be underestimated.  A quick look at the TaskTracker code shows that these metrics are only updated when a task is finished.  Of course, once a task is finished, the reporting will not note the completed task (since it's not running anymore).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-1238) maps_running metric is only updated at the end of the task

Posted by "David Bowen (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-1238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12488208 ] 

David Bowen commented on HADOOP-1238:
-------------------------------------

+1.  Code reviewed.  It looks good to me.



> maps_running metric is only updated at the end of the task
> ----------------------------------------------------------
>
>                 Key: HADOOP-1238
>                 URL: https://issues.apache.org/jira/browse/HADOOP-1238
>             Project: Hadoop
>          Issue Type: Bug
>          Components: metrics
>    Affects Versions: 0.12.3
>         Environment: ganglia metrics
>            Reporter: Michael Bieniosek
>         Assigned To: David Bowen
>            Priority: Minor
>         Attachments: fix-tasks-running-metric.patch
>
>
> The maps_running and reduces_running metrics aren't getting into ganglia correctly - they always appear to be underestimated.  A quick look at the TaskTracker code shows that these metrics are only updated when a task is finished.  Of course, once a task is finished, the reporting will not note the completed task (since it's not running anymore).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-1238) maps_running metric is only updated at the end of the task

Posted by "Michael Bieniosek (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-1238?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Michael Bieniosek updated HADOOP-1238:
--------------------------------------

    Priority: Minor  (was: Major)

> maps_running metric is only updated at the end of the task
> ----------------------------------------------------------
>
>                 Key: HADOOP-1238
>                 URL: https://issues.apache.org/jira/browse/HADOOP-1238
>             Project: Hadoop
>          Issue Type: Bug
>          Components: metrics
>    Affects Versions: 0.12.3
>         Environment: ganglia metrics
>            Reporter: Michael Bieniosek
>            Priority: Minor
>
> The maps_running and reduces_running metrics aren't getting into ganglia correctly - they always appear to be underestimated.  A quick look at the TaskTracker code shows that these metrics are only updated when a task is finished.  Of course, once a task is finished, the reporting will not note the completed task (since it's not running anymore).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-1238) maps_running metric is only updated at the end of the task

Posted by "Doug Cutting (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-1238?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Doug Cutting updated HADOOP-1238:
---------------------------------

       Resolution: Fixed
    Fix Version/s: 0.13.0
           Status: Resolved  (was: Patch Available)

I just committed this.  Thanks, Michael!

> maps_running metric is only updated at the end of the task
> ----------------------------------------------------------
>
>                 Key: HADOOP-1238
>                 URL: https://issues.apache.org/jira/browse/HADOOP-1238
>             Project: Hadoop
>          Issue Type: Bug
>          Components: metrics
>    Affects Versions: 0.12.3
>         Environment: ganglia metrics
>            Reporter: Michael Bieniosek
>         Assigned To: David Bowen
>            Priority: Minor
>             Fix For: 0.13.0
>
>         Attachments: fix-tasks-running-metric.patch
>
>
> The maps_running and reduces_running metrics aren't getting into ganglia correctly - they always appear to be underestimated.  A quick look at the TaskTracker code shows that these metrics are only updated when a task is finished.  Of course, once a task is finished, the reporting will not note the completed task (since it's not running anymore).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-1238) maps_running metric is only updated at the end of the task

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-1238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12487987 ] 

Hadoop QA commented on HADOOP-1238:
-----------------------------------

+1

http://issues.apache.org/jira/secure/attachment/12355270/fix-tasks-running-metric.patch applied and successfully tested against trunk revision r527100.

Results are at http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/22/console

> maps_running metric is only updated at the end of the task
> ----------------------------------------------------------
>
>                 Key: HADOOP-1238
>                 URL: https://issues.apache.org/jira/browse/HADOOP-1238
>             Project: Hadoop
>          Issue Type: Bug
>          Components: metrics
>    Affects Versions: 0.12.3
>         Environment: ganglia metrics
>            Reporter: Michael Bieniosek
>            Priority: Minor
>         Attachments: fix-tasks-running-metric.patch
>
>
> The maps_running and reduces_running metrics aren't getting into ganglia correctly - they always appear to be underestimated.  A quick look at the TaskTracker code shows that these metrics are only updated when a task is finished.  Of course, once a task is finished, the reporting will not note the completed task (since it's not running anymore).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-1238) maps_running metric is only updated at the end of the task

Posted by "Michael Bieniosek (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-1238?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Michael Bieniosek updated HADOOP-1238:
--------------------------------------

    Attachment: fix-tasks-running-metric.patch

> maps_running metric is only updated at the end of the task
> ----------------------------------------------------------
>
>                 Key: HADOOP-1238
>                 URL: https://issues.apache.org/jira/browse/HADOOP-1238
>             Project: Hadoop
>          Issue Type: Bug
>          Components: metrics
>    Affects Versions: 0.12.3
>         Environment: ganglia metrics
>            Reporter: Michael Bieniosek
>            Priority: Minor
>         Attachments: fix-tasks-running-metric.patch
>
>
> The maps_running and reduces_running metrics aren't getting into ganglia correctly - they always appear to be underestimated.  A quick look at the TaskTracker code shows that these metrics are only updated when a task is finished.  Of course, once a task is finished, the reporting will not note the completed task (since it's not running anymore).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (HADOOP-1238) maps_running metric is only updated at the end of the task

Posted by "Doug Cutting (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-1238?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Doug Cutting reassigned HADOOP-1238:
------------------------------------

    Assignee: David Bowen

David, can you please look this over?  Thanks!

> maps_running metric is only updated at the end of the task
> ----------------------------------------------------------
>
>                 Key: HADOOP-1238
>                 URL: https://issues.apache.org/jira/browse/HADOOP-1238
>             Project: Hadoop
>          Issue Type: Bug
>          Components: metrics
>    Affects Versions: 0.12.3
>         Environment: ganglia metrics
>            Reporter: Michael Bieniosek
>         Assigned To: David Bowen
>            Priority: Minor
>         Attachments: fix-tasks-running-metric.patch
>
>
> The maps_running and reduces_running metrics aren't getting into ganglia correctly - they always appear to be underestimated.  A quick look at the TaskTracker code shows that these metrics are only updated when a task is finished.  Of course, once a task is finished, the reporting will not note the completed task (since it's not running anymore).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.