You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/11/03 14:17:18 UTC

[GitHub] [apisix] idbeta opened a new pull request #2605: Update FAQ.md #2583

idbeta opened a new pull request #2605:
URL: https://github.com/apache/apisix/pull/2605


   deal with #2583
   
   ### What this PR does / why we need it:
   <!--- Why is this change required? What problem does it solve? -->
   <!--- If it fixes an open issue, please link to the issue here. -->
   
   ### Pre-submission checklist:
   
   * [x] Did you explain what problem does this PR solve? Or what new features have been added?
   * [ ] Have you added corresponding test cases?
   * [ ] Have you modified the corresponding document?
   * [ ] Is this PR backward compatible?
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] idbeta commented on a change in pull request #2605: docs: sync English version

Posted by GitBox <gi...@apache.org>.
idbeta commented on a change in pull request #2605:
URL: https://github.com/apache/apisix/pull/2605#discussion_r517058107



##########
File path: FAQ.md
##########
@@ -299,13 +299,14 @@ By default, APISIX only listens on port 9080 when handling HTTP requests. If you
 2. Reload or restart APISIX
 
 ## How does APISIX use etcd to achieve millisecond-level configuration synchronization
+
 Etcd provides interfaces `wait` and `waitdir` to monitor whether the specified keywords and directories have changed, and return updated data if they have any changes.
 
 Take the `waitdir` interface as an example:
 
 `syntax: res, err = cli:waitdir(dir:string [, modified_index:uint [, timeout:uint] ])`
 
-The `timeout` parameter indicates the connection `timeout` seconds between the calling process and etcd, set `0` to disable timeout.
+The `timeout` parameter indicates the connection `timeout` seconds between the calling process and etcd.

Review comment:
       the Chinese version I will fix it later.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] idbeta commented on a change in pull request #2605: docs: sync English version

Posted by GitBox <gi...@apache.org>.
idbeta commented on a change in pull request #2605:
URL: https://github.com/apache/apisix/pull/2605#discussion_r551685620



##########
File path: FAQ.md
##########
@@ -297,3 +297,27 @@ By default, APISIX only listens on port 9080 when handling HTTP requests. If you
     ```
 
 2. Reload or restart APISIX
+
+## How does APISIX use etcd to achieve millisecond-level configuration synchronization
+
+Etcd provides interfaces `wait` and `waitdir` to monitor whether the specified keywords and directories have changed, and return updated data if they have any changes.
+
+Take the `waitdir` interface as an example:
+
+`syntax: res, err = cli:waitdir(dir:string [, modified_index:uint [, timeout:uint] ])`
+
+The `timeout` parameter indicates the connection `timeout` seconds between the calling process and etcd.
+
+APISIX configuration of etcd connection time is as follows:
+
+```yaml
+etcd:
+  host:                           # it's possible to define multiple etcd hosts addresses of the same etcd cluster.
+    - "http://127.0.0.1:2379"     # multiple etcd address
+  prefix: "/apisix"               # apisix configurations prefix
+  timeout: 30                     # 30 seconds
+```
+
+APISIX uses the `waitdir` interface to monitor directory changes. The default configuration of timeout is `30` seconds, so APISIX calling process maintains keepalive connection with etcd for `30` seconds.
+
+If the listening directory is not updated when the APISIX process calls this function, the function returns directly, the long connection is maintained, and the calling process can handle other events. If there is data update within `30` seconds, etcd returns the update result through this function, the calling process handle updated data. If no data returned within `30` seconds, when the timeout period reaches 30 seconds, etcd returns a timeout message through this function, and the calling process handles timeout message, then calls the waitdir function to monitor the specified directory again. APISIX realizes real-time configuration updates through the above process.

Review comment:
       fixed.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] membphis commented on a change in pull request #2605: docs: sync English version

Posted by GitBox <gi...@apache.org>.
membphis commented on a change in pull request #2605:
URL: https://github.com/apache/apisix/pull/2605#discussion_r516460328



##########
File path: FAQ.md
##########
@@ -299,13 +299,14 @@ By default, APISIX only listens on port 9080 when handling HTTP requests. If you
 2. Reload or restart APISIX
 
 ## How does APISIX use etcd to achieve millisecond-level configuration synchronization
+
 Etcd provides interfaces `wait` and `waitdir` to monitor whether the specified keywords and directories have changed, and return updated data if they have any changes.
 
 Take the `waitdir` interface as an example:
 
 `syntax: res, err = cli:waitdir(dir:string [, modified_index:uint [, timeout:uint] ])`
 
-The `timeout` parameter indicates the connection `timeout` seconds between the calling process and etcd, set `0` to disable timeout.
+The `timeout` parameter indicates the connection `timeout` seconds between the calling process and etcd.

Review comment:
       Do we need to update the Chinese version?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] idbeta commented on pull request #2605: docs: sync English version

Posted by GitBox <gi...@apache.org>.
idbeta commented on pull request #2605:
URL: https://github.com/apache/apisix/pull/2605#issuecomment-733545834


   > I submit a PR to fix the Chinese version: #2844
   > 
   > The Chinese version is wrong.
   
   thanks, I will update the eng version


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] membphis merged pull request #2605: docs: sync English version

Posted by GitBox <gi...@apache.org>.
membphis merged pull request #2605:
URL: https://github.com/apache/apisix/pull/2605


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] membphis commented on pull request #2605: docs: sync English version

Posted by GitBox <gi...@apache.org>.
membphis commented on pull request #2605:
URL: https://github.com/apache/apisix/pull/2605#issuecomment-733500750


   I submit a PR to fix the Chinese version: https://github.com/apache/apisix/pull/2844
   
   The Chinese version is wrong.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] membphis commented on a change in pull request #2605: docs: sync English version

Posted by GitBox <gi...@apache.org>.
membphis commented on a change in pull request #2605:
URL: https://github.com/apache/apisix/pull/2605#discussion_r519600730



##########
File path: FAQ.md
##########
@@ -299,13 +299,14 @@ By default, APISIX only listens on port 9080 when handling HTTP requests. If you
 2. Reload or restart APISIX
 
 ## How does APISIX use etcd to achieve millisecond-level configuration synchronization
+
 Etcd provides interfaces `wait` and `waitdir` to monitor whether the specified keywords and directories have changed, and return updated data if they have any changes.
 
 Take the `waitdir` interface as an example:
 
 `syntax: res, err = cli:waitdir(dir:string [, modified_index:uint [, timeout:uint] ])`
 
-The `timeout` parameter indicates the connection `timeout` seconds between the calling process and etcd, set `0` to disable timeout.
+The `timeout` parameter indicates the connection `timeout` seconds between the calling process and etcd.

Review comment:
       @idbeta any news?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] spacewander commented on pull request #2605: docs: sync English version

Posted by GitBox <gi...@apache.org>.
spacewander commented on pull request #2605:
URL: https://github.com/apache/apisix/pull/2605#issuecomment-754364953


   @idbeta 
   Need to solve conflict.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] moonming commented on a change in pull request #2605: docs: sync English version

Posted by GitBox <gi...@apache.org>.
moonming commented on a change in pull request #2605:
URL: https://github.com/apache/apisix/pull/2605#discussion_r517141886



##########
File path: FAQ.md
##########
@@ -299,13 +299,14 @@ By default, APISIX only listens on port 9080 when handling HTTP requests. If you
 2. Reload or restart APISIX
 
 ## How does APISIX use etcd to achieve millisecond-level configuration synchronization
+
 Etcd provides interfaces `wait` and `waitdir` to monitor whether the specified keywords and directories have changed, and return updated data if they have any changes.
 
 Take the `waitdir` interface as an example:
 
 `syntax: res, err = cli:waitdir(dir:string [, modified_index:uint [, timeout:uint] ])`
 
-The `timeout` parameter indicates the connection `timeout` seconds between the calling process and etcd, set `0` to disable timeout.
+The `timeout` parameter indicates the connection `timeout` seconds between the calling process and etcd.

Review comment:
       Does this reply make any sense?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] moonming commented on a change in pull request #2605: docs: sync English version

Posted by GitBox <gi...@apache.org>.
moonming commented on a change in pull request #2605:
URL: https://github.com/apache/apisix/pull/2605#discussion_r516721067



##########
File path: FAQ.md
##########
@@ -297,3 +297,27 @@ By default, APISIX only listens on port 9080 when handling HTTP requests. If you
     ```
 
 2. Reload or restart APISIX
+
+## How does APISIX use etcd to achieve millisecond-level configuration synchronization
+
+Etcd provides interfaces `wait` and `waitdir` to monitor whether the specified keywords and directories have changed, and return updated data if they have any changes.
+
+Take the `waitdir` interface as an example:
+
+`syntax: res, err = cli:waitdir(dir:string [, modified_index:uint [, timeout:uint] ])`
+
+The `timeout` parameter indicates the connection `timeout` seconds between the calling process and etcd.
+
+APISIX configuration of etcd long connection time is as follows:

Review comment:
       any response?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] moonming commented on pull request #2605: docs: sync English version

Posted by GitBox <gi...@apache.org>.
moonming commented on pull request #2605:
URL: https://github.com/apache/apisix/pull/2605#issuecomment-754300974


   ping @idbeta 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] idbeta commented on pull request #2605: docs: sync English version

Posted by GitBox <gi...@apache.org>.
idbeta commented on pull request #2605:
URL: https://github.com/apache/apisix/pull/2605#issuecomment-754369401


   > @idbeta
   > Need to solve conflict.
   
   fixed.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] moonming commented on a change in pull request #2605: docs: sync English version

Posted by GitBox <gi...@apache.org>.
moonming commented on a change in pull request #2605:
URL: https://github.com/apache/apisix/pull/2605#discussion_r516471992



##########
File path: FAQ.md
##########
@@ -297,3 +297,27 @@ By default, APISIX only listens on port 9080 when handling HTTP requests. If you
     ```
 
 2. Reload or restart APISIX
+
+## How does APISIX use etcd to achieve millisecond-level configuration synchronization
+
+Etcd provides interfaces `wait` and `waitdir` to monitor whether the specified keywords and directories have changed, and return updated data if they have any changes.
+
+Take the `waitdir` interface as an example:
+
+`syntax: res, err = cli:waitdir(dir:string [, modified_index:uint [, timeout:uint] ])`
+
+The `timeout` parameter indicates the connection `timeout` seconds between the calling process and etcd.
+
+APISIX configuration of etcd long connection time is as follows:

Review comment:
       What is 'Long connection'?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] moonming commented on a change in pull request #2605: docs: sync English version

Posted by GitBox <gi...@apache.org>.
moonming commented on a change in pull request #2605:
URL: https://github.com/apache/apisix/pull/2605#discussion_r517141994



##########
File path: FAQ.md
##########
@@ -297,3 +297,27 @@ By default, APISIX only listens on port 9080 when handling HTTP requests. If you
     ```
 
 2. Reload or restart APISIX
+
+## How does APISIX use etcd to achieve millisecond-level configuration synchronization
+
+Etcd provides interfaces `wait` and `waitdir` to monitor whether the specified keywords and directories have changed, and return updated data if they have any changes.
+
+Take the `waitdir` interface as an example:
+
+`syntax: res, err = cli:waitdir(dir:string [, modified_index:uint [, timeout:uint] ])`
+
+The `timeout` parameter indicates the connection `timeout` seconds between the calling process and etcd.
+
+APISIX configuration of etcd long connection time is as follows:

Review comment:
       Does this reply make any sense?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] membphis commented on a change in pull request #2605: docs: sync English version

Posted by GitBox <gi...@apache.org>.
membphis commented on a change in pull request #2605:
URL: https://github.com/apache/apisix/pull/2605#discussion_r517349719



##########
File path: FAQ.md
##########
@@ -299,13 +299,14 @@ By default, APISIX only listens on port 9080 when handling HTTP requests. If you
 2. Reload or restart APISIX
 
 ## How does APISIX use etcd to achieve millisecond-level configuration synchronization
+
 Etcd provides interfaces `wait` and `waitdir` to monitor whether the specified keywords and directories have changed, and return updated data if they have any changes.
 
 Take the `waitdir` interface as an example:
 
 `syntax: res, err = cli:waitdir(dir:string [, modified_index:uint [, timeout:uint] ])`
 
-The `timeout` parameter indicates the connection `timeout` seconds between the calling process and etcd, set `0` to disable timeout.
+The `timeout` parameter indicates the connection `timeout` seconds between the calling process and etcd.

Review comment:
       > the Chinese version I will fix it later.
   
   do you mean you will fix it in this PR or new PR?
   
   if you want to fix it in new PR, please create an issue about this ^_^




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] idbeta commented on a change in pull request #2605: docs: sync English version

Posted by GitBox <gi...@apache.org>.
idbeta commented on a change in pull request #2605:
URL: https://github.com/apache/apisix/pull/2605#discussion_r517058107



##########
File path: FAQ.md
##########
@@ -299,13 +299,14 @@ By default, APISIX only listens on port 9080 when handling HTTP requests. If you
 2. Reload or restart APISIX
 
 ## How does APISIX use etcd to achieve millisecond-level configuration synchronization
+
 Etcd provides interfaces `wait` and `waitdir` to monitor whether the specified keywords and directories have changed, and return updated data if they have any changes.
 
 Take the `waitdir` interface as an example:
 
 `syntax: res, err = cli:waitdir(dir:string [, modified_index:uint [, timeout:uint] ])`
 
-The `timeout` parameter indicates the connection `timeout` seconds between the calling process and etcd, set `0` to disable timeout.
+The `timeout` parameter indicates the connection `timeout` seconds between the calling process and etcd.

Review comment:
       got it




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] idbeta commented on pull request #2605: docs: sync English version

Posted by GitBox <gi...@apache.org>.
idbeta commented on pull request #2605:
URL: https://github.com/apache/apisix/pull/2605#issuecomment-754356091


   ping @membphis 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] idbeta commented on a change in pull request #2605: docs: sync English version

Posted by GitBox <gi...@apache.org>.
idbeta commented on a change in pull request #2605:
URL: https://github.com/apache/apisix/pull/2605#discussion_r517144419



##########
File path: FAQ.md
##########
@@ -297,3 +297,27 @@ By default, APISIX only listens on port 9080 when handling HTTP requests. If you
     ```
 
 2. Reload or restart APISIX
+
+## How does APISIX use etcd to achieve millisecond-level configuration synchronization
+
+Etcd provides interfaces `wait` and `waitdir` to monitor whether the specified keywords and directories have changed, and return updated data if they have any changes.
+
+Take the `waitdir` interface as an example:
+
+`syntax: res, err = cli:waitdir(dir:string [, modified_index:uint [, timeout:uint] ])`
+
+The `timeout` parameter indicates the connection `timeout` seconds between the calling process and etcd.
+
+APISIX configuration of etcd long connection time is as follows:
+
+```yaml
+etcd:
+  host:                           # it's possible to define multiple etcd hosts addresses of the same etcd cluster.
+    - "http://127.0.0.1:2379"     # multiple etcd address
+  prefix: "/apisix"               # apisix configurations prefix
+  timeout: 30                     # 30 seconds
+```
+
+APISIX uses the `waitdir` interface to monitor directory changes. The default configuration of timeout is `30` seconds, so APISIX calling process maintains a long connection with etcd for `30` seconds.
+
+If the listening directory is not updated when the APISIX process calls this function, the function returns directly, the long connection is maintained, and the calling process can handle other events. If there is data update within `30` seconds, etcd returns the update result through this function, the calling process handle updated data. If no data returned within `30` seconds, when the timeout period reaches 30 seconds, etcd returns a timeout message through this function, and the calling process handle timeout message, then call the waitdir function to monitor the specified directory again. APISIX realizes real-time configuration updates through the above process.

Review comment:
       Ok, I am going to modify this.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] moonming commented on pull request #2605: docs: sync English version

Posted by GitBox <gi...@apache.org>.
moonming commented on pull request #2605:
URL: https://github.com/apache/apisix/pull/2605#issuecomment-733481908


   @idbeta any update?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] membphis commented on a change in pull request #2605: docs: sync English version

Posted by GitBox <gi...@apache.org>.
membphis commented on a change in pull request #2605:
URL: https://github.com/apache/apisix/pull/2605#discussion_r528731441



##########
File path: FAQ.md
##########
@@ -297,3 +297,27 @@ By default, APISIX only listens on port 9080 when handling HTTP requests. If you
     ```
 
 2. Reload or restart APISIX
+
+## How does APISIX use etcd to achieve millisecond-level configuration synchronization
+
+Etcd provides interfaces `wait` and `waitdir` to monitor whether the specified keywords and directories have changed, and return updated data if they have any changes.
+
+Take the `waitdir` interface as an example:
+
+`syntax: res, err = cli:waitdir(dir:string [, modified_index:uint [, timeout:uint] ])`
+
+The `timeout` parameter indicates the connection `timeout` seconds between the calling process and etcd.
+
+APISIX configuration of etcd connection time is as follows:
+
+```yaml
+etcd:
+  host:                           # it's possible to define multiple etcd hosts addresses of the same etcd cluster.
+    - "http://127.0.0.1:2379"     # multiple etcd address
+  prefix: "/apisix"               # apisix configurations prefix
+  timeout: 30                     # 30 seconds
+```
+
+APISIX uses the `waitdir` interface to monitor directory changes. The default configuration of timeout is `30` seconds, so APISIX calling process maintains keepalive connection with etcd for `30` seconds.
+
+If the listening directory is not updated when the APISIX process calls this function, the function returns directly, the long connection is maintained, and the calling process can handle other events. If there is data update within `30` seconds, etcd returns the update result through this function, the calling process handle updated data. If no data returned within `30` seconds, when the timeout period reaches 30 seconds, etcd returns a timeout message through this function, and the calling process handles timeout message, then calls the waitdir function to monitor the specified directory again. APISIX realizes real-time configuration updates through the above process.

Review comment:
       `If the listening directory is not updated when the APISIX process calls this function, the function returns directly`
   
   I think this is wrong. I think you can submit a Chinese version first.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] spacewander commented on a change in pull request #2605: docs: sync English version

Posted by GitBox <gi...@apache.org>.
spacewander commented on a change in pull request #2605:
URL: https://github.com/apache/apisix/pull/2605#discussion_r516466283



##########
File path: FAQ.md
##########
@@ -297,3 +297,27 @@ By default, APISIX only listens on port 9080 when handling HTTP requests. If you
     ```
 
 2. Reload or restart APISIX
+
+## How does APISIX use etcd to achieve millisecond-level configuration synchronization
+
+Etcd provides interfaces `wait` and `waitdir` to monitor whether the specified keywords and directories have changed, and return updated data if they have any changes.
+
+Take the `waitdir` interface as an example:
+
+`syntax: res, err = cli:waitdir(dir:string [, modified_index:uint [, timeout:uint] ])`
+
+The `timeout` parameter indicates the connection `timeout` seconds between the calling process and etcd.
+
+APISIX configuration of etcd long connection time is as follows:
+
+```yaml
+etcd:
+  host:                           # it's possible to define multiple etcd hosts addresses of the same etcd cluster.
+    - "http://127.0.0.1:2379"     # multiple etcd address
+  prefix: "/apisix"               # apisix configurations prefix
+  timeout: 30                     # 30 seconds
+```
+
+APISIX uses the `waitdir` interface to monitor directory changes. The default configuration of timeout is `30` seconds, so APISIX calling process maintains a long connection with etcd for `30` seconds.
+
+If the listening directory is not updated when the APISIX process calls this function, the function returns directly, the long connection is maintained, and the calling process can handle other events. If there is data update within `30` seconds, etcd returns the update result through this function, the calling process handle updated data. If no data returned within `30` seconds, when the timeout period reaches 30 seconds, etcd returns a timeout message through this function, and the calling process handle timeout message, then call the waitdir function to monitor the specified directory again. APISIX realizes real-time configuration updates through the above process.

Review comment:
       "the calling process handle" -> "the calling process handles"
   "then call" -> "then calls"




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] membphis commented on pull request #2605: docs: sync English version

Posted by GitBox <gi...@apache.org>.
membphis commented on pull request #2605:
URL: https://github.com/apache/apisix/pull/2605#issuecomment-721449960


   @idbeta You’d better reply to the comments when the reviewers leave a comment. This means you read the message and fixed it.
   
   ![image](https://user-images.githubusercontent.com/6814606/98055990-c03c8580-1e79-11eb-9cd1-3026d1fe81b3.png)
   
   ![image](https://user-images.githubusercontent.com/6814606/98055995-c599d000-1e79-11eb-8a0b-8e02509ed633.png)
   
   ![image](https://user-images.githubusercontent.com/6814606/98056004-cb8fb100-1e79-11eb-8149-79ebf1d885e5.png)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] membphis commented on a change in pull request #2605: docs: sync English version

Posted by GitBox <gi...@apache.org>.
membphis commented on a change in pull request #2605:
URL: https://github.com/apache/apisix/pull/2605#discussion_r516450672



##########
File path: FAQ.md
##########
@@ -297,3 +297,26 @@ By default, APISIX only listens on port 9080 when handling HTTP requests. If you
     ```
 
 2. Reload or restart APISIX
+
+## How does APISIX use etcd to achieve millisecond-level configuration synchronization
+Etcd provides interfaces `wait` and `waitdir` to monitor whether the specified keywords and directories have changed, and return updated data if they have any changes.

Review comment:
       need a blank line after the title

##########
File path: FAQ.md
##########
@@ -299,13 +299,14 @@ By default, APISIX only listens on port 9080 when handling HTTP requests. If you
 2. Reload or restart APISIX
 
 ## How does APISIX use etcd to achieve millisecond-level configuration synchronization
+
 Etcd provides interfaces `wait` and `waitdir` to monitor whether the specified keywords and directories have changed, and return updated data if they have any changes.
 
 Take the `waitdir` interface as an example:
 
 `syntax: res, err = cli:waitdir(dir:string [, modified_index:uint [, timeout:uint] ])`
 
-The `timeout` parameter indicates the connection `timeout` seconds between the calling process and etcd, set `0` to disable timeout.
+The `timeout` parameter indicates the connection `timeout` seconds between the calling process and etcd.

Review comment:
       Do we need to update the Chinese version.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] membphis commented on a change in pull request #2605: docs: sync English version

Posted by GitBox <gi...@apache.org>.
membphis commented on a change in pull request #2605:
URL: https://github.com/apache/apisix/pull/2605#discussion_r517036911



##########
File path: FAQ.md
##########
@@ -299,13 +299,14 @@ By default, APISIX only listens on port 9080 when handling HTTP requests. If you
 2. Reload or restart APISIX
 
 ## How does APISIX use etcd to achieve millisecond-level configuration synchronization
+
 Etcd provides interfaces `wait` and `waitdir` to monitor whether the specified keywords and directories have changed, and return updated data if they have any changes.
 
 Take the `waitdir` interface as an example:
 
 `syntax: res, err = cli:waitdir(dir:string [, modified_index:uint [, timeout:uint] ])`
 
-The `timeout` parameter indicates the connection `timeout` seconds between the calling process and etcd, set `0` to disable timeout.
+The `timeout` parameter indicates the connection `timeout` seconds between the calling process and etcd.

Review comment:
       ping @idbeta 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] idbeta commented on a change in pull request #2605: docs: sync English version

Posted by GitBox <gi...@apache.org>.
idbeta commented on a change in pull request #2605:
URL: https://github.com/apache/apisix/pull/2605#discussion_r517057884



##########
File path: FAQ.md
##########
@@ -297,3 +297,27 @@ By default, APISIX only listens on port 9080 when handling HTTP requests. If you
     ```
 
 2. Reload or restart APISIX
+
+## How does APISIX use etcd to achieve millisecond-level configuration synchronization
+
+Etcd provides interfaces `wait` and `waitdir` to monitor whether the specified keywords and directories have changed, and return updated data if they have any changes.
+
+Take the `waitdir` interface as an example:
+
+`syntax: res, err = cli:waitdir(dir:string [, modified_index:uint [, timeout:uint] ])`
+
+The `timeout` parameter indicates the connection `timeout` seconds between the calling process and etcd.
+
+APISIX configuration of etcd long connection time is as follows:

Review comment:
       my apology, already fixed.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org