You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by "Prashanth Menon (Created) (JIRA)" <ji...@apache.org> on 2012/03/06 19:02:58 UTC

[jira] [Created] (KAFKA-295) Bug in async producer DefaultEventHandler retry logic

Bug in async producer DefaultEventHandler retry logic
-----------------------------------------------------

                 Key: KAFKA-295
                 URL: https://issues.apache.org/jira/browse/KAFKA-295
             Project: Kafka
          Issue Type: Bug
          Components: core
    Affects Versions: 0.8
            Reporter: Prashanth Menon
             Fix For: 0.8


In the DefaultEventHandler's retry loop, the logic should not return after a successful retry.  Rather, it should set a boolean flag indicating that the retry was successful and exit or break the while loop.  In the end it should throw an exception only the flag is false.  Otherwise, it should continue the outer for loop and send remaining data to remaning brokers.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (KAFKA-295) Bug in async producer DefaultEventHandler retry logic

Posted by "Prashanth Menon (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/KAFKA-295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13228113#comment-13228113 ] 

Prashanth Menon commented on KAFKA-295:
---------------------------------------

This is a small but important bug.  I can drop a patch since I've been touching that code anyways.  It will probably come in after KAFKA-49.
                
> Bug in async producer DefaultEventHandler retry logic
> -----------------------------------------------------
>
>                 Key: KAFKA-295
>                 URL: https://issues.apache.org/jira/browse/KAFKA-295
>             Project: Kafka
>          Issue Type: Bug
>          Components: core
>    Affects Versions: 0.8
>            Reporter: Prashanth Menon
>            Assignee: Prashanth Menon
>             Fix For: 0.8
>
>
> In the DefaultEventHandler's retry loop, the logic should not return after a successful retry.  Rather, it should set a boolean flag indicating that the retry was successful and exit or break the while loop.  In the end it should throw an exception only the flag is false.  Otherwise, it should continue the outer for loop and send remaining data to remaning brokers.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Issue Comment Edited] (KAFKA-295) Bug in async producer DefaultEventHandler retry logic

Posted by "Prashanth Menon (Issue Comment Edited) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/KAFKA-295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13243936#comment-13243936 ] 

Prashanth Menon edited comment on KAFKA-295 at 4/2/12 1:50 AM:
---------------------------------------------------------------

Incorporated as part of KAFKA-300 and KAFKA-305.
                
      was (Author: prashanth.menon):
    Incorporated as part of KAFKA-300 and KAKFA-305.
                  
> Bug in async producer DefaultEventHandler retry logic
> -----------------------------------------------------
>
>                 Key: KAFKA-295
>                 URL: https://issues.apache.org/jira/browse/KAFKA-295
>             Project: Kafka
>          Issue Type: Bug
>          Components: core
>    Affects Versions: 0.8
>            Reporter: Prashanth Menon
>            Assignee: Prashanth Menon
>             Fix For: 0.8
>
>
> In the DefaultEventHandler's retry loop, the logic should not return after a successful retry.  Rather, it should set a boolean flag indicating that the retry was successful and exit or break the while loop.  In the end it should throw an exception only the flag is false.  Otherwise, it should continue the outer for loop and send remaining data to remaning brokers.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Resolved] (KAFKA-295) Bug in async producer DefaultEventHandler retry logic

Posted by "Prashanth Menon (Resolved) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/KAFKA-295?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Prashanth Menon resolved KAFKA-295.
-----------------------------------

    Resolution: Fixed

Incorporated as part of KAFKA-300 and KAKFA-305.
                
> Bug in async producer DefaultEventHandler retry logic
> -----------------------------------------------------
>
>                 Key: KAFKA-295
>                 URL: https://issues.apache.org/jira/browse/KAFKA-295
>             Project: Kafka
>          Issue Type: Bug
>          Components: core
>    Affects Versions: 0.8
>            Reporter: Prashanth Menon
>            Assignee: Prashanth Menon
>             Fix For: 0.8
>
>
> In the DefaultEventHandler's retry loop, the logic should not return after a successful retry.  Rather, it should set a boolean flag indicating that the retry was successful and exit or break the while loop.  In the end it should throw an exception only the flag is false.  Otherwise, it should continue the outer for loop and send remaining data to remaning brokers.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Assigned] (KAFKA-295) Bug in async producer DefaultEventHandler retry logic

Posted by "Prashanth Menon (Assigned) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/KAFKA-295?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Prashanth Menon reassigned KAFKA-295:
-------------------------------------

    Assignee: Prashanth Menon
    
> Bug in async producer DefaultEventHandler retry logic
> -----------------------------------------------------
>
>                 Key: KAFKA-295
>                 URL: https://issues.apache.org/jira/browse/KAFKA-295
>             Project: Kafka
>          Issue Type: Bug
>          Components: core
>    Affects Versions: 0.8
>            Reporter: Prashanth Menon
>            Assignee: Prashanth Menon
>             Fix For: 0.8
>
>
> In the DefaultEventHandler's retry loop, the logic should not return after a successful retry.  Rather, it should set a boolean flag indicating that the retry was successful and exit or break the while loop.  In the end it should throw an exception only the flag is false.  Otherwise, it should continue the outer for loop and send remaining data to remaning brokers.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira