You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by "isapego (via GitHub)" <gi...@apache.org> on 2025/04/03 00:24:55 UTC
[PR] IGNITE-22857 C++ Remove NUMBER and BITMASK types [ignite-3]
isapego opened a new pull request, #5558:
URL: https://github.com/apache/ignite-3/pull/5558
https://issues.apache.org/jira/browse/IGNITE-22857
Removed unsupported types basically.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-22857 C++ Remove NUMBER and BITMASK types [ignite-3]
Posted by "isapego (via GitHub)" <gi...@apache.org>.
isapego merged PR #5558:
URL: https://github.com/apache/ignite-3/pull/5558
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-22857 C++ Remove NUMBER and BITMASK types [ignite-3]
Posted by "arcolight (via GitHub)" <gi...@apache.org>.
arcolight commented on code in PR #5558:
URL: https://github.com/apache/ignite-3/pull/5558#discussion_r2026498993
##########
modules/platforms/cpp/ignite/odbc/query/type_info_query.cpp:
##########
@@ -152,10 +152,9 @@ type_info_query::type_info_query(diagnosable_adapter &diag, std::int16_t sql_typ
m_types.push_back(ignite_type::DATETIME);
m_types.push_back(ignite_type::TIMESTAMP);
m_types.push_back(ignite_type::UUID);
- m_types.push_back(ignite_type::BITMASK);
m_types.push_back(ignite_type::STRING);
m_types.push_back(ignite_type::BYTE_ARRAY);
- // TODO: IGNITE-19969 implement support for period, duration and big_integer
+ // TODO: IGNITE-19969 implement support for period an duration
Review Comment:
```suggestion
// TODO: IGNITE-19969 implement support for period and duration
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org