You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Jesse Yates (Created) (JIRA)" <ji...@apache.org> on 2012/02/07 23:23:00 UTC
[jira] [Created] (HBASE-5348) Constraint configuration loaded with
bloat
Constraint configuration loaded with bloat
------------------------------------------
Key: HBASE-5348
URL: https://issues.apache.org/jira/browse/HBASE-5348
Project: HBase
Issue Type: Bug
Components: coprocessors, regionserver
Affects Versions: 0.94.0
Reporter: Jesse Yates
Assignee: Jesse Yates
Priority: Minor
Constraints load the configuration but don't load the 'correct' configuration, but instead instantiate the default configuration (via new Configuration). It should just be Configuration(false)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5348) Constraint configuration loaded with
bloat
Posted by "Jesse Yates (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5348?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jesse Yates updated HBASE-5348:
-------------------------------
Attachment: java_HBASE-5348.patch
Fix for the creating the configuration and updating the tests to check for the proper conf.
> Constraint configuration loaded with bloat
> ------------------------------------------
>
> Key: HBASE-5348
> URL: https://issues.apache.org/jira/browse/HBASE-5348
> Project: HBase
> Issue Type: Bug
> Components: coprocessors, regionserver
> Affects Versions: 0.94.0
> Reporter: Jesse Yates
> Assignee: Jesse Yates
> Priority: Minor
> Attachments: java_HBASE-5348.patch
>
>
> Constraints load the configuration but don't load the 'correct' configuration, but instead instantiate the default configuration (via new Configuration). It should just be Configuration(false)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5348) Constraint configuration loaded
with bloat
Posted by "Zhihong Yu (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13202882#comment-13202882 ]
Zhihong Yu commented on HBASE-5348:
-----------------------------------
{code}
+ throw new IllegalArgumentException(
+ "Configuration was created improperly");
{code}
Should we provide hint as to what would be the correct way of creating Configuration ?
> Constraint configuration loaded with bloat
> ------------------------------------------
>
> Key: HBASE-5348
> URL: https://issues.apache.org/jira/browse/HBASE-5348
> Project: HBase
> Issue Type: Bug
> Components: coprocessors, regionserver
> Affects Versions: 0.94.0
> Reporter: Jesse Yates
> Assignee: Jesse Yates
> Priority: Minor
> Attachments: java_HBASE-5348.patch
>
>
> Constraints load the configuration but don't load the 'correct' configuration, but instead instantiate the default configuration (via new Configuration). It should just be Configuration(false)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5348) Constraint configuration loaded with
bloat
Posted by "stack (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5348?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HBASE-5348:
-------------------------
Resolution: Fixed
Fix Version/s: 0.94.0
Hadoop Flags: Reviewed
Status: Resolved (was: Patch Available)
Committed to trunk. Thanks for the patch Jesse.
> Constraint configuration loaded with bloat
> ------------------------------------------
>
> Key: HBASE-5348
> URL: https://issues.apache.org/jira/browse/HBASE-5348
> Project: HBase
> Issue Type: Bug
> Components: coprocessors, regionserver
> Affects Versions: 0.94.0
> Reporter: Jesse Yates
> Assignee: Jesse Yates
> Priority: Minor
> Fix For: 0.94.0
>
> Attachments: java_HBASE-5348.patch, java_HBASE-5348.patch
>
>
> Constraints load the configuration but don't load the 'correct' configuration, but instead instantiate the default configuration (via new Configuration). It should just be Configuration(false)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5348) Constraint configuration loaded
with bloat
Posted by "stack (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13202971#comment-13202971 ]
stack commented on HBASE-5348:
------------------------------
I see that now. Agree it would be overkill. Let me commit.
> Constraint configuration loaded with bloat
> ------------------------------------------
>
> Key: HBASE-5348
> URL: https://issues.apache.org/jira/browse/HBASE-5348
> Project: HBase
> Issue Type: Bug
> Components: coprocessors, regionserver
> Affects Versions: 0.94.0
> Reporter: Jesse Yates
> Assignee: Jesse Yates
> Priority: Minor
> Attachments: java_HBASE-5348.patch, java_HBASE-5348.patch
>
>
> Constraints load the configuration but don't load the 'correct' configuration, but instead instantiate the default configuration (via new Configuration). It should just be Configuration(false)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5348) Constraint configuration loaded
with bloat
Posted by "stack (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13202916#comment-13202916 ]
stack commented on HBASE-5348:
------------------------------
Why don't you want to load the 'default' config? What do you get if you don't load *.xml files?
> Constraint configuration loaded with bloat
> ------------------------------------------
>
> Key: HBASE-5348
> URL: https://issues.apache.org/jira/browse/HBASE-5348
> Project: HBase
> Issue Type: Bug
> Components: coprocessors, regionserver
> Affects Versions: 0.94.0
> Reporter: Jesse Yates
> Assignee: Jesse Yates
> Priority: Minor
> Attachments: java_HBASE-5348.patch, java_HBASE-5348.patch
>
>
> Constraints load the configuration but don't load the 'correct' configuration, but instead instantiate the default configuration (via new Configuration). It should just be Configuration(false)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5348) Constraint configuration loaded
with bloat
Posted by "stack (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13202946#comment-13202946 ]
stack commented on HBASE-5348:
------------------------------
@Jesse Ok. Make a patch w/ the little paragraph as a comment on why you pass false and I'll +1 it (passing a boolean in to a Configuration constructor is not done elsewhere in hbase codebase that I know of so it needs a little explaination). Thanks.
> Constraint configuration loaded with bloat
> ------------------------------------------
>
> Key: HBASE-5348
> URL: https://issues.apache.org/jira/browse/HBASE-5348
> Project: HBase
> Issue Type: Bug
> Components: coprocessors, regionserver
> Affects Versions: 0.94.0
> Reporter: Jesse Yates
> Assignee: Jesse Yates
> Priority: Minor
> Attachments: java_HBASE-5348.patch, java_HBASE-5348.patch
>
>
> Constraints load the configuration but don't load the 'correct' configuration, but instead instantiate the default configuration (via new Configuration). It should just be Configuration(false)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5348) Constraint configuration loaded
with bloat
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13203296#comment-13203296 ]
Hudson commented on HBASE-5348:
-------------------------------
Integrated in HBase-TRUNK-security #101 (See [https://builds.apache.org/job/HBase-TRUNK-security/101/])
HBASE-5348 Constraint configuration loaded with bloat
stack :
Files :
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/constraint/Constraints.java
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/constraint/CheckConfigurationConstraint.java
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/constraint/TestConstraints.java
> Constraint configuration loaded with bloat
> ------------------------------------------
>
> Key: HBASE-5348
> URL: https://issues.apache.org/jira/browse/HBASE-5348
> Project: HBase
> Issue Type: Bug
> Components: coprocessors, regionserver
> Affects Versions: 0.94.0
> Reporter: Jesse Yates
> Assignee: Jesse Yates
> Priority: Minor
> Fix For: 0.94.0
>
> Attachments: java_HBASE-5348.patch, java_HBASE-5348.patch
>
>
> Constraints load the configuration but don't load the 'correct' configuration, but instead instantiate the default configuration (via new Configuration). It should just be Configuration(false)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5348) Constraint configuration loaded
with bloat
Posted by "Jesse Yates (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13202921#comment-13202921 ]
Jesse Yates commented on HBASE-5348:
------------------------------------
If you don't put the false in, you get all the default hadoop configuration values (from core-default.xml and core-site.xml). You really don't need to keep these values around in the configuration, and even worse, they are given precedence when looking up values when adding new configs resources. To ensure the added config is given precedence, we would have to iterate all the values in the config to be added and to a conf.set() for each of those values - not pretty.
If you don't load the xml files, then you just end up with an empty configuration (no default values).
> Constraint configuration loaded with bloat
> ------------------------------------------
>
> Key: HBASE-5348
> URL: https://issues.apache.org/jira/browse/HBASE-5348
> Project: HBase
> Issue Type: Bug
> Components: coprocessors, regionserver
> Affects Versions: 0.94.0
> Reporter: Jesse Yates
> Assignee: Jesse Yates
> Priority: Minor
> Attachments: java_HBASE-5348.patch, java_HBASE-5348.patch
>
>
> Constraints load the configuration but don't load the 'correct' configuration, but instead instantiate the default configuration (via new Configuration). It should just be Configuration(false)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5348) Constraint configuration loaded
with bloat
Posted by "Jesse Yates (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13202956#comment-13202956 ]
Jesse Yates commented on HBASE-5348:
------------------------------------
There is actually a comment on this already in the package-info.java. This patch is just to fix a bug I found going back through the code. I can add another comment paragraph in the code if you want, but it seems a little overkill to me.
> Constraint configuration loaded with bloat
> ------------------------------------------
>
> Key: HBASE-5348
> URL: https://issues.apache.org/jira/browse/HBASE-5348
> Project: HBase
> Issue Type: Bug
> Components: coprocessors, regionserver
> Affects Versions: 0.94.0
> Reporter: Jesse Yates
> Assignee: Jesse Yates
> Priority: Minor
> Attachments: java_HBASE-5348.patch, java_HBASE-5348.patch
>
>
> Constraints load the configuration but don't load the 'correct' configuration, but instead instantiate the default configuration (via new Configuration). It should just be Configuration(false)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5348) Constraint configuration loaded
with bloat
Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13202925#comment-13202925 ]
Hadoop QA commented on HBASE-5348:
----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12513697/java_HBASE-5348.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 6 new or modified tests.
-1 javadoc. The javadoc tool appears to have generated -136 warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
-1 findbugs. The patch appears to introduce 156 new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed these unit tests:
org.apache.hadoop.hbase.mapreduce.TestImportTsv
org.apache.hadoop.hbase.mapred.TestTableMapReduce
org.apache.hadoop.hbase.mapreduce.TestHFileOutputFormat
Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/915//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/915//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/915//console
This message is automatically generated.
> Constraint configuration loaded with bloat
> ------------------------------------------
>
> Key: HBASE-5348
> URL: https://issues.apache.org/jira/browse/HBASE-5348
> Project: HBase
> Issue Type: Bug
> Components: coprocessors, regionserver
> Affects Versions: 0.94.0
> Reporter: Jesse Yates
> Assignee: Jesse Yates
> Priority: Minor
> Attachments: java_HBASE-5348.patch, java_HBASE-5348.patch
>
>
> Constraints load the configuration but don't load the 'correct' configuration, but instead instantiate the default configuration (via new Configuration). It should just be Configuration(false)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5348) Constraint configuration loaded with
bloat
Posted by "Jesse Yates (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5348?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jesse Yates updated HBASE-5348:
-------------------------------
Attachment: java_HBASE-5348.patch
Updating the patch, should be good to go.
> Constraint configuration loaded with bloat
> ------------------------------------------
>
> Key: HBASE-5348
> URL: https://issues.apache.org/jira/browse/HBASE-5348
> Project: HBase
> Issue Type: Bug
> Components: coprocessors, regionserver
> Affects Versions: 0.94.0
> Reporter: Jesse Yates
> Assignee: Jesse Yates
> Priority: Minor
> Attachments: java_HBASE-5348.patch, java_HBASE-5348.patch
>
>
> Constraints load the configuration but don't load the 'correct' configuration, but instead instantiate the default configuration (via new Configuration). It should just be Configuration(false)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5348) Constraint configuration loaded
with bloat
Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13202947#comment-13202947 ]
Hadoop QA commented on HBASE-5348:
----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12513700/java_HBASE-5348.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 6 new or modified tests.
-1 javadoc. The javadoc tool appears to have generated -136 warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
-1 findbugs. The patch appears to introduce 156 new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed these unit tests:
org.apache.hadoop.hbase.io.hfile.TestHFileBlock
org.apache.hadoop.hbase.replication.TestReplication
Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/916//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/916//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/916//console
This message is automatically generated.
> Constraint configuration loaded with bloat
> ------------------------------------------
>
> Key: HBASE-5348
> URL: https://issues.apache.org/jira/browse/HBASE-5348
> Project: HBase
> Issue Type: Bug
> Components: coprocessors, regionserver
> Affects Versions: 0.94.0
> Reporter: Jesse Yates
> Assignee: Jesse Yates
> Priority: Minor
> Attachments: java_HBASE-5348.patch, java_HBASE-5348.patch
>
>
> Constraints load the configuration but don't load the 'correct' configuration, but instead instantiate the default configuration (via new Configuration). It should just be Configuration(false)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5348) Constraint configuration loaded
with bloat
Posted by "Jesse Yates (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13202871#comment-13202871 ]
Jesse Yates commented on HBASE-5348:
------------------------------------
patch coming momentarily
> Constraint configuration loaded with bloat
> ------------------------------------------
>
> Key: HBASE-5348
> URL: https://issues.apache.org/jira/browse/HBASE-5348
> Project: HBase
> Issue Type: Bug
> Components: coprocessors, regionserver
> Affects Versions: 0.94.0
> Reporter: Jesse Yates
> Assignee: Jesse Yates
> Priority: Minor
>
> Constraints load the configuration but don't load the 'correct' configuration, but instead instantiate the default configuration (via new Configuration). It should just be Configuration(false)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5348) Constraint configuration loaded
with bloat
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13205346#comment-13205346 ]
Hudson commented on HBASE-5348:
-------------------------------
Integrated in HBase-TRUNK #2656 (See [https://builds.apache.org/job/HBase-TRUNK/2656/])
HBASE-5348 Constraint configuration loaded with bloat
stack :
Files :
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/constraint/Constraints.java
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/constraint/CheckConfigurationConstraint.java
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/constraint/TestConstraints.java
> Constraint configuration loaded with bloat
> ------------------------------------------
>
> Key: HBASE-5348
> URL: https://issues.apache.org/jira/browse/HBASE-5348
> Project: HBase
> Issue Type: Bug
> Components: coprocessors, regionserver
> Affects Versions: 0.94.0
> Reporter: Jesse Yates
> Assignee: Jesse Yates
> Priority: Minor
> Fix For: 0.94.0
>
> Attachments: java_HBASE-5348.patch, java_HBASE-5348.patch
>
>
> Constraints load the configuration but don't load the 'correct' configuration, but instead instantiate the default configuration (via new Configuration). It should just be Configuration(false)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5348) Constraint configuration loaded with
bloat
Posted by "Jesse Yates (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5348?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jesse Yates updated HBASE-5348:
-------------------------------
Status: Patch Available (was: Open)
> Constraint configuration loaded with bloat
> ------------------------------------------
>
> Key: HBASE-5348
> URL: https://issues.apache.org/jira/browse/HBASE-5348
> Project: HBase
> Issue Type: Bug
> Components: coprocessors, regionserver
> Affects Versions: 0.94.0
> Reporter: Jesse Yates
> Assignee: Jesse Yates
> Priority: Minor
> Attachments: java_HBASE-5348.patch
>
>
> Constraints load the configuration but don't load the 'correct' configuration, but instead instantiate the default configuration (via new Configuration). It should just be Configuration(false)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira