[jira] [Comment Edited] (CASSANDRA-14108) Improve commit log chain marker updating

["Jason Brown (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CASSANDRA-14108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16287857#comment-16287857 ] 

Jason Brown edited comment on CASSANDRA-14108 at 12/12/17 4:44 PM:
-------------------------------------------------------------------

I've assigned [~aweisberg] as reviewer, but it'd be fantastic if [~beobal] could take a look, as well.


was (Author: jasobrown):
I've assigned [~aweisberg] as reviewer, but I'd be fantastic if [~beobal] could take a look, as well.

> Improve commit log chain marker updating
> ----------------------------------------
>
>                 Key: CASSANDRA-14108
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-14108
>             Project: Cassandra
>          Issue Type: Bug
>            Reporter: Jason Brown
>            Assignee: Jason Brown
>             Fix For: 4.x
>
>
> CASSANDRA-13987 addressed the commit log behavior change that was introduced with CASSANDRA-3578. After that patch was committed, [~aweisberg] did his own review and found a bug as well as having some concerns about the configuration. He and I discussed offline, and agreed on some improvements. 
> Instead of requiring users to configure a deep, dark implementation detail like the commit log chained markers (via {{commitlog_marker_period_in_ms}} in the yaml), we decided it is best to eliminate thew configuration and always update the chained markers (when in periodic mode). 
> The bug [~aweisberg] found was when the chained marker update is not a value that evenly divides into the periodic sync mode value, we would not sync in an expected manner. For example if the marker interval is 9 seconds, and the sync interval is 10 seconds, we would update the markers at time9, but we would then sleep for another 9 seconds, and when we wake up at time18, it is then that we flush - 8 seconds later than we should have. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org