You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "Ewan-Keith (via GitHub)" <gi...@apache.org> on 2023/06/26 22:18:09 UTC
[GitHub] [iceberg] Ewan-Keith opened a new pull request, #7917: Docs: add support for spark TimestampNtz type to docs
Ewan-Keith opened a new pull request, #7917:
URL: https://github.com/apache/iceberg/pull/7917
The new `TimestampNtz` Spark type (added in spark 3.4.0) is now [supported by Iceberg](https://github.com/apache/iceberg/pull/7553), this just updates the type conversion tables in the iceberg docs to reflect this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] Fokko merged pull request #7917: Docs: add support for spark TimestampNtz type to docs
Posted by "Fokko (via GitHub)" <gi...@apache.org>.
Fokko merged PR #7917:
URL: https://github.com/apache/iceberg/pull/7917
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] Fokko commented on a diff in pull request #7917: Docs: add support for spark TimestampNtz type to docs
Posted by "Fokko (via GitHub)" <gi...@apache.org>.
Fokko commented on code in PR #7917:
URL: https://github.com/apache/iceberg/pull/7917#discussion_r1243193249
##########
docs/spark-writes.md:
##########
@@ -397,25 +397,26 @@ so you may want to understand the type conversion in Iceberg in prior to design
This type conversion table describes how Spark types are converted to the Iceberg types. The conversion applies on both creating Iceberg table and writing to Iceberg table via Spark.
-| Spark | Iceberg | Notes |
-|-----------------|-------------------------|-------|
-| boolean | boolean | |
-| short | integer | |
-| byte | integer | |
-| integer | integer | |
-| long | long | |
-| float | float | |
-| double | double | |
-| date | date | |
-| timestamp | timestamp with timezone | |
-| char | string | |
-| varchar | string | |
-| string | string | |
-| binary | binary | |
-| decimal | decimal | |
-| struct | struct | |
-| array | list | |
-| map | map | |
+| Spark | Iceberg | Notes |
+|-----------------|----------------------------|-------|
+| boolean | boolean | |
+| short | integer | |
+| byte | integer | |
+| integer | integer | |
+| long | long | |
+| float | float | |
+| double | double | |
+| date | date | |
+| timestamp | timestamp with timezone | |
+| timestampNtz | timestamp without timezone | |
Review Comment:
```suggestion
| timestamp_ntz | timestamp without timezone | |
```
##########
docs/spark-writes.md:
##########
@@ -438,7 +439,7 @@ This type conversion table describes how Iceberg types are converted to the Spar
| date | date | |
| time | | Not supported |
| timestamp with timezone | timestamp | |
-| timestamp without timezone | | Not supported |
+| timestamp without timezone | timestampNtz | |
Review Comment:
```suggestion
| timestamp without timezone | timestamp_ntz | |
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] Ewan-Keith commented on a diff in pull request #7917: Docs: add support for spark TimestampNtz type to docs
Posted by "Ewan-Keith (via GitHub)" <gi...@apache.org>.
Ewan-Keith commented on code in PR #7917:
URL: https://github.com/apache/iceberg/pull/7917#discussion_r1243426633
##########
docs/spark-writes.md:
##########
@@ -438,7 +439,7 @@ This type conversion table describes how Iceberg types are converted to the Spar
| date | date | |
| time | | Not supported |
| timestamp with timezone | timestamp | |
-| timestamp without timezone | | Not supported |
+| timestamp without timezone | timestampNtz | |
Review Comment:
yup, that reads a bit nicer :+1:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] Ewan-Keith commented on a diff in pull request #7917: Docs: add support for spark TimestampNtz type to docs
Posted by "Ewan-Keith (via GitHub)" <gi...@apache.org>.
Ewan-Keith commented on code in PR #7917:
URL: https://github.com/apache/iceberg/pull/7917#discussion_r1243425690
##########
docs/spark-writes.md:
##########
@@ -397,25 +397,26 @@ so you may want to understand the type conversion in Iceberg in prior to design
This type conversion table describes how Spark types are converted to the Iceberg types. The conversion applies on both creating Iceberg table and writing to Iceberg table via Spark.
-| Spark | Iceberg | Notes |
-|-----------------|-------------------------|-------|
-| boolean | boolean | |
-| short | integer | |
-| byte | integer | |
-| integer | integer | |
-| long | long | |
-| float | float | |
-| double | double | |
-| date | date | |
-| timestamp | timestamp with timezone | |
-| char | string | |
-| varchar | string | |
-| string | string | |
-| binary | binary | |
-| decimal | decimal | |
-| struct | struct | |
-| array | list | |
-| map | map | |
+| Spark | Iceberg | Notes |
+|-----------------|----------------------------|-------|
+| boolean | boolean | |
+| short | integer | |
+| byte | integer | |
+| integer | integer | |
+| long | long | |
+| float | float | |
+| double | double | |
+| date | date | |
+| timestamp | timestamp with timezone | |
+| timestampNtz | timestamp without timezone | |
Review Comment:
yup, that reads a bit nicer :+1:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org