You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "featzhang (via GitHub)" <gi...@apache.org> on 2026/05/03 06:23:11 UTC
[PR] [FLINK-39042][webui] Port timezone-aware watermark timestamps to release-2.1 [flink]
featzhang opened a new pull request, #28092:
URL: https://github.com/apache/flink/pull/28092
## What is the purpose of the change
Port [PR #27552](https://github.com/apache/flink/pull/27552) (FLINK-39042) from `master` to `release-2.1`. Makes watermark timestamps in the Web UI timezone-aware and user-configurable: the Watermarks drawer now shows a timezone selector populated from `Intl.supportedValuesOf('timeZone')`, defaulting to the browser's local IANA zone, and the datetime pipe honours the selection (DST handled automatically via the Intl API).
## Brief change log
Cherry-pick of `64d0316aad22e83888b65e6c3036d0a980ae33a9` onto `release-2.1`. Four files changed, `+172 / -11`:
- `humanize-watermark.pipe.ts` — `HumanizeWatermarkToDatetimePipe` accepts an optional IANA timezone arg and formats via `Intl.DateTimeFormat`; keeps legacy behaviour when no zone is passed.
- `job-overview-drawer-watermarks.component.{ts,html,less}` — adds timezone dropdown (nz-select), populates options from `Intl.supportedValuesOf('timeZone')`, defaults to `Intl.DateTimeFormat().resolvedOptions().timeZone`, wires it into the datetime column.
## Backport notes (conflicts resolved)
Two conflicts resolved manually — both are environmental drift, not logic drift:
1. **`job-overview-drawer-watermarks.component.ts` — `@Component.imports`**: `release-2.1` still uses the legacy ng-zorro name `NzToolTipModule` (capital `T`), while `master` has been renamed to `NzTooltipModule`. Kept `release-2.1`'s `NzToolTipModule` spelling in both the `import` and the `imports` array, while adopting the new array entries the PR requires (`NgForOf`, `FormsModule`, `NzSelectModule`).
2. **`job-status.component.less`**: the `.back-link` block reordered by the original PR does not exist on `release-2.1` — it was introduced on `master` by an unrelated later PR. Dropped this hunk; the resulting net diff for this file is **0**, so `release-2.1` is untouched here. (This accounts for the slightly smaller overall diff vs the original PR's 178/14.)
No other code changes, no semantic deviation from the master PR.
## Verification
- `npm ci && npm run lint` — ✅ clean
- `npm run build` (i.e. `ng build --configuration production`) — ✅ produced `watermarks-job-overview-drawer-watermarks-component` chunk without errors
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): **no**
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: **no**
- The serializers: **no**
- The runtime per-record code paths (performance sensitive): **no**
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: **no**
- The S3 file system connector: **no**
## Documentation
- Does this pull request introduce a new feature? **no** (backport of existing feature)
- If yes, how is the feature documented? **not applicable**
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-39042][webui] Port timezone-aware watermark timestamps to release-2.1 [flink]
Posted by "flinkbot (via GitHub)" <gi...@apache.org>.
flinkbot commented on PR #28092:
URL: https://github.com/apache/flink/pull/28092#issuecomment-4365555925
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7f037a3fa8142acb6edac0da77ee0c1e52d2f8a2",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "7f037a3fa8142acb6edac0da77ee0c1e52d2f8a2",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7f037a3fa8142acb6edac0da77ee0c1e52d2f8a2 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-39042][webui] Port timezone-aware watermark timestamps to release-2.1 [flink]
Posted by "RocMarshal (via GitHub)" <gi...@apache.org>.
RocMarshal merged PR #28092:
URL: https://github.com/apache/flink/pull/28092
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org