[GitHub] [hbase] apurtell commented on a change in pull request #1039: HBASE-23647: Make MasterRegistry the default impl.

[GitBox <gi...@apache.org>]

apurtell commented on a change in pull request #1039: HBASE-23647: Make MasterRegistry the default impl.
URL: https://github.com/apache/hbase/pull/1039#discussion_r369862135
 
 

 ##########
 File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
 ##########
 @@ -789,8 +789,19 @@ public boolean registerService(com.google.protobuf.Service instance) {
     return true;
   }
 
-  private Configuration unsetClientZookeeperQuorum() {
+  private Configuration cleanupConfiguration() {
     Configuration conf = this.conf;
+    // We use ZKConnectionRegistry for all the internal communication, primarily for these reasons:
+    // - Decouples RS and master life cycles. For example, if all the masters are down, region
+    //   servers can abort at the same time, because the internal connection is master dependent and
+    //   fails.This is an operational nightmare. Using the ZK based registry means that the region
+    //   servers are now on the look out for new masters, if they are spun up.
 
 Review comment:
   The tense here is confusing. 
   
   "Using the ZK based registry means the region servers continue to be independent of master availability..." ?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services