You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by guozhangwang <gi...@git.apache.org> on 2016/07/10 05:07:47 UTC

[GitHub] kafka pull request #1604: KAFKA-3887 Follow-up: add unit test for null check...

GitHub user guozhangwang opened a pull request:

    https://github.com/apache/kafka/pull/1604

    KAFKA-3887 Follow-up: add unit test for null checking in KTable aggregates

    Also made a pass over the streams unit tests, with the following changes:
    
    1. Removed three integration tests as they are already covered by other integration tests.
    2. Merged `KGroupedTableImplTest` into `KTableAggregateTest`.
    3. Use mocks whenever possible to reduce code duplicates.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/guozhangwang/kafka Kminor-unit-tests-consolidation

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/kafka/pull/1604.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1604
    
----
commit c08d252e591cae875b9c43e81f38e078a025f46a
Author: Guozhang Wang <wa...@gmail.com>
Date:   2016-07-10T05:03:50Z

    make a pass over unit tests

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] kafka pull request #1604: KAFKA-3887 Follow-up: add unit test for null check...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/kafka/pull/1604


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---