You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2019/11/09 07:35:23 UTC

[GitHub] [incubator-tvm] u99127 commented on issue #4292: Retain qnn input kernel scales

u99127 commented on issue #4292: Retain qnn input kernel scales
URL: https://github.com/apache/incubator-tvm/pull/4292#issuecomment-552075218
 
 
   > 
   > 
   > Overall LGTM. The only change I request is changing the name to input_scale and kernel_scale. I have similar naming elsewhere, so will be easy to read.
   
   Sure.
   
   When I wrote it, I felt it better to keep the name distinct to indicate the difference between input_scale in Requantize vs here but I suppose `tensor' is superfluous to requirements .. 
   
   
   Ramana

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services