[jira] [Commented] (STORM-2428) Flux-core jar contains unpacked dependencies

["Richard Zowalla (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/STORM-2428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16366751#comment-16366751 ] 

Richard Zowalla commented on STORM-2428:
----------------------------------------

I solved this issue by extracting / filtering this dependencies in the shading process:
{code:java}
<filter>
 <!-- we need to exclude some shaded and old stuff here which comes in a modern version via ES artifacts-->
 <artifact>org.apache.storm:flux-core</artifact>
 <excludes>
 <exclude>org/apache/commons/**</exclude>
 <exclude>org/apache/http/**</exclude>
 <exclude>org/yaml/**</exclude>
 </excludes>
</filter>{code}
However, I think that making flux-core a fat jar with some (very old) dependencies is not a good solution.

> Flux-core jar contains unpacked dependencies
> --------------------------------------------
>
>                 Key: STORM-2428
>                 URL: https://issues.apache.org/jira/browse/STORM-2428
>             Project: Apache Storm
>          Issue Type: Bug
>          Components: Flux
>    Affects Versions: 1.1.0, 1.0.3
>            Reporter: Julien Nioche
>            Priority: Major
>
> The jar file for flux-core contains classes from /org/apache/http/. This was not the case before and causes problems with projects which rely on a different version of http-client. 
> I can't see any references to http-client in the pom though.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)