You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Radhika PC <ra...@citrix.com> on 2013/03/04 08:13:40 UTC
Review Request: Document add/remove network on a VM features
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9726/
-----------------------------------------------------------
Review request for cloudstack, David Nalley, Jessica Tomechak, Joe Brockmeier, and Marcus Sorensen.
Description
-------
Add /Remove Networks in VMs. Updated the Developer Guide.
This addresses bug cloudstack-890.
Diffs
-----
docs/en-US/add-remove-nic.xml PRE-CREATION
docs/en-US/added-API-commands-4-1.xml f635e9d
docs/en-US/whats-new.xml 29ae1f6
Diff: https://reviews.apache.org/r/9726/diff/
Testing
-------
Doc builds, patch applies
Thanks,
Radhika PC
Re: Review Request: Document add/remove network on a VM features
Posted by Radhika PC <ra...@citrix.com>.
> On March 6, 2013, 5:06 a.m., Marcus Sorensen wrote:
> > Looks good to me.
Thank you Marcus.
Merged:
4.1
Commit: 47ea8bee95d906f21722de1689cb28a556e3b073
Master
Commit: 00cd9d5d6fd0901dc00b9f685897ef8e8736453e
- Radhika
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9726/#review17449
-----------------------------------------------------------
On March 5, 2013, 10:46 a.m., Radhika PC wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9726/
> -----------------------------------------------------------
>
> (Updated March 5, 2013, 10:46 a.m.)
>
>
> Review request for cloudstack, David Nalley, Jessica Tomechak, Joe Brockmeier, and Marcus Sorensen.
>
>
> Description
> -------
>
> Add /Remove Networks in VMs. Updated the Developer Guide.
>
>
> This addresses bugs cloudstack-815 and cloudstack-890.
>
>
> Diffs
> -----
>
> docs/en-US/add-remove-nic.xml PRE-CREATION
> docs/en-US/added-API-commands-4-1.xml f635e9d
> docs/en-US/whats-new.xml 29ae1f6
>
> Diff: https://reviews.apache.org/r/9726/diff/
>
>
> Testing
> -------
>
> Doc builds, patch applies
>
>
> Thanks,
>
> Radhika PC
>
>
Re: Review Request: Document add/remove network on a VM features
Posted by Marcus Sorensen <sh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9726/#review17449
-----------------------------------------------------------
Ship it!
Looks good to me.
- Marcus Sorensen
On March 5, 2013, 10:46 a.m., Radhika PC wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9726/
> -----------------------------------------------------------
>
> (Updated March 5, 2013, 10:46 a.m.)
>
>
> Review request for cloudstack, David Nalley, Jessica Tomechak, Joe Brockmeier, and Marcus Sorensen.
>
>
> Description
> -------
>
> Add /Remove Networks in VMs. Updated the Developer Guide.
>
>
> This addresses bugs cloudstack-815 and cloudstack-890.
>
>
> Diffs
> -----
>
> docs/en-US/add-remove-nic.xml PRE-CREATION
> docs/en-US/added-API-commands-4-1.xml f635e9d
> docs/en-US/whats-new.xml 29ae1f6
>
> Diff: https://reviews.apache.org/r/9726/diff/
>
>
> Testing
> -------
>
> Doc builds, patch applies
>
>
> Thanks,
>
> Radhika PC
>
>
Re: Review Request: Document add/remove network on a VM features
Posted by Radhika PC <ra...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9726/
-----------------------------------------------------------
(Updated March 5, 2013, 10:46 a.m.)
Review request for cloudstack, David Nalley, Jessica Tomechak, Joe Brockmeier, and Marcus Sorensen.
Description
-------
Add /Remove Networks in VMs. Updated the Developer Guide.
This addresses bugs cloudstack-815 and cloudstack-890.
Diffs
-----
docs/en-US/add-remove-nic.xml PRE-CREATION
docs/en-US/added-API-commands-4-1.xml f635e9d
docs/en-US/whats-new.xml 29ae1f6
Diff: https://reviews.apache.org/r/9726/diff/
Testing
-------
Doc builds, patch applies
Thanks,
Radhika PC
Re: Review Request: Document add/remove network on a VM features
Posted by Radhika PC <ra...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9726/
-----------------------------------------------------------
(Updated March 5, 2013, 10:34 a.m.)
Review request for cloudstack, David Nalley, Jessica Tomechak, Joe Brockmeier, and Marcus Sorensen.
Description
-------
Add /Remove Networks in VMs. Updated the Developer Guide.
This addresses bugs cloudstack-815 and cloudstack-890.
Diffs
-----
docs/en-US/add-remove-nic.xml PRE-CREATION
docs/en-US/added-API-commands-4-1.xml f635e9d
docs/en-US/whats-new.xml 29ae1f6
Diff: https://reviews.apache.org/r/9726/diff/
Testing
-------
Doc builds, patch applies
Thanks,
Radhika PC
Re: Review Request: Document add/remove network on a VM features
Posted by Radhika PC <ra...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9726/
-----------------------------------------------------------
(Updated March 5, 2013, 10:34 a.m.)
Review request for cloudstack, David Nalley, Jessica Tomechak, Joe Brockmeier, and Marcus Sorensen.
Changes
-------
Addressed the issues pointed out in the review. Additionally, added the new APIs for the AWS-Style Regions to the added-api-commands-4.1.xml file.
Description
-------
Add /Remove Networks in VMs. Updated the Developer Guide.
This addresses bugs cloudstack-815 and cloudstack-890.
Diffs (updated)
-----
docs/en-US/add-remove-nic.xml PRE-CREATION
docs/en-US/added-API-commands-4-1.xml f635e9d
docs/en-US/whats-new.xml 29ae1f6
Diff: https://reviews.apache.org/r/9726/diff/
Testing
-------
Doc builds, patch applies
Thanks,
Radhika PC
Re: Review Request: Document add/remove network on a VM features
Posted by Marcus Sorensen <sh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9726/#review17338
-----------------------------------------------------------
docs/en-US/add-remove-nic.xml
<https://reviews.apache.org/r/9726/#comment36836>
User shouldn't have to ensure that the VM is in the same zone as the network. The code will not allow it. Rather than giving the reader a command to check that the network and vm are in the same zone, perhaps change this to something that is strictly informative, like "The network and VM instance must reside in the same zone".
To the list of things to watch out for, we could also add "Two VMs with the same name cannot reside in the same network. Adding a second VM that duplicates a name on a network will fail."
docs/en-US/add-remove-nic.xml
<https://reviews.apache.org/r/9726/#comment36835>
Removing the default NIC is not possible. The way this reads, it sounds like it is warning the user to not do it.
docs/en-US/add-remove-nic.xml
<https://reviews.apache.org/r/9726/#comment36837>
We should probably not mention exceptions in the user documentation. This makes it sound as though there's a bug, when it's most likely an invalid parameter provided or something. Better to just say "Removing the default NIC is not possible" or something like that. Then if it fails the user will understand why, but not think it's due to a bug of some sort.
docs/en-US/add-remove-nic.xml
<https://reviews.apache.org/r/9726/#comment36838>
This probably isn't necessary for the user documentation. If a user tries to remove a nic that isn't part of the VM, it follows naturally that it will fail.
- Marcus Sorensen
On March 4, 2013, 8:23 a.m., Radhika PC wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9726/
> -----------------------------------------------------------
>
> (Updated March 4, 2013, 8:23 a.m.)
>
>
> Review request for cloudstack, David Nalley, Jessica Tomechak, Joe Brockmeier, and Marcus Sorensen.
>
>
> Description
> -------
>
> Add /Remove Networks in VMs. Updated the Developer Guide.
>
>
> This addresses bug cloudstack-890.
>
>
> Diffs
> -----
>
> docs/en-US/add-remove-nic.xml PRE-CREATION
> docs/en-US/added-API-commands-4-1.xml f635e9d
> docs/en-US/whats-new.xml 29ae1f6
>
> Diff: https://reviews.apache.org/r/9726/diff/
>
>
> Testing
> -------
>
> Doc builds, patch applies
>
>
> Thanks,
>
> Radhika PC
>
>
Re: Review Request: Document add/remove network on a VM features
Posted by Radhika PC <ra...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9726/
-----------------------------------------------------------
(Updated March 4, 2013, 8:23 a.m.)
Review request for cloudstack, David Nalley, Jessica Tomechak, Joe Brockmeier, and Marcus Sorensen.
Changes
-------
attaching a patch for 4.1
Description
-------
Add /Remove Networks in VMs. Updated the Developer Guide.
This addresses bug cloudstack-890.
Diffs
-----
docs/en-US/add-remove-nic.xml PRE-CREATION
docs/en-US/added-API-commands-4-1.xml f635e9d
docs/en-US/whats-new.xml 29ae1f6
Diff: https://reviews.apache.org/r/9726/diff/
Testing
-------
Doc builds, patch applies
Thanks,
Radhika PC