You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@samza.apache.org by Jagadish Venkatraman <ja...@gmail.com> on 2016/10/03 23:11:03 UTC
Re: Review Request 47835: SAMZA-914: Initial draft for Java
programming APIs on operators supporting DAGs
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47835/#review151227
-----------------------------------------------------------
Overall, this is looking pretty good! Just some minor comments.
samza-operator/src/main/java/org/apache/samza/operators/api/MessageStream.java (line 84)
<https://reviews.apache.org/r/47835/#comment219530>
I thought the `Operators` class was maintaining state of the topology. (and hence, that was the reason for passing in `this` so that we know the wiring of input to output operators). Is the `MessageStream` or some other component owning that wire-up?
wondering why we removed `this`?
samza-operator/src/main/java/org/apache/samza/operators/api/internal/Operators.java (line 253)
<https://reviews.apache.org/r/47835/#comment219535>
nit: variable name `windowFn`. We can use `window` to refer to anything that implements a `Window`
samza-operator/src/main/java/org/apache/samza/operators/api/internal/Trigger.java (line 61)
<https://reviews.apache.org/r/47835/#comment219538>
nit: *Private* constructor to prevent instantiation.
samza-operator/src/main/java/org/apache/samza/task/StreamOperatorAdaptorTask.java (line 38)
<https://reviews.apache.org/r/47835/#comment219540>
When using with HDFS-style consumer (which is bounded), how will we handle the last batch?
Shouldn't the adaptor also implement the `EndOfStreamListener` task. that will guarantee that the last batch is handled correctly? (by triggering the output corresponding to the last batch).
samza-operator/src/test/java/org/apache/samza/task/WindowOperatorTask.java (line 49)
<https://reviews.apache.org/r/47835/#comment219558>
1. Wouldn't it be nicer to not have an avro dependency in our open-source examples? All our open source examples are non-avro. It seems that this example maybe easy to demo with a simple `JSON`/ a `String` based example? (It can be a follow-up)
Is this meant to be run as a test? Or as a show-case of the API?
If it's a show-case, we should move it to samza-hello-world once we're done. (can be a follow-up)
2. Also, what do you think about creating a new package namespace `examples` instead of `test`?
- Jagadish Venkatraman
On Sept. 29, 2016, 2:05 a.m., Yi Pan (Data Infrastructure) wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47835/
> -----------------------------------------------------------
>
> (Updated Sept. 29, 2016, 2:05 a.m.)
>
>
> Review request for samza, Boris Shkolnik, Chris Pettitt, Chinmay Soman, Jake Maes, Navina Ramesh, Jagadish Venkatraman, and Xinyu Liu.
>
>
> Bugs: SAMZA-914
> https://issues.apache.org/jira/browse/SAMZA-914
>
>
> Repository: samza
>
>
> Description
> -------
>
> SAMZA-914: initial draft of operator programming API. Design doc attached to SAMZA-914: https://issues.apache.org/jira/secure/attachment/12821524/SAMZA-914_%20operator%20Java%20programming%20API%20-%20Google%20Docs.pdf
>
>
> Diffs
> -----
>
> build.gradle 16facbbf4dff378c561461786ff186bd9e0000ed
> gradle/dependency-versions.gradle 52e25aa53a1edc85d478b48898621b26508ad4bb
> samza-api/src/test/java/org/apache/samza/config/TestConfig.java 5d066c5867e9df9e94e60bde825dedf10703b399
> samza-operator/src/main/java/org/apache/samza/operators/api/MessageStream.java PRE-CREATION
> samza-operator/src/main/java/org/apache/samza/operators/api/MessageStreams.java PRE-CREATION
> samza-operator/src/main/java/org/apache/samza/operators/api/TriggerBuilder.java PRE-CREATION
> samza-operator/src/main/java/org/apache/samza/operators/api/WindowState.java PRE-CREATION
> samza-operator/src/main/java/org/apache/samza/operators/api/Windows.java PRE-CREATION
> samza-operator/src/main/java/org/apache/samza/operators/api/data/Message.java PRE-CREATION
> samza-operator/src/main/java/org/apache/samza/operators/api/internal/Operators.java PRE-CREATION
> samza-operator/src/main/java/org/apache/samza/operators/api/internal/Trigger.java PRE-CREATION
> samza-operator/src/main/java/org/apache/samza/operators/api/internal/WindowFn.java PRE-CREATION
> samza-operator/src/main/java/org/apache/samza/operators/api/internal/WindowOutput.java PRE-CREATION
> samza-operator/src/main/java/org/apache/samza/operators/impl/ChainedOperators.java PRE-CREATION
> samza-operator/src/main/java/org/apache/samza/operators/impl/OperatorImpl.java PRE-CREATION
> samza-operator/src/main/java/org/apache/samza/operators/impl/ProcessorContext.java PRE-CREATION
> samza-operator/src/main/java/org/apache/samza/operators/impl/SimpleOperatorImpl.java PRE-CREATION
> samza-operator/src/main/java/org/apache/samza/operators/impl/StateStoreImpl.java PRE-CREATION
> samza-operator/src/main/java/org/apache/samza/operators/impl/window/SessionWindowImpl.java PRE-CREATION
> samza-operator/src/main/java/org/apache/samza/task/StreamOperatorAdaptorTask.java PRE-CREATION
> samza-operator/src/main/java/org/apache/samza/task/StreamOperatorTask.java PRE-CREATION
> samza-operator/src/test/java/org/apache/samza/operators/api/TestTriggerBuilder.java PRE-CREATION
> samza-operator/src/test/java/org/apache/samza/operators/api/TestWindows.java PRE-CREATION
> samza-operator/src/test/java/org/apache/samza/operators/api/data/TestIncomingSystemMessage.java PRE-CREATION
> samza-operator/src/test/java/org/apache/samza/operators/api/data/TestLongOffset.java PRE-CREATION
> samza-operator/src/test/java/org/apache/samza/operators/api/internal/TestOperators.java PRE-CREATION
> samza-operator/src/test/java/org/apache/samza/operators/api/internal/TestTrigger.java PRE-CREATION
> samza-operator/src/test/java/org/apache/samza/operators/impl/TestOperatorImpl.java PRE-CREATION
> samza-operator/src/test/java/org/apache/samza/operators/impl/TestOutputMessage.java PRE-CREATION
> samza-operator/src/test/java/org/apache/samza/operators/impl/TestProcessorContext.java PRE-CREATION
> samza-operator/src/test/java/org/apache/samza/operators/impl/TestSimpleOperatorImpl.java PRE-CREATION
> samza-operator/src/test/java/org/apache/samza/operators/impl/TestSinkOperatorImpl.java PRE-CREATION
> samza-operator/src/test/java/org/apache/samza/operators/impl/TestStateStoreImpl.java PRE-CREATION
> samza-operator/src/test/java/org/apache/samza/operators/impl/window/TestSessionWindowImpl.java PRE-CREATION
> samza-operator/src/test/java/org/apache/samza/task/AssembleCallGraphTask.java PRE-CREATION
> samza-operator/src/test/java/org/apache/samza/task/BroadcastOperatorTask.java PRE-CREATION
> samza-operator/src/test/java/org/apache/samza/task/InputAvroSystemMessage.java PRE-CREATION
> samza-operator/src/test/java/org/apache/samza/task/JoinOperatorTask.java PRE-CREATION
> samza-operator/src/test/java/org/apache/samza/task/TestStreamOperatorAdaptorTask.java PRE-CREATION
> samza-operator/src/test/java/org/apache/samza/task/TestStreamOperatorTasks.java PRE-CREATION
> samza-operator/src/test/java/org/apache/samza/task/WindowOperatorTask.java PRE-CREATION
> samza-sql-calcite/src/test/java/org/apache/samza/sql/calcite/schema/TestAvroSchemaConverter.java PRE-CREATION
> samza-sql-core/README.md PRE-CREATION
> samza-sql-core/src/main/java/org/apache/samza/sql/api/data/Data.java PRE-CREATION
> samza-sql-core/src/main/java/org/apache/samza/sql/api/data/EntityName.java PRE-CREATION
> samza-sql-core/src/main/java/org/apache/samza/sql/api/data/Relation.java PRE-CREATION
> samza-sql-core/src/main/java/org/apache/samza/sql/api/data/Schema.java PRE-CREATION
> samza-sql-core/src/main/java/org/apache/samza/sql/api/data/Stream.java PRE-CREATION
> samza-sql-core/src/main/java/org/apache/samza/sql/api/data/Table.java PRE-CREATION
> samza-sql-core/src/main/java/org/apache/samza/sql/api/data/Tuple.java PRE-CREATION
> samza-sql-core/src/main/java/org/apache/samza/sql/api/operators/Operator.java PRE-CREATION
> samza-sql-core/src/main/java/org/apache/samza/sql/api/operators/OperatorCallback.java PRE-CREATION
> samza-sql-core/src/main/java/org/apache/samza/sql/api/operators/OperatorRouter.java PRE-CREATION
> samza-sql-core/src/main/java/org/apache/samza/sql/api/operators/OperatorSpec.java PRE-CREATION
> samza-sql-core/src/main/java/org/apache/samza/sql/api/operators/SimpleOperator.java PRE-CREATION
> samza-sql-core/src/main/java/org/apache/samza/sql/api/operators/SqlOperatorFactory.java PRE-CREATION
> samza-sql-core/src/main/java/org/apache/samza/sql/data/IncomingMessageTuple.java PRE-CREATION
> samza-sql-core/src/main/java/org/apache/samza/sql/data/avro/AvroData.java PRE-CREATION
> samza-sql-core/src/main/java/org/apache/samza/sql/data/avro/AvroSchema.java PRE-CREATION
> samza-sql-core/src/main/java/org/apache/samza/sql/data/serializers/SqlAvroSerde.java PRE-CREATION
> samza-sql-core/src/main/java/org/apache/samza/sql/data/serializers/SqlAvroSerdeFactory.java PRE-CREATION
> samza-sql-core/src/main/java/org/apache/samza/sql/data/serializers/SqlStringSerde.java PRE-CREATION
> samza-sql-core/src/main/java/org/apache/samza/sql/data/serializers/SqlStringSerdeFactory.java PRE-CREATION
> samza-sql-core/src/main/java/org/apache/samza/sql/data/string/StringData.java PRE-CREATION
> samza-sql-core/src/main/java/org/apache/samza/sql/data/string/StringSchema.java PRE-CREATION
> samza-sql-core/src/main/java/org/apache/samza/sql/operators/factory/NoopOperatorCallback.java PRE-CREATION
> samza-sql-core/src/main/java/org/apache/samza/sql/operators/factory/SimpleOperatorFactoryImpl.java PRE-CREATION
> samza-sql-core/src/main/java/org/apache/samza/sql/operators/factory/SimpleOperatorImpl.java PRE-CREATION
> samza-sql-core/src/main/java/org/apache/samza/sql/operators/factory/SimpleOperatorSpec.java PRE-CREATION
> samza-sql-core/src/main/java/org/apache/samza/sql/operators/factory/SimpleRouter.java PRE-CREATION
> samza-sql-core/src/main/java/org/apache/samza/sql/operators/join/StreamStreamJoin.java PRE-CREATION
> samza-sql-core/src/main/java/org/apache/samza/sql/operators/join/StreamStreamJoinSpec.java PRE-CREATION
> samza-sql-core/src/main/java/org/apache/samza/sql/operators/partition/PartitionOp.java PRE-CREATION
> samza-sql-core/src/main/java/org/apache/samza/sql/operators/partition/PartitionSpec.java PRE-CREATION
> samza-sql-core/src/main/java/org/apache/samza/sql/operators/window/BoundedTimeWindow.java PRE-CREATION
> samza-sql-core/src/main/java/org/apache/samza/sql/operators/window/WindowSpec.java PRE-CREATION
> samza-sql-core/src/main/java/org/apache/samza/sql/operators/window/WindowState.java PRE-CREATION
> samza-sql-core/src/main/java/org/apache/samza/sql/window/storage/OrderedStoreKey.java PRE-CREATION
> samza-sql-core/src/main/java/org/apache/samza/system/sql/LongOffset.java PRE-CREATION
> samza-sql-core/src/main/java/org/apache/samza/system/sql/Offset.java PRE-CREATION
> samza-sql-core/src/main/java/org/apache/samza/task/sql/RouterMessageCollector.java PRE-CREATION
> samza-sql-core/src/main/java/org/apache/samza/task/sql/SimpleMessageCollector.java PRE-CREATION
> samza-sql-core/src/test/java/org/apache/samza/sql/data/serializers/SqlAvroSerdeTest.java PRE-CREATION
> samza-sql-core/src/test/java/org/apache/samza/task/sql/RandomWindowOperatorTask.java PRE-CREATION
> samza-sql-core/src/test/java/org/apache/samza/task/sql/StreamSqlTask.java PRE-CREATION
> samza-sql-core/src/test/java/org/apache/samza/task/sql/UserCallbacksSqlTask.java PRE-CREATION
> settings.gradle 4c1aa107a11d413777e69bc4e48847b811aff7d2
>
> Diff: https://reviews.apache.org/r/47835/diff/
>
>
> Testing
> -------
>
> ./gradlew clean build
>
>
> Thanks,
>
> Yi Pan (Data Infrastructure)
>
>
Re: Review Request 47835: SAMZA-914: Initial draft for Java
programming APIs on operators supporting DAGs
Posted by "Yi Pan (Data Infrastructure)" <yi...@linkedin.com>.
> On Oct. 3, 2016, 11:11 p.m., Jagadish Venkatraman wrote:
> > samza-operator/src/main/java/org/apache/samza/operators/api/MessageStream.java, line 102
> > <https://reviews.apache.org/r/47835/diff/15-17/?file=1498252#file1498252line102>
> >
> > I thought the `Operators` class was maintaining state of the topology. (and hence, that was the reason for passing in `this` so that we know the wiring of input to output operators). Is the `MessageStream` or some other component owning that wire-up?
> >
> > wondering why we removed `this`?
Adding this here is a bit early when we are not 100% sure what would be the best place to save the topology info. Hence, removing for now. I am working on the patch for SAMZA-915 that's to wire everything up, in which I am re-evaluating whether we should put it in or not.
> On Oct. 3, 2016, 11:11 p.m., Jagadish Venkatraman wrote:
> > samza-operator/src/main/java/org/apache/samza/operators/api/internal/Operators.java, line 255
> > <https://reviews.apache.org/r/47835/diff/15-17/?file=1498259#file1498259line255>
> >
> > nit: variable name `windowFn`. We can use `window` to refer to anything that implements a `Window`
Good point. Done.
> On Oct. 3, 2016, 11:11 p.m., Jagadish Venkatraman wrote:
> > samza-operator/src/main/java/org/apache/samza/operators/api/internal/Trigger.java, line 61
> > <https://reviews.apache.org/r/47835/diff/15-17/?file=1498260#file1498260line61>
> >
> > nit: *Private* constructor to prevent instantiation.
Done.
> On Oct. 3, 2016, 11:11 p.m., Jagadish Venkatraman wrote:
> > samza-operator/src/main/java/org/apache/samza/task/StreamOperatorAdaptorTask.java, line 38
> > <https://reviews.apache.org/r/47835/diff/15/?file=1498268#file1498268line38>
> >
> > When using with HDFS-style consumer (which is bounded), how will we handle the last batch?
> >
> > Shouldn't the adaptor also implement the `EndOfStreamListener` task. that will guarantee that the last batch is handled correctly? (by triggering the output corresponding to the last batch).
Not in the current scope yet. I would prefer to leave it for later evaluation, since a) end-of-stream is not in production yet; b) this is internal class which does not affect user API.
> On Oct. 3, 2016, 11:11 p.m., Jagadish Venkatraman wrote:
> > samza-operator/src/test/java/org/apache/samza/task/WindowOperatorTask.java, line 50
> > <https://reviews.apache.org/r/47835/diff/15-17/?file=1498276#file1498276line50>
> >
> > 1. Wouldn't it be nicer to not have an avro dependency in our open-source examples? All our open source examples are non-avro. It seems that this example maybe easy to demo with a simple `JSON`/ a `String` based example? (It can be a follow-up)
> >
> > Is this meant to be run as a test? Or as a show-case of the API?
> >
> > If it's a show-case, we should move it to samza-hello-world once we're done. (can be a follow-up)
> >
> > 2. Also, what do you think about creating a new package namespace `examples` instead of `test`?
Good point. I will remove the avro examples and replace them w/ JSON. The purpose of the test cases here is both for unit test and demo. We can move them to examples as you suggest later.
- Yi
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47835/#review151227
-----------------------------------------------------------
On Sept. 29, 2016, 2:05 a.m., Yi Pan (Data Infrastructure) wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47835/
> -----------------------------------------------------------
>
> (Updated Sept. 29, 2016, 2:05 a.m.)
>
>
> Review request for samza, Boris Shkolnik, Chris Pettitt, Chinmay Soman, Jake Maes, Navina Ramesh, Jagadish Venkatraman, and Xinyu Liu.
>
>
> Bugs: SAMZA-914
> https://issues.apache.org/jira/browse/SAMZA-914
>
>
> Repository: samza
>
>
> Description
> -------
>
> SAMZA-914: initial draft of operator programming API. Design doc attached to SAMZA-914: https://issues.apache.org/jira/secure/attachment/12821524/SAMZA-914_%20operator%20Java%20programming%20API%20-%20Google%20Docs.pdf
>
>
> Diffs
> -----
>
> build.gradle 16facbbf4dff378c561461786ff186bd9e0000ed
> gradle/dependency-versions.gradle 52e25aa53a1edc85d478b48898621b26508ad4bb
> samza-api/src/test/java/org/apache/samza/config/TestConfig.java 5d066c5867e9df9e94e60bde825dedf10703b399
> samza-operator/src/main/java/org/apache/samza/operators/api/MessageStream.java PRE-CREATION
> samza-operator/src/main/java/org/apache/samza/operators/api/MessageStreams.java PRE-CREATION
> samza-operator/src/main/java/org/apache/samza/operators/api/TriggerBuilder.java PRE-CREATION
> samza-operator/src/main/java/org/apache/samza/operators/api/WindowState.java PRE-CREATION
> samza-operator/src/main/java/org/apache/samza/operators/api/Windows.java PRE-CREATION
> samza-operator/src/main/java/org/apache/samza/operators/api/data/Message.java PRE-CREATION
> samza-operator/src/main/java/org/apache/samza/operators/api/internal/Operators.java PRE-CREATION
> samza-operator/src/main/java/org/apache/samza/operators/api/internal/Trigger.java PRE-CREATION
> samza-operator/src/main/java/org/apache/samza/operators/api/internal/WindowFn.java PRE-CREATION
> samza-operator/src/main/java/org/apache/samza/operators/api/internal/WindowOutput.java PRE-CREATION
> samza-operator/src/main/java/org/apache/samza/operators/impl/ChainedOperators.java PRE-CREATION
> samza-operator/src/main/java/org/apache/samza/operators/impl/OperatorImpl.java PRE-CREATION
> samza-operator/src/main/java/org/apache/samza/operators/impl/ProcessorContext.java PRE-CREATION
> samza-operator/src/main/java/org/apache/samza/operators/impl/SimpleOperatorImpl.java PRE-CREATION
> samza-operator/src/main/java/org/apache/samza/operators/impl/StateStoreImpl.java PRE-CREATION
> samza-operator/src/main/java/org/apache/samza/operators/impl/window/SessionWindowImpl.java PRE-CREATION
> samza-operator/src/main/java/org/apache/samza/task/StreamOperatorAdaptorTask.java PRE-CREATION
> samza-operator/src/main/java/org/apache/samza/task/StreamOperatorTask.java PRE-CREATION
> samza-operator/src/test/java/org/apache/samza/operators/api/TestTriggerBuilder.java PRE-CREATION
> samza-operator/src/test/java/org/apache/samza/operators/api/TestWindows.java PRE-CREATION
> samza-operator/src/test/java/org/apache/samza/operators/api/data/TestIncomingSystemMessage.java PRE-CREATION
> samza-operator/src/test/java/org/apache/samza/operators/api/data/TestLongOffset.java PRE-CREATION
> samza-operator/src/test/java/org/apache/samza/operators/api/internal/TestOperators.java PRE-CREATION
> samza-operator/src/test/java/org/apache/samza/operators/api/internal/TestTrigger.java PRE-CREATION
> samza-operator/src/test/java/org/apache/samza/operators/impl/TestOperatorImpl.java PRE-CREATION
> samza-operator/src/test/java/org/apache/samza/operators/impl/TestOutputMessage.java PRE-CREATION
> samza-operator/src/test/java/org/apache/samza/operators/impl/TestProcessorContext.java PRE-CREATION
> samza-operator/src/test/java/org/apache/samza/operators/impl/TestSimpleOperatorImpl.java PRE-CREATION
> samza-operator/src/test/java/org/apache/samza/operators/impl/TestSinkOperatorImpl.java PRE-CREATION
> samza-operator/src/test/java/org/apache/samza/operators/impl/TestStateStoreImpl.java PRE-CREATION
> samza-operator/src/test/java/org/apache/samza/operators/impl/window/TestSessionWindowImpl.java PRE-CREATION
> samza-operator/src/test/java/org/apache/samza/task/AssembleCallGraphTask.java PRE-CREATION
> samza-operator/src/test/java/org/apache/samza/task/BroadcastOperatorTask.java PRE-CREATION
> samza-operator/src/test/java/org/apache/samza/task/InputAvroSystemMessage.java PRE-CREATION
> samza-operator/src/test/java/org/apache/samza/task/JoinOperatorTask.java PRE-CREATION
> samza-operator/src/test/java/org/apache/samza/task/TestStreamOperatorAdaptorTask.java PRE-CREATION
> samza-operator/src/test/java/org/apache/samza/task/TestStreamOperatorTasks.java PRE-CREATION
> samza-operator/src/test/java/org/apache/samza/task/WindowOperatorTask.java PRE-CREATION
> samza-sql-calcite/src/test/java/org/apache/samza/sql/calcite/schema/TestAvroSchemaConverter.java PRE-CREATION
> samza-sql-core/README.md PRE-CREATION
> samza-sql-core/src/main/java/org/apache/samza/sql/api/data/Data.java PRE-CREATION
> samza-sql-core/src/main/java/org/apache/samza/sql/api/data/EntityName.java PRE-CREATION
> samza-sql-core/src/main/java/org/apache/samza/sql/api/data/Relation.java PRE-CREATION
> samza-sql-core/src/main/java/org/apache/samza/sql/api/data/Schema.java PRE-CREATION
> samza-sql-core/src/main/java/org/apache/samza/sql/api/data/Stream.java PRE-CREATION
> samza-sql-core/src/main/java/org/apache/samza/sql/api/data/Table.java PRE-CREATION
> samza-sql-core/src/main/java/org/apache/samza/sql/api/data/Tuple.java PRE-CREATION
> samza-sql-core/src/main/java/org/apache/samza/sql/api/operators/Operator.java PRE-CREATION
> samza-sql-core/src/main/java/org/apache/samza/sql/api/operators/OperatorCallback.java PRE-CREATION
> samza-sql-core/src/main/java/org/apache/samza/sql/api/operators/OperatorRouter.java PRE-CREATION
> samza-sql-core/src/main/java/org/apache/samza/sql/api/operators/OperatorSpec.java PRE-CREATION
> samza-sql-core/src/main/java/org/apache/samza/sql/api/operators/SimpleOperator.java PRE-CREATION
> samza-sql-core/src/main/java/org/apache/samza/sql/api/operators/SqlOperatorFactory.java PRE-CREATION
> samza-sql-core/src/main/java/org/apache/samza/sql/data/IncomingMessageTuple.java PRE-CREATION
> samza-sql-core/src/main/java/org/apache/samza/sql/data/avro/AvroData.java PRE-CREATION
> samza-sql-core/src/main/java/org/apache/samza/sql/data/avro/AvroSchema.java PRE-CREATION
> samza-sql-core/src/main/java/org/apache/samza/sql/data/serializers/SqlAvroSerde.java PRE-CREATION
> samza-sql-core/src/main/java/org/apache/samza/sql/data/serializers/SqlAvroSerdeFactory.java PRE-CREATION
> samza-sql-core/src/main/java/org/apache/samza/sql/data/serializers/SqlStringSerde.java PRE-CREATION
> samza-sql-core/src/main/java/org/apache/samza/sql/data/serializers/SqlStringSerdeFactory.java PRE-CREATION
> samza-sql-core/src/main/java/org/apache/samza/sql/data/string/StringData.java PRE-CREATION
> samza-sql-core/src/main/java/org/apache/samza/sql/data/string/StringSchema.java PRE-CREATION
> samza-sql-core/src/main/java/org/apache/samza/sql/operators/factory/NoopOperatorCallback.java PRE-CREATION
> samza-sql-core/src/main/java/org/apache/samza/sql/operators/factory/SimpleOperatorFactoryImpl.java PRE-CREATION
> samza-sql-core/src/main/java/org/apache/samza/sql/operators/factory/SimpleOperatorImpl.java PRE-CREATION
> samza-sql-core/src/main/java/org/apache/samza/sql/operators/factory/SimpleOperatorSpec.java PRE-CREATION
> samza-sql-core/src/main/java/org/apache/samza/sql/operators/factory/SimpleRouter.java PRE-CREATION
> samza-sql-core/src/main/java/org/apache/samza/sql/operators/join/StreamStreamJoin.java PRE-CREATION
> samza-sql-core/src/main/java/org/apache/samza/sql/operators/join/StreamStreamJoinSpec.java PRE-CREATION
> samza-sql-core/src/main/java/org/apache/samza/sql/operators/partition/PartitionOp.java PRE-CREATION
> samza-sql-core/src/main/java/org/apache/samza/sql/operators/partition/PartitionSpec.java PRE-CREATION
> samza-sql-core/src/main/java/org/apache/samza/sql/operators/window/BoundedTimeWindow.java PRE-CREATION
> samza-sql-core/src/main/java/org/apache/samza/sql/operators/window/WindowSpec.java PRE-CREATION
> samza-sql-core/src/main/java/org/apache/samza/sql/operators/window/WindowState.java PRE-CREATION
> samza-sql-core/src/main/java/org/apache/samza/sql/window/storage/OrderedStoreKey.java PRE-CREATION
> samza-sql-core/src/main/java/org/apache/samza/system/sql/LongOffset.java PRE-CREATION
> samza-sql-core/src/main/java/org/apache/samza/system/sql/Offset.java PRE-CREATION
> samza-sql-core/src/main/java/org/apache/samza/task/sql/RouterMessageCollector.java PRE-CREATION
> samza-sql-core/src/main/java/org/apache/samza/task/sql/SimpleMessageCollector.java PRE-CREATION
> samza-sql-core/src/test/java/org/apache/samza/sql/data/serializers/SqlAvroSerdeTest.java PRE-CREATION
> samza-sql-core/src/test/java/org/apache/samza/task/sql/RandomWindowOperatorTask.java PRE-CREATION
> samza-sql-core/src/test/java/org/apache/samza/task/sql/StreamSqlTask.java PRE-CREATION
> samza-sql-core/src/test/java/org/apache/samza/task/sql/UserCallbacksSqlTask.java PRE-CREATION
> settings.gradle 4c1aa107a11d413777e69bc4e48847b811aff7d2
>
> Diff: https://reviews.apache.org/r/47835/diff/
>
>
> Testing
> -------
>
> ./gradlew clean build
>
>
> Thanks,
>
> Yi Pan (Data Infrastructure)
>
>