You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@beam.apache.org by "Shahar Frank (JIRA)" <ji...@apache.org> on 2019/03/22 16:53:01 UTC

[jira] [Updated] (BEAM-6890) CassandraIO uses a non-vendored Guava import

     [ https://issues.apache.org/jira/browse/BEAM-6890?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Shahar Frank updated BEAM-6890:
-------------------------------
    Description: 
The class [CassandraIO.java|https://github.com/srfrnk/beam/blob/09d69c98ea6892651e31f864c865cc73b1d9e442/sdks/java/io/cassandra/src/main/java/org/apache/beam/sdk/io/cassandra/CassandraIO.java#L37] imports a Guava class but doesn't use vendored version.

I'm not sure but I think it should use the vendored version. Right?
So:
{code:java}
import com.google.common.base.Joiner
{code}

Should be:
{code:java}
import org.apache.beam.vendor.guava.v20_0.com.google.common.base.Joiner;
{code}

  was:
The class [link CassandraIO.java|https://github.com/srfrnk/beam/blob/09d69c98ea6892651e31f864c865cc73b1d9e442/sdks/java/io/cassandra/src/main/java/org/apache/beam/sdk/io/cassandra/CassandraIO.java#L37] imports a Guava class but doesn't use vendored version.

I'm not sure but I think it should use the vendored version. Right?
So:
{code:java}
import com.google.common.base.Joiner
{code}

Should be:
{code:java}
import org.apache.beam.vendor.guava.v20_0.com.google.common.base.Joiner;
{code}


> CassandraIO uses a non-vendored Guava import
> --------------------------------------------
>
>                 Key: BEAM-6890
>                 URL: https://issues.apache.org/jira/browse/BEAM-6890
>             Project: Beam
>          Issue Type: Bug
>          Components: io-java-cassandra
>            Reporter: Shahar Frank
>            Priority: Trivial
>
> The class [CassandraIO.java|https://github.com/srfrnk/beam/blob/09d69c98ea6892651e31f864c865cc73b1d9e442/sdks/java/io/cassandra/src/main/java/org/apache/beam/sdk/io/cassandra/CassandraIO.java#L37] imports a Guava class but doesn't use vendored version.
> I'm not sure but I think it should use the vendored version. Right?
> So:
> {code:java}
> import com.google.common.base.Joiner
> {code}
> Should be:
> {code:java}
> import org.apache.beam.vendor.guava.v20_0.com.google.common.base.Joiner;
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)