You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by gatorsmile <gi...@git.apache.org> on 2018/09/21 01:03:02 UTC

[GitHub] spark pull request #22461: [SPARK-25453][SQL][TEST] OracleIntegrationSuite I...

Github user gatorsmile commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22461#discussion_r219359638
  
    --- Diff: external/docker-integration-tests/src/test/scala/org/apache/spark/sql/jdbc/OracleIntegrationSuite.scala ---
    @@ -442,6 +442,8 @@ class OracleIntegrationSuite extends DockerJDBCIntegrationSuite with SharedSQLCo
           .option("lowerBound", "2018-07-06")
           .option("upperBound", "2018-07-20")
           .option("numPartitions", 3)
    +      .option("oracle.jdbc.mapDateToTimestamp", "false")
    --- End diff --
    
    This is good to know. Could you help update the doc and explain we can pass the options to the underlying JDBC and also give some examples?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org