You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "pjfanning (via GitHub)" <gi...@apache.org> on 2023/02/06 14:15:10 UTC
[GitHub] [incubator-pekko-connectors] pjfanning opened a new pull request, #26: change to pekko.connectors prefix for config names
pjfanning opened a new pull request, #26:
URL: https://github.com/apache/incubator-pekko-connectors/pull/26
* also removed replaced alpakka in package names because the text replace was easier this way
* org.apache.pekko package name move (instead of akka) would be better done when we uptake the pekko core libs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-connectors] pjfanning commented on pull request #26: uptake pekko jars, update package names and config names
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on PR #26:
URL: https://github.com/apache/incubator-pekko-connectors/pull/26#issuecomment-1467871413
@mdedetrich @nvollmar would either of you have time to review this? I know the diff is large. There are a lot of doc references to Akka/Alpakka but I want to leave them to a dedicated doc PR. The test failures match those that are broken in main branch already (see #41).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-connectors] pjfanning merged pull request #26: uptake pekko jars, update package names and config names
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning merged PR #26:
URL: https://github.com/apache/incubator-pekko-connectors/pull/26
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-connectors] pjfanning commented on pull request #26: change alpakka to pekko.connectors prefix for config names and package names
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on PR #26:
URL: https://github.com/apache/incubator-pekko-connectors/pull/26#issuecomment-1422613089
@mdedetrich I'm not looking for an immediate review of this PR - just some advice. Would it be better if I expand this PR to include the pekko core jar uptake and org.apache.pekko package renames than to wait for this PR to be reviewed on its own?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-connectors] nvollmar commented on a diff in pull request #26: uptake pekko jars, update package names and config names
Posted by "nvollmar (via GitHub)" <gi...@apache.org>.
nvollmar commented on code in PR #26:
URL: https://github.com/apache/incubator-pekko-connectors/pull/26#discussion_r1135415278
##########
google-common/src/main/scala/org/apache/pekko/stream/connectors/google/scaladsl/Google.scala:
##########
Review Comment:
Yep, since they are fairly light I'd not consider this an issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-connectors] nvollmar commented on a diff in pull request #26: uptake pekko jars, update package names and config names
Posted by "nvollmar (via GitHub)" <gi...@apache.org>.
nvollmar commented on code in PR #26:
URL: https://github.com/apache/incubator-pekko-connectors/pull/26#discussion_r1135410136
##########
google-common/src/main/scala/org/apache/pekko/stream/connectors/google/scaladsl/Google.scala:
##########
Review Comment:
This file was removed/re-added so we'll loose the history but since it is only an Interface it shouldn't be too much of a concern. AkkaStreamsRegistrar/PekkoStreamsRegistrar the same.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-connectors] pjfanning commented on a diff in pull request #26: uptake pekko jars, update package names and config names
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #26:
URL: https://github.com/apache/incubator-pekko-connectors/pull/26#discussion_r1135412939
##########
google-common/src/main/scala/org/apache/pekko/stream/connectors/google/scaladsl/Google.scala:
##########
Review Comment:
I did the same with this file as the other files - git has some heuristic to decide which moved files are moves with some edits as opposed to files that are deleted and new ones added in their place
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-connectors] mdedetrich commented on pull request #26: change alpakka to pekko.connectors prefix for config names and package names
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on PR #26:
URL: https://github.com/apache/incubator-pekko-connectors/pull/26#issuecomment-1422616293
I do think its preferable to include the updated packages in both pekko core and pekko http so that we only need a single PR to change the packages from `akka.stream.alpakka.*` to `org.apache.pekko.stream.connectors.*`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-connectors] nvollmar commented on a diff in pull request #26: uptake pekko jars, update package names and config names
Posted by "nvollmar (via GitHub)" <gi...@apache.org>.
nvollmar commented on code in PR #26:
URL: https://github.com/apache/incubator-pekko-connectors/pull/26#discussion_r1135410136
##########
google-common/src/main/scala/org/apache/pekko/stream/connectors/google/scaladsl/Google.scala:
##########
Review Comment:
This file was removed/re-added so we'll loose the history
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-connectors] mdedetrich commented on pull request #26: change alpakka to pekko.connectors prefix for config names and package names
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on PR #26:
URL: https://github.com/apache/incubator-pekko-connectors/pull/26#issuecomment-1422619490
Note that its likely that you will have to wait for the various renames to land in pekko-http in order to use the updated pekko core because of the usage of package private, this is the same issue that I had to deal with in pekko-http.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-connectors] nvollmar commented on a diff in pull request #26: uptake pekko jars, update package names and config names
Posted by "nvollmar (via GitHub)" <gi...@apache.org>.
nvollmar commented on code in PR #26:
URL: https://github.com/apache/incubator-pekko-connectors/pull/26#discussion_r1135410136
##########
google-common/src/main/scala/org/apache/pekko/stream/connectors/google/scaladsl/Google.scala:
##########
Review Comment:
This file was removed/re-added so we'll loose the history but since it is only an Interface it shouldn't be too much of a concern
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-connectors] pjfanning commented on pull request #26: change alpakka to pekko.connectors prefix for config names and package names
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on PR #26:
URL: https://github.com/apache/incubator-pekko-connectors/pull/26#issuecomment-1422649339
I remember now why I didn't want to upgrade the jars and package names yet - not only does this repo depend on akka-http but also akka-grpc. By the time, pekko-grpc is ready, this PR is likely to be conflicted and hard to fix up.
I'll leave this PR for now and may end up abandoning it. It may be easier just to start again in a few weeks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-connectors] nvollmar commented on pull request #26: uptake pekko jars, update package names and config names
Posted by "nvollmar (via GitHub)" <gi...@apache.org>.
nvollmar commented on PR #26:
URL: https://github.com/apache/incubator-pekko-connectors/pull/26#issuecomment-1467911497
Sure, waiting for this to continue switching pekko-persistence-cassandra :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org