You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jclouds.apache.org by Jeremy Daggett <no...@github.com> on 2013/06/05 16:44:34 UTC
[jclouds] Remove async interface support from OpenStack Cinder API
(#29)
You can merge this Pull Request by running:
git pull https://github.com/rackspace/jclouds 40-remove-async
Or you can view, comment on it, or merge it online at:
https://github.com/jclouds/jclouds/pull/29
-- Commit Summary --
* Remove async interface support from OpenStack Cinder API
-- File Changes --
M apis/openstack-cinder/src/main/java/org/jclouds/openstack/cinder/v1/CinderApiMetadata.java (28)
D apis/openstack-cinder/src/main/java/org/jclouds/openstack/cinder/v1/CinderAsyncApi.java (79)
R apis/openstack-cinder/src/main/java/org/jclouds/openstack/cinder/v1/config/CinderHttpApiModule.java (38)
M apis/openstack-cinder/src/main/java/org/jclouds/openstack/cinder/v1/features/SnapshotApi.java (59)
D apis/openstack-cinder/src/main/java/org/jclouds/openstack/cinder/v1/features/SnapshotAsyncApi.java (109)
M apis/openstack-cinder/src/main/java/org/jclouds/openstack/cinder/v1/features/VolumeApi.java (58)
D apis/openstack-cinder/src/main/java/org/jclouds/openstack/cinder/v1/features/VolumeAsyncApi.java (109)
M apis/openstack-cinder/src/main/java/org/jclouds/openstack/cinder/v1/features/VolumeTypeApi.java (30)
D apis/openstack-cinder/src/main/java/org/jclouds/openstack/cinder/v1/features/VolumeTypeAsyncApi.java (69)
M providers/rackspace-cloudblockstorage-uk/src/main/java/org/jclouds/rackspace/cloudblockstorage/uk/CloudBlockStorageUKProviderMetadata.java (8)
M providers/rackspace-cloudblockstorage-us/src/main/java/org/jclouds/rackspace/cloudblockstorage/us/CloudBlockStorageUSProviderMetadata.java (8)
-- Patch Links --
https://github.com/jclouds/jclouds/pull/29.patch
https://github.com/jclouds/jclouds/pull/29.diff
Re: [jclouds] Remove async interface support from OpenStack Cinder
API (#29)
Posted by BuildHive <no...@github.com>.
[jclouds ยป jclouds #74](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/74/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/29#issuecomment-18984684
Re: [jclouds] Remove async interface support from OpenStack Cinder
API (#29)
Posted by Andrew Gaul <no...@github.com>.
+1. @jdaggett please add the JIRA issue to future commits. @everett-toews can you just add it when cherry-picking this commit?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/29#issuecomment-19055407
Re: [jclouds] Remove async interface support from OpenStack Cinder
API (#29)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-java-7-pull-requests #434](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/434/) ABORTED
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/29#issuecomment-18984831
Re: [jclouds] Remove async interface support from OpenStack Cinder
API (#29)
Posted by Everett Toews <no...@github.com>.
Merged.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/29#issuecomment-19062847
Re: [jclouds] Remove async interface support from OpenStack Cinder
API (#29)
Posted by Zack Shoylev <no...@github.com>.
> public interface SnapshotApi {
> /**
> * Returns a summary list of Snapshots.
> *
> * @return The list of Snapshots
> */
> + @Named("snapshot:list")
> + @GET
> + @Path("/snapshots")
> + @SelectJson("snapshots")
> + @Consumes(MediaType.APPLICATION_JSON)
> + @Fallback(EmptyFluentIterableOnNotFoundOr404.class)
> FluentIterable<? extends Snapshot> list();
Might be simpler without the ? extends - I remember having a discussion with Adrian about it.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/29/files#r4546848
Re: [jclouds] Remove async interface support from OpenStack Cinder
API (#29)
Posted by Everett Toews <no...@github.com>.
You need to link to the JIRA issue in the PR description.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/29#issuecomment-19046605
Re: [jclouds] Remove async interface support from OpenStack Cinder
API (#29)
Posted by Jeremy Daggett <no...@github.com>.
> public interface SnapshotApi {
> /**
> * Returns a summary list of Snapshots.
> *
> * @return The list of Snapshots
> */
> + @Named("snapshot:list")
> + @GET
> + @Path("/snapshots")
> + @SelectJson("snapshots")
> + @Consumes(MediaType.APPLICATION_JSON)
> + @Fallback(EmptyFluentIterableOnNotFoundOr404.class)
> FluentIterable<? extends Snapshot> list();
I can strip that out on the next PR I submit for Nova related changes. ;)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/29/files#r4547096
Re: [jclouds] Remove async interface support from OpenStack Cinder
API (#29)
Posted by Richard Downer <no...@github.com>.
> public interface SnapshotApi {
> /**
> * Returns a summary list of Snapshots.
> *
> * @return The list of Snapshots
> */
> + @Named("snapshot:list")
> + @GET
> + @Path("/snapshots")
> + @SelectJson("snapshots")
> + @Consumes(MediaType.APPLICATION_JSON)
> + @Fallback(EmptyFluentIterableOnNotFoundOr404.class)
> FluentIterable<? extends Snapshot> list();
`? extends` makes it possible for providers to subclass the API and the domain model. API extensions are a first class concept in OpenStack, so I would like to see this API remain open for extensions :)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/29/files#r4547246
Re: [jclouds] Remove async interface support from OpenStack Cinder
API (#29)
Posted by Everett Toews <no...@github.com>.
Closed #29.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/29