You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "reuvenlax (via GitHub)" <gi...@apache.org> on 2023/05/16 05:13:05 UTC
[GitHub] [beam] reuvenlax opened a new pull request, #26707: Properly tag test so it is excluded on unsupported runners
reuvenlax opened a new pull request, #26707:
URL: https://github.com/apache/beam/pull/26707
R:@Abacn
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] Abacn commented on pull request #26707: Properly tag test so it is excluded on unsupported runners
Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn commented on PR #26707:
URL: https://github.com/apache/beam/pull/26707#issuecomment-1551864913
Confirmed that most validaterunners are back green. There is still one test suite flaky:
https://ci-beam.apache.org/view/PostCommit/job/beam_PostCommit_Java_VR_Dataflow_V2_Streaming/
it is passing on Dataflow V1 streaming test though:
https://ci-beam.apache.org/view/PostCommit/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Streaming/3675/testReport/org.apache.beam.sdk.transforms/ViewTest/testTriggeredLatestSingleton/
Is Dataflow V2 unsupported for this feature? CC: @reuvenlax @kennknowles
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kennknowles commented on pull request #26707: Properly tag test so it is excluded on unsupported runners
Posted by "kennknowles (via GitHub)" <gi...@apache.org>.
kennknowles commented on PR #26707:
URL: https://github.com/apache/beam/pull/26707#issuecomment-1553742461
I think that is right. This is not yet fixed for V2 @reuvenlax
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] tvalentyn commented on pull request #26707: Properly tag test so it is excluded on unsupported runners
Posted by "tvalentyn (via GitHub)" <gi...@apache.org>.
tvalentyn commented on PR #26707:
URL: https://github.com/apache/beam/pull/26707#issuecomment-1555326727
if this needs to be excluded from Dataflow V1 and Dataflow V2, wondering if this test should be disabled altogether temporarily?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kennknowles commented on pull request #26707: Properly tag test so it is excluded on unsupported runners
Posted by "kennknowles (via GitHub)" <gi...@apache.org>.
kennknowles commented on PR #26707:
URL: https://github.com/apache/beam/pull/26707#issuecomment-1555335525
It should work for v1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] reuvenlax commented on pull request #26707: Properly tag test so it is excluded on unsupported runners
Posted by "reuvenlax (via GitHub)" <gi...@apache.org>.
reuvenlax commented on PR #26707:
URL: https://github.com/apache/beam/pull/26707#issuecomment-1550026081
Run ULR Loopback ValidatesRunner
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] Abacn commented on pull request #26707: Properly tag test so it is excluded on unsupported runners
Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn commented on PR #26707:
URL: https://github.com/apache/beam/pull/26707#issuecomment-1549884001
Need to add the category here: https://github.com/apache/beam/blob/7a2c22d10e344b3e7e7741074027cc4fb8c13165/runners/portability/java/build.gradle#L151
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] Abacn commented on pull request #26707: Properly tag test so it is excluded on unsupported runners
Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn commented on PR #26707:
URL: https://github.com/apache/beam/pull/26707#issuecomment-1549737282
Run Java Flink PortableValidatesRunner Streaming
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] Abacn commented on pull request #26707: Properly tag test so it is excluded on unsupported runners
Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn commented on PR #26707:
URL: https://github.com/apache/beam/pull/26707#issuecomment-1549735127
Run Samza ValidatesRunner
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kennknowles commented on pull request #26707: Properly tag test so it is excluded on unsupported runners
Posted by "kennknowles (via GitHub)" <gi...@apache.org>.
kennknowles commented on PR #26707:
URL: https://github.com/apache/beam/pull/26707#issuecomment-1550053181
LGTM but do confirm that it fixes the broken suites
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #26707: Properly tag test so it is excluded on unsupported runners
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #26707:
URL: https://github.com/apache/beam/pull/26707#issuecomment-1549044871
Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`:
R: @Abacn for label java.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] Abacn commented on pull request #26707: Properly tag test so it is excluded on unsupported runners
Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn commented on PR #26707:
URL: https://github.com/apache/beam/pull/26707#issuecomment-1549735915
Run ULR Loopback ValidatesRunner
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] reuvenlax merged pull request #26707: Properly tag test so it is excluded on unsupported runners
Posted by "reuvenlax (via GitHub)" <gi...@apache.org>.
reuvenlax merged PR #26707:
URL: https://github.com/apache/beam/pull/26707
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] tvalentyn commented on pull request #26707: Properly tag test so it is excluded on unsupported runners
Posted by "tvalentyn (via GitHub)" <gi...@apache.org>.
tvalentyn commented on PR #26707:
URL: https://github.com/apache/beam/pull/26707#issuecomment-1555340264
ack, got it, we exclude in ULR but not V1. sent https://github.com/apache/beam/pull/26801
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org