You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/01/29 23:15:36 UTC

[GitHub] [superset] ktmud commented on pull request #12806: refactor: vectorise big integer to string type conversion

ktmud commented on pull request #12806:
URL: https://github.com/apache/superset/pull/12806#issuecomment-770099433


   I'm a huge fan of performance optimization PRs so I did some benchmarking and added one of my own optimizations:
   
   https://colab.research.google.com/drive/1M6wrvyIBIs079IC8RUGCT5I5zOxwOZ33#scrollTo=Fcie22gnZHqr
   
   Based on my tests, the original method is actually the fastest (the result is consistent on both my local machine and Google Collab). Could you share how you tested 3x performance gain with `Series.map`?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org