[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #6109: Enhance star-tree to skip matching-all predicate on non-star-tree dimension

[GitBox <gi...@apache.org>]

Jackie-Jiang commented on a change in pull request #6109:
URL: https://github.com/apache/incubator-pinot/pull/6109#discussion_r501410590



##########
File path: pinot-core/src/main/java/org/apache/pinot/core/startree/operator/StarTreeFilterOperator.java
##########
@@ -267,19 +206,19 @@ private StarTreeResult traverseStarTree() {
     // Use BFS to traverse the star tree
     Queue<SearchEntry> queue = new LinkedList<>();
     queue.add(new SearchEntry(starTreeRootNode, _predicateEvaluatorsMap.keySet(), _groupByColumns));
-    while (!queue.isEmpty()) {
-      SearchEntry searchEntry = queue.remove();
+    SearchEntry searchEntry;
+    while ((searchEntry = queue.poll()) != null) {

Review comment:
       The parentheses can not be removed, or it will try to assign the boolean value to `searchEntry`




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org