You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Madhan Neethiraj <ma...@apache.org> on 2015/07/08 21:41:10 UTC
Review Request 36325: RANGER-274: updated tagged-resource to
associate with component-service instead of tag-service
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36325/
-----------------------------------------------------------
Review request for ranger, Don Bosco Durai and Abhay Kulkarni.
Bugs: RANGER-274
https://issues.apache.org/jira/browse/RANGER-274
Repository: ranger
Description
-------
- updated tagged-resource to associate with component-service instead of tag-service
Diffs
-----
agents-common/src/main/java/org/apache/ranger/admin/client/RangerAdminClient.java b239b8e
agents-common/src/main/java/org/apache/ranger/admin/client/RangerAdminRESTClient.java 321e4b2
agents-common/src/main/java/org/apache/ranger/plugin/contextenricher/RangerAdminTagRetriever.java 3f10650
agents-common/src/main/java/org/apache/ranger/plugin/contextenricher/RangerTagFileStoreRetriever.java acaac75
agents-common/src/main/java/org/apache/ranger/plugin/contextenricher/RangerTagProvider.java 9c4f6f9
agents-common/src/main/java/org/apache/ranger/plugin/model/RangerTaggedResource.java b6927ad
agents-common/src/main/java/org/apache/ranger/plugin/model/RangerTaggedResourceKey.java 649c27d
agents-common/src/main/java/org/apache/ranger/plugin/store/TagPredicateUtil.java dda2779
agents-common/src/main/java/org/apache/ranger/plugin/store/TagStore.java 9200ee2
agents-common/src/main/java/org/apache/ranger/plugin/store/file/TagFileStore.java 6913212
agents-common/src/main/java/org/apache/ranger/plugin/util/SearchFilter.java 2585138
agents-common/src/main/java/org/apache/ranger/services/tag/RangerServiceTag.java c6dc334
knox-agent/src/main/java/org/apache/ranger/admin/client/RangerAdminJersey2RESTClient.java f5ac163
security-admin/src/main/java/org/apache/ranger/rest/TagREST.java 4d97826
security-admin/src/main/java/org/apache/ranger/rest/TagRESTConstants.java 27a4671
Diff: https://reviews.apache.org/r/36325/diff/
Testing
-------
Thanks,
Madhan Neethiraj
Re: Review Request 36325: RANGER-274: updated tagged-resource to
associate with component-service instead of tag-service
Posted by Abhay Kulkarni <ak...@hortonworks.com>.
Madhan,
If so, will RangerService class continue to have tagService member variable? If it will, then what significance will its value have?
Thanks!
-Abhay
From: Madhan Neethiraj <no...@reviews.apache.org>> on behalf of Madhan Neethiraj <ma...@apache.org>>
Reply-To: Madhan Neethiraj <ma...@apache.org>>
Date: Wednesday, July 8, 2015 at 6:55 PM
To: Don Bosco Durai <bo...@apache.org>>, Abhay Kulkarni <ak...@hortonworks.com>>
Cc: Madhan Neethiraj <ma...@apache.org>>, "dev@ranger.incubator.apache.org<ma...@ranger.incubator.apache.org>" <de...@ranger.incubator.apache.org>>
Subject: Re: Review Request 36325: RANGER-274: updated tagged-resource to associate with component-service instead of tag-service
This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36325/
On July 9th, 2015, 12:48 a.m. UTC, Abhay Kulkarni wrote:
agents-common/src/main/java/org/apache/ranger/admin/client/RangerAdminClient.java<https://reviews.apache.org/r/36325/diff/1/?file=1002540#file1002540line41>(Diff revision 1)
41
TagServiceResources getTaggedResources(String tagServiceName, String componentType, Long lastTimestamp) throws Exception;
41
TagServiceResources getTaggedResources(Long lastTimestamp) throws Exception;
Are we moving away from cluster-name, component-type grouping for tagged-resources? Is this the new model for tagging resources?
yes. A service is the resource-boundary in Ranger; it makes sense to attach tags for the resources with their corresponding service.
- Madhan
On July 8th, 2015, 7:41 p.m. UTC, Madhan Neethiraj wrote:
Review request for ranger, Don Bosco Durai and Abhay Kulkarni.
By Madhan Neethiraj.
Updated July 8, 2015, 7:41 p.m.
Bugs: RANGER-274<https://issues.apache.org/jira/browse/RANGER-274>
Repository: ranger
Description
* updated tagged-resource to associate with component-service instead of tag-service
Diffs
* agents-common/src/main/java/org/apache/ranger/admin/client/RangerAdminClient.java (b239b8e)
* agents-common/src/main/java/org/apache/ranger/admin/client/RangerAdminRESTClient.java (321e4b2)
* agents-common/src/main/java/org/apache/ranger/plugin/contextenricher/RangerAdminTagRetriever.java (3f10650)
* agents-common/src/main/java/org/apache/ranger/plugin/contextenricher/RangerTagFileStoreRetriever.java (acaac75)
* agents-common/src/main/java/org/apache/ranger/plugin/contextenricher/RangerTagProvider.java (9c4f6f9)
* agents-common/src/main/java/org/apache/ranger/plugin/model/RangerTaggedResource.java (b6927ad)
* agents-common/src/main/java/org/apache/ranger/plugin/model/RangerTaggedResourceKey.java (649c27d)
* agents-common/src/main/java/org/apache/ranger/plugin/store/TagPredicateUtil.java (dda2779)
* agents-common/src/main/java/org/apache/ranger/plugin/store/TagStore.java (9200ee2)
* agents-common/src/main/java/org/apache/ranger/plugin/store/file/TagFileStore.java (6913212)
* agents-common/src/main/java/org/apache/ranger/plugin/util/SearchFilter.java (2585138)
* agents-common/src/main/java/org/apache/ranger/services/tag/RangerServiceTag.java (c6dc334)
* knox-agent/src/main/java/org/apache/ranger/admin/client/RangerAdminJersey2RESTClient.java (f5ac163)
* security-admin/src/main/java/org/apache/ranger/rest/TagREST.java (4d97826)
* security-admin/src/main/java/org/apache/ranger/rest/TagRESTConstants.java (27a4671)
View Diff<https://reviews.apache.org/r/36325/diff/>
Re: Review Request 36325: RANGER-274: updated tagged-resource to
associate with component-service instead of tag-service
Posted by Madhan Neethiraj <ma...@apache.org>.
> On July 9, 2015, 12:48 a.m., Abhay Kulkarni wrote:
> > agents-common/src/main/java/org/apache/ranger/admin/client/RangerAdminClient.java, line 41
> > <https://reviews.apache.org/r/36325/diff/1/?file=1002540#file1002540line41>
> >
> > Are we moving away from cluster-name, component-type grouping for tagged-resources? Is this the new model for tagging resources?
yes. A service is the resource-boundary in Ranger; it makes sense to attach tags for the resources with their corresponding service.
- Madhan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36325/#review91032
-----------------------------------------------------------
On July 8, 2015, 7:41 p.m., Madhan Neethiraj wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36325/
> -----------------------------------------------------------
>
> (Updated July 8, 2015, 7:41 p.m.)
>
>
> Review request for ranger, Don Bosco Durai and Abhay Kulkarni.
>
>
> Bugs: RANGER-274
> https://issues.apache.org/jira/browse/RANGER-274
>
>
> Repository: ranger
>
>
> Description
> -------
>
> - updated tagged-resource to associate with component-service instead of tag-service
>
>
> Diffs
> -----
>
> agents-common/src/main/java/org/apache/ranger/admin/client/RangerAdminClient.java b239b8e
> agents-common/src/main/java/org/apache/ranger/admin/client/RangerAdminRESTClient.java 321e4b2
> agents-common/src/main/java/org/apache/ranger/plugin/contextenricher/RangerAdminTagRetriever.java 3f10650
> agents-common/src/main/java/org/apache/ranger/plugin/contextenricher/RangerTagFileStoreRetriever.java acaac75
> agents-common/src/main/java/org/apache/ranger/plugin/contextenricher/RangerTagProvider.java 9c4f6f9
> agents-common/src/main/java/org/apache/ranger/plugin/model/RangerTaggedResource.java b6927ad
> agents-common/src/main/java/org/apache/ranger/plugin/model/RangerTaggedResourceKey.java 649c27d
> agents-common/src/main/java/org/apache/ranger/plugin/store/TagPredicateUtil.java dda2779
> agents-common/src/main/java/org/apache/ranger/plugin/store/TagStore.java 9200ee2
> agents-common/src/main/java/org/apache/ranger/plugin/store/file/TagFileStore.java 6913212
> agents-common/src/main/java/org/apache/ranger/plugin/util/SearchFilter.java 2585138
> agents-common/src/main/java/org/apache/ranger/services/tag/RangerServiceTag.java c6dc334
> knox-agent/src/main/java/org/apache/ranger/admin/client/RangerAdminJersey2RESTClient.java f5ac163
> security-admin/src/main/java/org/apache/ranger/rest/TagREST.java 4d97826
> security-admin/src/main/java/org/apache/ranger/rest/TagRESTConstants.java 27a4671
>
> Diff: https://reviews.apache.org/r/36325/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Madhan Neethiraj
>
>
Re: Review Request 36325: RANGER-274: updated tagged-resource to
associate with component-service instead of tag-service
Posted by Abhay Kulkarni <ak...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36325/#review91032
-----------------------------------------------------------
agents-common/src/main/java/org/apache/ranger/admin/client/RangerAdminClient.java (line 41)
<https://reviews.apache.org/r/36325/#comment144261>
Are we moving away from cluster-name, component-type grouping for tagged-resources? Is this the new model for tagging resources?
agents-common/src/main/java/org/apache/ranger/plugin/model/RangerTaggedResource.java (line 123)
<https://reviews.apache.org/r/36325/#comment144260>
Indentation
- Abhay Kulkarni
On July 8, 2015, 7:41 p.m., Madhan Neethiraj wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36325/
> -----------------------------------------------------------
>
> (Updated July 8, 2015, 7:41 p.m.)
>
>
> Review request for ranger, Don Bosco Durai and Abhay Kulkarni.
>
>
> Bugs: RANGER-274
> https://issues.apache.org/jira/browse/RANGER-274
>
>
> Repository: ranger
>
>
> Description
> -------
>
> - updated tagged-resource to associate with component-service instead of tag-service
>
>
> Diffs
> -----
>
> agents-common/src/main/java/org/apache/ranger/admin/client/RangerAdminClient.java b239b8e
> agents-common/src/main/java/org/apache/ranger/admin/client/RangerAdminRESTClient.java 321e4b2
> agents-common/src/main/java/org/apache/ranger/plugin/contextenricher/RangerAdminTagRetriever.java 3f10650
> agents-common/src/main/java/org/apache/ranger/plugin/contextenricher/RangerTagFileStoreRetriever.java acaac75
> agents-common/src/main/java/org/apache/ranger/plugin/contextenricher/RangerTagProvider.java 9c4f6f9
> agents-common/src/main/java/org/apache/ranger/plugin/model/RangerTaggedResource.java b6927ad
> agents-common/src/main/java/org/apache/ranger/plugin/model/RangerTaggedResourceKey.java 649c27d
> agents-common/src/main/java/org/apache/ranger/plugin/store/TagPredicateUtil.java dda2779
> agents-common/src/main/java/org/apache/ranger/plugin/store/TagStore.java 9200ee2
> agents-common/src/main/java/org/apache/ranger/plugin/store/file/TagFileStore.java 6913212
> agents-common/src/main/java/org/apache/ranger/plugin/util/SearchFilter.java 2585138
> agents-common/src/main/java/org/apache/ranger/services/tag/RangerServiceTag.java c6dc334
> knox-agent/src/main/java/org/apache/ranger/admin/client/RangerAdminJersey2RESTClient.java f5ac163
> security-admin/src/main/java/org/apache/ranger/rest/TagREST.java 4d97826
> security-admin/src/main/java/org/apache/ranger/rest/TagRESTConstants.java 27a4671
>
> Diff: https://reviews.apache.org/r/36325/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Madhan Neethiraj
>
>