[GitHub] reddycharan commented on a change in pull request #1319: Issue 1316: A bookie with non-writable dirs should be able to start in readonly mode

[GitBox <gi...@apache.org>]

reddycharan commented on a change in pull request #1319:  Issue 1316: A bookie with non-writable dirs should be able to start in readonly mode
URL: https://github.com/apache/bookkeeper/pull/1319#discussion_r179677357
 
 

 ##########
 File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/EntryLogger.java
 ##########
 @@ -398,7 +401,11 @@ synchronized long getLeastUnflushedLogId() {
     }
 
     synchronized long getCurrentLogId() {
-        return logChannel.getLogId();
+        return currentLogId;
+    }
+
+    BufferedLogChannel getCurrentLogChannel() {
 
 Review comment:
   it seems it is being just used for testing purpose, I'm not sure if it is needed. Cann't we rely on just getCurrentLogId? Also, iirc we discussed that entrylogger is exposing more than it is supposed to. For my EntryLogPerLedger, we already compromised on getCurrentLogId (in entrylogperledger case we decided to return some constant value) and I'm not sure if one more such method is ok.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services