[jira] [Commented] (THRIFT-948) SSL socket support for PHP

["Nicholas Telford (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/THRIFT-948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13018416#comment-13018416 ] 

Nicholas Telford commented on THRIFT-948:
-----------------------------------------

It looks as though PHP's TSocket implementation should permit the use of SSL/TLS connections by simply prepending 'ssl://' or 'tls://' to the hostname.

{code}
$host = $secure ? 'ssl://' . $host : $host;
$socket = new TScoket($host, $port);
{code}

Given PHP's support for different protocols in it's own "streams" API, it makes no sense (to be at least) to do a ton of legwork to support them. At most we could expose a protocol parameter for TSocket that defaults to vanilla TCP.

> SSL socket support for PHP
> --------------------------
>
>                 Key: THRIFT-948
>                 URL: https://issues.apache.org/jira/browse/THRIFT-948
>             Project: Thrift
>          Issue Type: New Feature
>          Components: PHP - Library
>            Reporter: David Reiss
>            Priority: Minor
>         Attachments: php-ssl.patch
>
>
> This had some basic testing, but was never used in production.  If someone wants to implement this feature, they can start with this patch.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira