You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2021/02/16 06:45:54 UTC
[GitHub] [mynewt-nimble] KKopyscinski opened a new pull request #913: Optimize host size
KKopyscinski opened a new pull request #913:
URL: https://github.com/apache/mynewt-nimble/pull/913
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-nimble] apache-mynewt-bot removed a comment on pull request #913: Optimize host size
Posted by GitBox <gi...@apache.org>.
apache-mynewt-bot removed a comment on pull request #913:
URL: https://github.com/apache/mynewt-nimble/pull/913#issuecomment-779682021
<!-- style-bot -->
## Style check summary
### Our coding style is [here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)
#### nimble/host/services/gap/src/ble_svc_gap.c
<details>
```diff
@@ -38,7 +38,7 @@
static ble_svc_gap_chr_changed_fn *ble_svc_gap_chr_changed_cb_fn;
static char ble_svc_gap_name[BLE_SVC_GAP_NAME_MAX_LEN + 1] =
- MYNEWT_VAL(BLE_SVC_GAP_DEVICE_NAME);
+ MYNEWT_VAL(BLE_SVC_GAP_DEVICE_NAME);
static uint16_t ble_svc_gap_appearance = MYNEWT_VAL(BLE_SVC_GAP_APPEARANCE);
#if NIMBLE_BLE_CONNECT
```
</details>
#### nimble/host/src/ble_att_clt.c
<details>
```diff
@@ -28,8 +28,8 @@
#if NIMBLE_BLE_CONNECT
/*****************************************************************************
- * $error response *
- *****************************************************************************/
+* $error response *
+*****************************************************************************/
int
ble_att_clt_rx_error(uint16_t conn_handle, struct os_mbuf **rxom)
```
</details>
#### nimble/host/src/ble_gap.c
<details>
```diff
@@ -386,8 +386,8 @@
#endif
/*****************************************************************************
- * $snapshot *
- *****************************************************************************/
+* $snapshot *
+*****************************************************************************/
#if NIMBLE_BLE_CONNECT
static void
@@ -620,7 +620,7 @@
int
ble_gap_set_prefered_le_phy(uint16_t conn_handle, uint8_t tx_phys_mask,
- uint8_t rx_phys_mask, uint16_t phy_opts)
+ uint8_t rx_phys_mask, uint16_t phy_opts)
{
#if NIMBLE_BLE_CONNECT
struct ble_hci_le_set_phy_cp cmd;
@@ -5147,8 +5145,8 @@
}
/*****************************************************************************
- * $cancel *
- *****************************************************************************/
+* $cancel *
+*****************************************************************************/
#if NIMBLE_BLE_CONNECT
static int
```
</details>
#### nimble/host/src/ble_gattc.c
<details>
```diff
@@ -62,8 +62,8 @@
#if NIMBLE_BLE_CONNECT
/*****************************************************************************
- * $definitions / declarations *
- *****************************************************************************/
+* $definitions / declarations *
+*****************************************************************************/
/**
* The maximum time to wait for a single ATT response. The spec defines this
```
</details>
#### nimble/host/src/ble_gatts_lcl.c
<details>
```diff
@@ -26,7 +26,7 @@
#if NIMBLE_BLE_CONNECT
static const ble_uuid_t *uuid_ccc =
- BLE_UUID16_DECLARE(BLE_GATT_DSC_CLT_CFG_UUID16);
+ BLE_UUID16_DECLARE(BLE_GATT_DSC_CLT_CFG_UUID16);
static const char * const ble_gatt_chr_f_names[] = {
"BROADCAST",
```
</details>
#### nimble/host/src/ble_l2cap_sig.c
<details>
```diff
@@ -50,8 +50,8 @@
#if NIMBLE_BLE_CONNECT
/*****************************************************************************
- * $definitions / declarations *
- *****************************************************************************/
+* $definitions / declarations *
+*****************************************************************************/
#define BLE_L2CAP_SIG_UNRESPONSIVE_TIMEOUT 30000 /* Milliseconds. */
```
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-nimble] KKopyscinski commented on pull request #913: Optimize host size
Posted by GitBox <gi...@apache.org>.
KKopyscinski commented on pull request #913:
URL: https://github.com/apache/mynewt-nimble/pull/913#issuecomment-781287605
Code size improvement :
| app | size before - FLASH | size before - RAM | size after - FLASH | size after - RAM | delta (FLASH) | delta (RAM) |
| --- | --- | --- | --- | --- | --- | ---|
| advertiser | 27961 | 3507 | 9111 | 1265 | 18850 | 2242 |
| scanner | 42284 | 4171 | 10579 | 2014 | 31705 | 2133 |
| blecent | 48557 | 4319 | 48453 | 4319 | 104 | 0 |
| bleperph | 45596 | 4552 | 45392 | 4552 | 204 | 0 |
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-nimble] apache-mynewt-bot removed a comment on pull request #913: Optimize host size
Posted by GitBox <gi...@apache.org>.
apache-mynewt-bot removed a comment on pull request #913:
URL: https://github.com/apache/mynewt-nimble/pull/913#issuecomment-779809233
<!-- style-bot -->
## Style check summary
### Our coding style is [here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)
#### nimble/host/services/gap/src/ble_svc_gap.c
<details>
```diff
@@ -38,7 +38,7 @@
static ble_svc_gap_chr_changed_fn *ble_svc_gap_chr_changed_cb_fn;
static char ble_svc_gap_name[BLE_SVC_GAP_NAME_MAX_LEN + 1] =
- MYNEWT_VAL(BLE_SVC_GAP_DEVICE_NAME);
+ MYNEWT_VAL(BLE_SVC_GAP_DEVICE_NAME);
static uint16_t ble_svc_gap_appearance = MYNEWT_VAL(BLE_SVC_GAP_APPEARANCE);
#if NIMBLE_BLE_CONNECT
```
</details>
#### nimble/host/src/ble_att_clt.c
<details>
```diff
@@ -28,8 +28,8 @@
#if NIMBLE_BLE_CONNECT
/*****************************************************************************
- * $error response *
- *****************************************************************************/
+* $error response *
+*****************************************************************************/
int
ble_att_clt_rx_error(uint16_t conn_handle, struct os_mbuf **rxom)
```
</details>
#### nimble/host/src/ble_gap.c
<details>
```diff
@@ -386,8 +386,8 @@
#endif
/*****************************************************************************
- * $snapshot *
- *****************************************************************************/
+* $snapshot *
+*****************************************************************************/
#if NIMBLE_BLE_CONNECT
static void
@@ -620,7 +620,7 @@
int
ble_gap_set_prefered_le_phy(uint16_t conn_handle, uint8_t tx_phys_mask,
- uint8_t rx_phys_mask, uint16_t phy_opts)
+ uint8_t rx_phys_mask, uint16_t phy_opts)
{
#if NIMBLE_BLE_CONNECT
struct ble_hci_le_set_phy_cp cmd;
@@ -5141,8 +5139,8 @@
}
/*****************************************************************************
- * $cancel *
- *****************************************************************************/
+* $cancel *
+*****************************************************************************/
#if NIMBLE_BLE_CONNECT
static int
```
</details>
#### nimble/host/src/ble_gattc.c
<details>
```diff
@@ -62,8 +62,8 @@
#if NIMBLE_BLE_CONNECT
/*****************************************************************************
- * $definitions / declarations *
- *****************************************************************************/
+* $definitions / declarations *
+*****************************************************************************/
/**
* The maximum time to wait for a single ATT response. The spec defines this
```
</details>
#### nimble/host/src/ble_gatts_lcl.c
<details>
```diff
@@ -26,7 +26,7 @@
#if NIMBLE_BLE_CONNECT
static const ble_uuid_t *uuid_ccc =
- BLE_UUID16_DECLARE(BLE_GATT_DSC_CLT_CFG_UUID16);
+ BLE_UUID16_DECLARE(BLE_GATT_DSC_CLT_CFG_UUID16);
static const char * const ble_gatt_chr_f_names[] = {
"BROADCAST",
```
</details>
#### nimble/host/src/ble_l2cap_sig.c
<details>
```diff
@@ -50,8 +50,8 @@
#if NIMBLE_BLE_CONNECT
/*****************************************************************************
- * $definitions / declarations *
- *****************************************************************************/
+* $definitions / declarations *
+*****************************************************************************/
#define BLE_L2CAP_SIG_UNRESPONSIVE_TIMEOUT 30000 /* Milliseconds. */
```
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-nimble] KKopyscinski merged pull request #913: Optimize host size
Posted by GitBox <gi...@apache.org>.
KKopyscinski merged pull request #913:
URL: https://github.com/apache/mynewt-nimble/pull/913
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-nimble] apache-mynewt-bot removed a comment on pull request #913: Optimize host size
Posted by GitBox <gi...@apache.org>.
apache-mynewt-bot removed a comment on pull request #913:
URL: https://github.com/apache/mynewt-nimble/pull/913#issuecomment-779625543
<!-- style-bot -->
## Style check summary
### Our coding style is [here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)
#### nimble/host/services/gap/src/ble_svc_gap.c
<details>
```diff
@@ -38,7 +38,7 @@
static ble_svc_gap_chr_changed_fn *ble_svc_gap_chr_changed_cb_fn;
static char ble_svc_gap_name[BLE_SVC_GAP_NAME_MAX_LEN + 1] =
- MYNEWT_VAL(BLE_SVC_GAP_DEVICE_NAME);
+ MYNEWT_VAL(BLE_SVC_GAP_DEVICE_NAME);
static uint16_t ble_svc_gap_appearance = MYNEWT_VAL(BLE_SVC_GAP_APPEARANCE);
#if NIMBLE_BLE_CONNECT
```
</details>
#### nimble/host/src/ble_att_clt.c
<details>
```diff
@@ -28,8 +28,8 @@
#if NIMBLE_BLE_CONNECT
/*****************************************************************************
- * $error response *
- *****************************************************************************/
+* $error response *
+*****************************************************************************/
int
ble_att_clt_rx_error(uint16_t conn_handle, struct os_mbuf **rxom)
```
</details>
#### nimble/host/src/ble_gap.c
<details>
```diff
@@ -386,8 +386,8 @@
#endif
/*****************************************************************************
- * $snapshot *
- *****************************************************************************/
+* $snapshot *
+*****************************************************************************/
#if NIMBLE_BLE_CONNECT
static void
@@ -620,7 +620,7 @@
int
ble_gap_set_prefered_le_phy(uint16_t conn_handle, uint8_t tx_phys_mask,
- uint8_t rx_phys_mask, uint16_t phy_opts)
+ uint8_t rx_phys_mask, uint16_t phy_opts)
{
#if NIMBLE_BLE_CONNECT
struct ble_hci_le_set_phy_cp cmd;
@@ -5147,8 +5145,8 @@
}
/*****************************************************************************
- * $cancel *
- *****************************************************************************/
+* $cancel *
+*****************************************************************************/
#if NIMBLE_BLE_CONNECT
static int
```
</details>
#### nimble/host/src/ble_gattc.c
<details>
```diff
@@ -62,8 +62,8 @@
#if NIMBLE_BLE_CONNECT
/*****************************************************************************
- * $definitions / declarations *
- *****************************************************************************/
+* $definitions / declarations *
+*****************************************************************************/
/**
* The maximum time to wait for a single ATT response. The spec defines this
```
</details>
#### nimble/host/src/ble_gatts_lcl.c
<details>
```diff
@@ -26,7 +26,7 @@
#if NIMBLE_BLE_CONNECT
static const ble_uuid_t *uuid_ccc =
- BLE_UUID16_DECLARE(BLE_GATT_DSC_CLT_CFG_UUID16);
+ BLE_UUID16_DECLARE(BLE_GATT_DSC_CLT_CFG_UUID16);
static const char * const ble_gatt_chr_f_names[] = {
"BROADCAST",
```
</details>
#### nimble/host/src/ble_l2cap_sig.c
<details>
```diff
@@ -50,8 +50,8 @@
#if NIMBLE_BLE_CONNECT
/*****************************************************************************
- * $definitions / declarations *
- *****************************************************************************/
+* $definitions / declarations *
+*****************************************************************************/
#define BLE_L2CAP_SIG_UNRESPONSIVE_TIMEOUT 30000 /* Milliseconds. */
```
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #913: Optimize host size
Posted by GitBox <gi...@apache.org>.
apache-mynewt-bot commented on pull request #913:
URL: https://github.com/apache/mynewt-nimble/pull/913#issuecomment-779641285
<!-- style-bot -->
## Style check summary
### Our coding style is [here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)
#### nimble/host/services/gap/src/ble_svc_gap.c
<details>
```diff
@@ -38,7 +38,7 @@
static ble_svc_gap_chr_changed_fn *ble_svc_gap_chr_changed_cb_fn;
static char ble_svc_gap_name[BLE_SVC_GAP_NAME_MAX_LEN + 1] =
- MYNEWT_VAL(BLE_SVC_GAP_DEVICE_NAME);
+ MYNEWT_VAL(BLE_SVC_GAP_DEVICE_NAME);
static uint16_t ble_svc_gap_appearance = MYNEWT_VAL(BLE_SVC_GAP_APPEARANCE);
#if NIMBLE_BLE_CONNECT
```
</details>
#### nimble/host/src/ble_att_clt.c
<details>
```diff
@@ -28,8 +28,8 @@
#if NIMBLE_BLE_CONNECT
/*****************************************************************************
- * $error response *
- *****************************************************************************/
+* $error response *
+*****************************************************************************/
int
ble_att_clt_rx_error(uint16_t conn_handle, struct os_mbuf **rxom)
```
</details>
#### nimble/host/src/ble_gap.c
<details>
```diff
@@ -386,8 +386,8 @@
#endif
/*****************************************************************************
- * $snapshot *
- *****************************************************************************/
+* $snapshot *
+*****************************************************************************/
#if NIMBLE_BLE_CONNECT
static void
@@ -620,7 +620,7 @@
int
ble_gap_set_prefered_le_phy(uint16_t conn_handle, uint8_t tx_phys_mask,
- uint8_t rx_phys_mask, uint16_t phy_opts)
+ uint8_t rx_phys_mask, uint16_t phy_opts)
{
#if NIMBLE_BLE_CONNECT
struct ble_hci_le_set_phy_cp cmd;
@@ -5147,8 +5145,8 @@
}
/*****************************************************************************
- * $cancel *
- *****************************************************************************/
+* $cancel *
+*****************************************************************************/
#if NIMBLE_BLE_CONNECT
static int
```
</details>
#### nimble/host/src/ble_gattc.c
<details>
```diff
@@ -62,8 +62,8 @@
#if NIMBLE_BLE_CONNECT
/*****************************************************************************
- * $definitions / declarations *
- *****************************************************************************/
+* $definitions / declarations *
+*****************************************************************************/
/**
* The maximum time to wait for a single ATT response. The spec defines this
```
</details>
#### nimble/host/src/ble_gatts_lcl.c
<details>
```diff
@@ -26,7 +26,7 @@
#if NIMBLE_BLE_CONNECT
static const ble_uuid_t *uuid_ccc =
- BLE_UUID16_DECLARE(BLE_GATT_DSC_CLT_CFG_UUID16);
+ BLE_UUID16_DECLARE(BLE_GATT_DSC_CLT_CFG_UUID16);
static const char * const ble_gatt_chr_f_names[] = {
"BROADCAST",
```
</details>
#### nimble/host/src/ble_l2cap_sig.c
<details>
```diff
@@ -50,8 +50,8 @@
#if NIMBLE_BLE_CONNECT
/*****************************************************************************
- * $definitions / declarations *
- *****************************************************************************/
+* $definitions / declarations *
+*****************************************************************************/
#define BLE_L2CAP_SIG_UNRESPONSIVE_TIMEOUT 30000 /* Milliseconds. */
```
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #913: Optimize host size
Posted by GitBox <gi...@apache.org>.
apache-mynewt-bot commented on pull request #913:
URL: https://github.com/apache/mynewt-nimble/pull/913#issuecomment-779785424
<!-- style-bot -->
## Style check summary
### Our coding style is [here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)
#### nimble/host/services/gap/src/ble_svc_gap.c
<details>
```diff
@@ -38,7 +38,7 @@
static ble_svc_gap_chr_changed_fn *ble_svc_gap_chr_changed_cb_fn;
static char ble_svc_gap_name[BLE_SVC_GAP_NAME_MAX_LEN + 1] =
- MYNEWT_VAL(BLE_SVC_GAP_DEVICE_NAME);
+ MYNEWT_VAL(BLE_SVC_GAP_DEVICE_NAME);
static uint16_t ble_svc_gap_appearance = MYNEWT_VAL(BLE_SVC_GAP_APPEARANCE);
#if NIMBLE_BLE_CONNECT
```
</details>
#### nimble/host/src/ble_att_clt.c
<details>
```diff
@@ -28,8 +28,8 @@
#if NIMBLE_BLE_CONNECT
/*****************************************************************************
- * $error response *
- *****************************************************************************/
+* $error response *
+*****************************************************************************/
int
ble_att_clt_rx_error(uint16_t conn_handle, struct os_mbuf **rxom)
```
</details>
#### nimble/host/src/ble_gap.c
<details>
```diff
@@ -386,8 +386,8 @@
#endif
/*****************************************************************************
- * $snapshot *
- *****************************************************************************/
+* $snapshot *
+*****************************************************************************/
#if NIMBLE_BLE_CONNECT
static void
@@ -620,7 +620,7 @@
int
ble_gap_set_prefered_le_phy(uint16_t conn_handle, uint8_t tx_phys_mask,
- uint8_t rx_phys_mask, uint16_t phy_opts)
+ uint8_t rx_phys_mask, uint16_t phy_opts)
{
#if NIMBLE_BLE_CONNECT
struct ble_hci_le_set_phy_cp cmd;
@@ -5147,8 +5145,8 @@
}
/*****************************************************************************
- * $cancel *
- *****************************************************************************/
+* $cancel *
+*****************************************************************************/
#if NIMBLE_BLE_CONNECT
static int
```
</details>
#### nimble/host/src/ble_gattc.c
<details>
```diff
@@ -62,8 +62,8 @@
#if NIMBLE_BLE_CONNECT
/*****************************************************************************
- * $definitions / declarations *
- *****************************************************************************/
+* $definitions / declarations *
+*****************************************************************************/
/**
* The maximum time to wait for a single ATT response. The spec defines this
```
</details>
#### nimble/host/src/ble_gatts_lcl.c
<details>
```diff
@@ -26,7 +26,7 @@
#if NIMBLE_BLE_CONNECT
static const ble_uuid_t *uuid_ccc =
- BLE_UUID16_DECLARE(BLE_GATT_DSC_CLT_CFG_UUID16);
+ BLE_UUID16_DECLARE(BLE_GATT_DSC_CLT_CFG_UUID16);
static const char * const ble_gatt_chr_f_names[] = {
"BROADCAST",
```
</details>
#### nimble/host/src/ble_l2cap_sig.c
<details>
```diff
@@ -50,8 +50,8 @@
#if NIMBLE_BLE_CONNECT
/*****************************************************************************
- * $definitions / declarations *
- *****************************************************************************/
+* $definitions / declarations *
+*****************************************************************************/
#define BLE_L2CAP_SIG_UNRESPONSIVE_TIMEOUT 30000 /* Milliseconds. */
```
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-nimble] apache-mynewt-bot removed a comment on pull request #913: Optimize host size
Posted by GitBox <gi...@apache.org>.
apache-mynewt-bot removed a comment on pull request #913:
URL: https://github.com/apache/mynewt-nimble/pull/913#issuecomment-779785424
<!-- style-bot -->
## Style check summary
### Our coding style is [here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)
#### nimble/host/services/gap/src/ble_svc_gap.c
<details>
```diff
@@ -38,7 +38,7 @@
static ble_svc_gap_chr_changed_fn *ble_svc_gap_chr_changed_cb_fn;
static char ble_svc_gap_name[BLE_SVC_GAP_NAME_MAX_LEN + 1] =
- MYNEWT_VAL(BLE_SVC_GAP_DEVICE_NAME);
+ MYNEWT_VAL(BLE_SVC_GAP_DEVICE_NAME);
static uint16_t ble_svc_gap_appearance = MYNEWT_VAL(BLE_SVC_GAP_APPEARANCE);
#if NIMBLE_BLE_CONNECT
```
</details>
#### nimble/host/src/ble_att_clt.c
<details>
```diff
@@ -28,8 +28,8 @@
#if NIMBLE_BLE_CONNECT
/*****************************************************************************
- * $error response *
- *****************************************************************************/
+* $error response *
+*****************************************************************************/
int
ble_att_clt_rx_error(uint16_t conn_handle, struct os_mbuf **rxom)
```
</details>
#### nimble/host/src/ble_gap.c
<details>
```diff
@@ -386,8 +386,8 @@
#endif
/*****************************************************************************
- * $snapshot *
- *****************************************************************************/
+* $snapshot *
+*****************************************************************************/
#if NIMBLE_BLE_CONNECT
static void
@@ -620,7 +620,7 @@
int
ble_gap_set_prefered_le_phy(uint16_t conn_handle, uint8_t tx_phys_mask,
- uint8_t rx_phys_mask, uint16_t phy_opts)
+ uint8_t rx_phys_mask, uint16_t phy_opts)
{
#if NIMBLE_BLE_CONNECT
struct ble_hci_le_set_phy_cp cmd;
@@ -5147,8 +5145,8 @@
}
/*****************************************************************************
- * $cancel *
- *****************************************************************************/
+* $cancel *
+*****************************************************************************/
#if NIMBLE_BLE_CONNECT
static int
```
</details>
#### nimble/host/src/ble_gattc.c
<details>
```diff
@@ -62,8 +62,8 @@
#if NIMBLE_BLE_CONNECT
/*****************************************************************************
- * $definitions / declarations *
- *****************************************************************************/
+* $definitions / declarations *
+*****************************************************************************/
/**
* The maximum time to wait for a single ATT response. The spec defines this
```
</details>
#### nimble/host/src/ble_gatts_lcl.c
<details>
```diff
@@ -26,7 +26,7 @@
#if NIMBLE_BLE_CONNECT
static const ble_uuid_t *uuid_ccc =
- BLE_UUID16_DECLARE(BLE_GATT_DSC_CLT_CFG_UUID16);
+ BLE_UUID16_DECLARE(BLE_GATT_DSC_CLT_CFG_UUID16);
static const char * const ble_gatt_chr_f_names[] = {
"BROADCAST",
```
</details>
#### nimble/host/src/ble_l2cap_sig.c
<details>
```diff
@@ -50,8 +50,8 @@
#if NIMBLE_BLE_CONNECT
/*****************************************************************************
- * $definitions / declarations *
- *****************************************************************************/
+* $definitions / declarations *
+*****************************************************************************/
#define BLE_L2CAP_SIG_UNRESPONSIVE_TIMEOUT 30000 /* Milliseconds. */
```
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-nimble] apache-mynewt-bot removed a comment on pull request #913: Optimize host size
Posted by GitBox <gi...@apache.org>.
apache-mynewt-bot removed a comment on pull request #913:
URL: https://github.com/apache/mynewt-nimble/pull/913#issuecomment-779641285
<!-- style-bot -->
## Style check summary
### Our coding style is [here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)
#### nimble/host/services/gap/src/ble_svc_gap.c
<details>
```diff
@@ -38,7 +38,7 @@
static ble_svc_gap_chr_changed_fn *ble_svc_gap_chr_changed_cb_fn;
static char ble_svc_gap_name[BLE_SVC_GAP_NAME_MAX_LEN + 1] =
- MYNEWT_VAL(BLE_SVC_GAP_DEVICE_NAME);
+ MYNEWT_VAL(BLE_SVC_GAP_DEVICE_NAME);
static uint16_t ble_svc_gap_appearance = MYNEWT_VAL(BLE_SVC_GAP_APPEARANCE);
#if NIMBLE_BLE_CONNECT
```
</details>
#### nimble/host/src/ble_att_clt.c
<details>
```diff
@@ -28,8 +28,8 @@
#if NIMBLE_BLE_CONNECT
/*****************************************************************************
- * $error response *
- *****************************************************************************/
+* $error response *
+*****************************************************************************/
int
ble_att_clt_rx_error(uint16_t conn_handle, struct os_mbuf **rxom)
```
</details>
#### nimble/host/src/ble_gap.c
<details>
```diff
@@ -386,8 +386,8 @@
#endif
/*****************************************************************************
- * $snapshot *
- *****************************************************************************/
+* $snapshot *
+*****************************************************************************/
#if NIMBLE_BLE_CONNECT
static void
@@ -620,7 +620,7 @@
int
ble_gap_set_prefered_le_phy(uint16_t conn_handle, uint8_t tx_phys_mask,
- uint8_t rx_phys_mask, uint16_t phy_opts)
+ uint8_t rx_phys_mask, uint16_t phy_opts)
{
#if NIMBLE_BLE_CONNECT
struct ble_hci_le_set_phy_cp cmd;
@@ -5147,8 +5145,8 @@
}
/*****************************************************************************
- * $cancel *
- *****************************************************************************/
+* $cancel *
+*****************************************************************************/
#if NIMBLE_BLE_CONNECT
static int
```
</details>
#### nimble/host/src/ble_gattc.c
<details>
```diff
@@ -62,8 +62,8 @@
#if NIMBLE_BLE_CONNECT
/*****************************************************************************
- * $definitions / declarations *
- *****************************************************************************/
+* $definitions / declarations *
+*****************************************************************************/
/**
* The maximum time to wait for a single ATT response. The spec defines this
```
</details>
#### nimble/host/src/ble_gatts_lcl.c
<details>
```diff
@@ -26,7 +26,7 @@
#if NIMBLE_BLE_CONNECT
static const ble_uuid_t *uuid_ccc =
- BLE_UUID16_DECLARE(BLE_GATT_DSC_CLT_CFG_UUID16);
+ BLE_UUID16_DECLARE(BLE_GATT_DSC_CLT_CFG_UUID16);
static const char * const ble_gatt_chr_f_names[] = {
"BROADCAST",
```
</details>
#### nimble/host/src/ble_l2cap_sig.c
<details>
```diff
@@ -50,8 +50,8 @@
#if NIMBLE_BLE_CONNECT
/*****************************************************************************
- * $definitions / declarations *
- *****************************************************************************/
+* $definitions / declarations *
+*****************************************************************************/
#define BLE_L2CAP_SIG_UNRESPONSIVE_TIMEOUT 30000 /* Milliseconds. */
```
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #913: Optimize host size
Posted by GitBox <gi...@apache.org>.
apache-mynewt-bot commented on pull request #913:
URL: https://github.com/apache/mynewt-nimble/pull/913#issuecomment-779812240
<!-- style-bot -->
## Style check summary
### Our coding style is [here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)
#### nimble/host/services/gap/src/ble_svc_gap.c
<details>
```diff
@@ -38,7 +38,7 @@
static ble_svc_gap_chr_changed_fn *ble_svc_gap_chr_changed_cb_fn;
static char ble_svc_gap_name[BLE_SVC_GAP_NAME_MAX_LEN + 1] =
- MYNEWT_VAL(BLE_SVC_GAP_DEVICE_NAME);
+ MYNEWT_VAL(BLE_SVC_GAP_DEVICE_NAME);
static uint16_t ble_svc_gap_appearance = MYNEWT_VAL(BLE_SVC_GAP_APPEARANCE);
#if NIMBLE_BLE_CONNECT
```
</details>
#### nimble/host/src/ble_att_clt.c
<details>
```diff
@@ -28,8 +28,8 @@
#if NIMBLE_BLE_CONNECT
/*****************************************************************************
- * $error response *
- *****************************************************************************/
+* $error response *
+*****************************************************************************/
int
ble_att_clt_rx_error(uint16_t conn_handle, struct os_mbuf **rxom)
```
</details>
#### nimble/host/src/ble_gap.c
<details>
```diff
@@ -386,8 +386,8 @@
#endif
/*****************************************************************************
- * $snapshot *
- *****************************************************************************/
+* $snapshot *
+*****************************************************************************/
#if NIMBLE_BLE_CONNECT
static void
@@ -620,7 +620,7 @@
int
ble_gap_set_prefered_le_phy(uint16_t conn_handle, uint8_t tx_phys_mask,
- uint8_t rx_phys_mask, uint16_t phy_opts)
+ uint8_t rx_phys_mask, uint16_t phy_opts)
{
#if NIMBLE_BLE_CONNECT
struct ble_hci_le_set_phy_cp cmd;
@@ -5147,8 +5145,8 @@
}
/*****************************************************************************
- * $cancel *
- *****************************************************************************/
+* $cancel *
+*****************************************************************************/
#if NIMBLE_BLE_CONNECT
static int
```
</details>
#### nimble/host/src/ble_gattc.c
<details>
```diff
@@ -62,8 +62,8 @@
#if NIMBLE_BLE_CONNECT
/*****************************************************************************
- * $definitions / declarations *
- *****************************************************************************/
+* $definitions / declarations *
+*****************************************************************************/
/**
* The maximum time to wait for a single ATT response. The spec defines this
```
</details>
#### nimble/host/src/ble_gatts_lcl.c
<details>
```diff
@@ -26,7 +26,7 @@
#if NIMBLE_BLE_CONNECT
static const ble_uuid_t *uuid_ccc =
- BLE_UUID16_DECLARE(BLE_GATT_DSC_CLT_CFG_UUID16);
+ BLE_UUID16_DECLARE(BLE_GATT_DSC_CLT_CFG_UUID16);
static const char * const ble_gatt_chr_f_names[] = {
"BROADCAST",
```
</details>
#### nimble/host/src/ble_l2cap_sig.c
<details>
```diff
@@ -50,8 +50,8 @@
#if NIMBLE_BLE_CONNECT
/*****************************************************************************
- * $definitions / declarations *
- *****************************************************************************/
+* $definitions / declarations *
+*****************************************************************************/
#define BLE_L2CAP_SIG_UNRESPONSIVE_TIMEOUT 30000 /* Milliseconds. */
```
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #913: Optimize host size
Posted by GitBox <gi...@apache.org>.
apache-mynewt-bot commented on pull request #913:
URL: https://github.com/apache/mynewt-nimble/pull/913#issuecomment-779682021
<!-- style-bot -->
## Style check summary
### Our coding style is [here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)
#### nimble/host/services/gap/src/ble_svc_gap.c
<details>
```diff
@@ -38,7 +38,7 @@
static ble_svc_gap_chr_changed_fn *ble_svc_gap_chr_changed_cb_fn;
static char ble_svc_gap_name[BLE_SVC_GAP_NAME_MAX_LEN + 1] =
- MYNEWT_VAL(BLE_SVC_GAP_DEVICE_NAME);
+ MYNEWT_VAL(BLE_SVC_GAP_DEVICE_NAME);
static uint16_t ble_svc_gap_appearance = MYNEWT_VAL(BLE_SVC_GAP_APPEARANCE);
#if NIMBLE_BLE_CONNECT
```
</details>
#### nimble/host/src/ble_att_clt.c
<details>
```diff
@@ -28,8 +28,8 @@
#if NIMBLE_BLE_CONNECT
/*****************************************************************************
- * $error response *
- *****************************************************************************/
+* $error response *
+*****************************************************************************/
int
ble_att_clt_rx_error(uint16_t conn_handle, struct os_mbuf **rxom)
```
</details>
#### nimble/host/src/ble_gap.c
<details>
```diff
@@ -386,8 +386,8 @@
#endif
/*****************************************************************************
- * $snapshot *
- *****************************************************************************/
+* $snapshot *
+*****************************************************************************/
#if NIMBLE_BLE_CONNECT
static void
@@ -620,7 +620,7 @@
int
ble_gap_set_prefered_le_phy(uint16_t conn_handle, uint8_t tx_phys_mask,
- uint8_t rx_phys_mask, uint16_t phy_opts)
+ uint8_t rx_phys_mask, uint16_t phy_opts)
{
#if NIMBLE_BLE_CONNECT
struct ble_hci_le_set_phy_cp cmd;
@@ -5147,8 +5145,8 @@
}
/*****************************************************************************
- * $cancel *
- *****************************************************************************/
+* $cancel *
+*****************************************************************************/
#if NIMBLE_BLE_CONNECT
static int
```
</details>
#### nimble/host/src/ble_gattc.c
<details>
```diff
@@ -62,8 +62,8 @@
#if NIMBLE_BLE_CONNECT
/*****************************************************************************
- * $definitions / declarations *
- *****************************************************************************/
+* $definitions / declarations *
+*****************************************************************************/
/**
* The maximum time to wait for a single ATT response. The spec defines this
```
</details>
#### nimble/host/src/ble_gatts_lcl.c
<details>
```diff
@@ -26,7 +26,7 @@
#if NIMBLE_BLE_CONNECT
static const ble_uuid_t *uuid_ccc =
- BLE_UUID16_DECLARE(BLE_GATT_DSC_CLT_CFG_UUID16);
+ BLE_UUID16_DECLARE(BLE_GATT_DSC_CLT_CFG_UUID16);
static const char * const ble_gatt_chr_f_names[] = {
"BROADCAST",
```
</details>
#### nimble/host/src/ble_l2cap_sig.c
<details>
```diff
@@ -50,8 +50,8 @@
#if NIMBLE_BLE_CONNECT
/*****************************************************************************
- * $definitions / declarations *
- *****************************************************************************/
+* $definitions / declarations *
+*****************************************************************************/
#define BLE_L2CAP_SIG_UNRESPONSIVE_TIMEOUT 30000 /* Milliseconds. */
```
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #913: Optimize host size
Posted by GitBox <gi...@apache.org>.
apache-mynewt-bot commented on pull request #913:
URL: https://github.com/apache/mynewt-nimble/pull/913#issuecomment-779809233
<!-- style-bot -->
## Style check summary
### Our coding style is [here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)
#### nimble/host/services/gap/src/ble_svc_gap.c
<details>
```diff
@@ -38,7 +38,7 @@
static ble_svc_gap_chr_changed_fn *ble_svc_gap_chr_changed_cb_fn;
static char ble_svc_gap_name[BLE_SVC_GAP_NAME_MAX_LEN + 1] =
- MYNEWT_VAL(BLE_SVC_GAP_DEVICE_NAME);
+ MYNEWT_VAL(BLE_SVC_GAP_DEVICE_NAME);
static uint16_t ble_svc_gap_appearance = MYNEWT_VAL(BLE_SVC_GAP_APPEARANCE);
#if NIMBLE_BLE_CONNECT
```
</details>
#### nimble/host/src/ble_att_clt.c
<details>
```diff
@@ -28,8 +28,8 @@
#if NIMBLE_BLE_CONNECT
/*****************************************************************************
- * $error response *
- *****************************************************************************/
+* $error response *
+*****************************************************************************/
int
ble_att_clt_rx_error(uint16_t conn_handle, struct os_mbuf **rxom)
```
</details>
#### nimble/host/src/ble_gap.c
<details>
```diff
@@ -386,8 +386,8 @@
#endif
/*****************************************************************************
- * $snapshot *
- *****************************************************************************/
+* $snapshot *
+*****************************************************************************/
#if NIMBLE_BLE_CONNECT
static void
@@ -620,7 +620,7 @@
int
ble_gap_set_prefered_le_phy(uint16_t conn_handle, uint8_t tx_phys_mask,
- uint8_t rx_phys_mask, uint16_t phy_opts)
+ uint8_t rx_phys_mask, uint16_t phy_opts)
{
#if NIMBLE_BLE_CONNECT
struct ble_hci_le_set_phy_cp cmd;
@@ -5141,8 +5139,8 @@
}
/*****************************************************************************
- * $cancel *
- *****************************************************************************/
+* $cancel *
+*****************************************************************************/
#if NIMBLE_BLE_CONNECT
static int
```
</details>
#### nimble/host/src/ble_gattc.c
<details>
```diff
@@ -62,8 +62,8 @@
#if NIMBLE_BLE_CONNECT
/*****************************************************************************
- * $definitions / declarations *
- *****************************************************************************/
+* $definitions / declarations *
+*****************************************************************************/
/**
* The maximum time to wait for a single ATT response. The spec defines this
```
</details>
#### nimble/host/src/ble_gatts_lcl.c
<details>
```diff
@@ -26,7 +26,7 @@
#if NIMBLE_BLE_CONNECT
static const ble_uuid_t *uuid_ccc =
- BLE_UUID16_DECLARE(BLE_GATT_DSC_CLT_CFG_UUID16);
+ BLE_UUID16_DECLARE(BLE_GATT_DSC_CLT_CFG_UUID16);
static const char * const ble_gatt_chr_f_names[] = {
"BROADCAST",
```
</details>
#### nimble/host/src/ble_l2cap_sig.c
<details>
```diff
@@ -50,8 +50,8 @@
#if NIMBLE_BLE_CONNECT
/*****************************************************************************
- * $definitions / declarations *
- *****************************************************************************/
+* $definitions / declarations *
+*****************************************************************************/
#define BLE_L2CAP_SIG_UNRESPONSIVE_TIMEOUT 30000 /* Milliseconds. */
```
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #913: Optimize host size
Posted by GitBox <gi...@apache.org>.
apache-mynewt-bot commented on pull request #913:
URL: https://github.com/apache/mynewt-nimble/pull/913#issuecomment-779625543
<!-- style-bot -->
## Style check summary
### Our coding style is [here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)
#### nimble/host/services/gap/src/ble_svc_gap.c
<details>
```diff
@@ -38,7 +38,7 @@
static ble_svc_gap_chr_changed_fn *ble_svc_gap_chr_changed_cb_fn;
static char ble_svc_gap_name[BLE_SVC_GAP_NAME_MAX_LEN + 1] =
- MYNEWT_VAL(BLE_SVC_GAP_DEVICE_NAME);
+ MYNEWT_VAL(BLE_SVC_GAP_DEVICE_NAME);
static uint16_t ble_svc_gap_appearance = MYNEWT_VAL(BLE_SVC_GAP_APPEARANCE);
#if NIMBLE_BLE_CONNECT
```
</details>
#### nimble/host/src/ble_att_clt.c
<details>
```diff
@@ -28,8 +28,8 @@
#if NIMBLE_BLE_CONNECT
/*****************************************************************************
- * $error response *
- *****************************************************************************/
+* $error response *
+*****************************************************************************/
int
ble_att_clt_rx_error(uint16_t conn_handle, struct os_mbuf **rxom)
```
</details>
#### nimble/host/src/ble_gap.c
<details>
```diff
@@ -386,8 +386,8 @@
#endif
/*****************************************************************************
- * $snapshot *
- *****************************************************************************/
+* $snapshot *
+*****************************************************************************/
#if NIMBLE_BLE_CONNECT
static void
@@ -620,7 +620,7 @@
int
ble_gap_set_prefered_le_phy(uint16_t conn_handle, uint8_t tx_phys_mask,
- uint8_t rx_phys_mask, uint16_t phy_opts)
+ uint8_t rx_phys_mask, uint16_t phy_opts)
{
#if NIMBLE_BLE_CONNECT
struct ble_hci_le_set_phy_cp cmd;
@@ -5147,8 +5145,8 @@
}
/*****************************************************************************
- * $cancel *
- *****************************************************************************/
+* $cancel *
+*****************************************************************************/
#if NIMBLE_BLE_CONNECT
static int
```
</details>
#### nimble/host/src/ble_gattc.c
<details>
```diff
@@ -62,8 +62,8 @@
#if NIMBLE_BLE_CONNECT
/*****************************************************************************
- * $definitions / declarations *
- *****************************************************************************/
+* $definitions / declarations *
+*****************************************************************************/
/**
* The maximum time to wait for a single ATT response. The spec defines this
```
</details>
#### nimble/host/src/ble_gatts_lcl.c
<details>
```diff
@@ -26,7 +26,7 @@
#if NIMBLE_BLE_CONNECT
static const ble_uuid_t *uuid_ccc =
- BLE_UUID16_DECLARE(BLE_GATT_DSC_CLT_CFG_UUID16);
+ BLE_UUID16_DECLARE(BLE_GATT_DSC_CLT_CFG_UUID16);
static const char * const ble_gatt_chr_f_names[] = {
"BROADCAST",
```
</details>
#### nimble/host/src/ble_l2cap_sig.c
<details>
```diff
@@ -50,8 +50,8 @@
#if NIMBLE_BLE_CONNECT
/*****************************************************************************
- * $definitions / declarations *
- *****************************************************************************/
+* $definitions / declarations *
+*****************************************************************************/
#define BLE_L2CAP_SIG_UNRESPONSIVE_TIMEOUT 30000 /* Milliseconds. */
```
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-nimble] KKopyscinski commented on pull request #913: Optimize host size
Posted by GitBox <gi...@apache.org>.
KKopyscinski commented on pull request #913:
URL: https://github.com/apache/mynewt-nimble/pull/913#issuecomment-779792566
this soves https://github.com/apache/mynewt-nimble/issues/224
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org