Re: svndumpfilter --drop-empty-revs

[Rafael Garcia-Suarez <ra...@hexaflux.com>]

cmpilato@collab.net wrote:
> Rafael Garcia-Suarez writes:
> 
> > Yes indeed ; what I meant is that, from the user point of view,
> > the sole option "--renumber-revs" seems sufficient. I don't see
> > the point of having "--renumber-revs" _and_ "--drop-empty-revs",
> > and that's why I'm asking if there's something I've missed
> > about those options.
> 
> If you run a dumpfile of revision 50-100 through svndumpfilter
> --renumber-revs, does its output begin with revision 0 or 1?  If so,
> then there's your reason.

Thanks, I understand now ; grepping a dumpfile for /Revision-number/
shows the effect of the renumbering.

> Of course, effectively (at least from 'svnadmin load's current point
> of view) that's a no-op, since it doesn't really care what you *call*
> your revision -- they are sequentially loaded regardless.

I suggest the following minor rephrasing for the help message of
svndumpfilter : (cc:ing dev)

--- subversion/svndumpfilter/main.c.orig
+++ subversion/svndumpfilter/main.c
@@ -663,7 +663,7 @@
     {"drop-empty-revs",   svndumpfilter__drop_empty_revs, 0,
      "Remove revisions emptied by filtering."},
     {"renumber-revs",     svndumpfilter__renumber_revs, 0,
-     "Renumber revisions left after filtering." },
+     "Renumber revisions in resulting dumpfile." },
 
     {NULL}
   };
End of Patch.

That makes clearer that renumbering and filtering are in fact dissociated.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org