You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@lucene.apache.org by "Robert Muir (JIRA)" <ji...@apache.org> on 2014/12/01 17:42:12 UTC

[jira] [Updated] (LUCENE-6085) Add back SI.attributes (safely)

     [ https://issues.apache.org/jira/browse/LUCENE-6085?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Robert Muir updated LUCENE-6085:
--------------------------------
    Attachment: LUCENE-6085.patch

Here's a initial patch.

> Add back SI.attributes (safely)
> -------------------------------
>
>                 Key: LUCENE-6085
>                 URL: https://issues.apache.org/jira/browse/LUCENE-6085
>             Project: Lucene - Core
>          Issue Type: Bug
>            Reporter: Robert Muir
>         Attachments: LUCENE-6085.patch
>
>
> We removed this for two reasons:
> * nothing was using it
> * the map is "unsafe" if a codec tried to write to it during in-place dv update.
> But Adrien has a real use case (LUCENE-5914), and I think we can just add some safety for the updates case (e.g. if the map is unmodifiable then the trap will not exist, any put() will throw exception). In general, we should have more safety in SI anyway (diagnostics map, too).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org